From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: Matthew Auld <matthew.auld@intel.com>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: remove writeq ifdeffery
Date: Mon, 12 Sep 2016 11:32:10 +0300 [thread overview]
Message-ID: <1473669130.3986.0.camel@linux.intel.com> (raw)
In-Reply-To: <1473451373-9852-1-git-send-email-matthew.auld@intel.com>
On pe, 2016-09-09 at 21:02 +0100, Matthew Auld wrote:
> drm already provides fallback versions of readq and writeq.
>
> Signed-off-by: Matthew Auld <matthew.auld@intel.com>
Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Thanks for the patch, merging it in.
Regards, Joonas
> ---
> drivers/gpu/drm/i915/i915_gem_gtt.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915/i915_gem_gtt.c
> index f3c6876..ceb8d88 100644
> --- a/drivers/gpu/drm/i915/i915_gem_gtt.c
> +++ b/drivers/gpu/drm/i915/i915_gem_gtt.c
> @@ -2304,12 +2304,7 @@ int i915_gem_gtt_prepare_object(struct drm_i915_gem_object *obj)
>
> static void gen8_set_pte(void __iomem *addr, gen8_pte_t pte)
> {
> -#ifdef writeq
> writeq(pte, addr);
> -#else
> - iowrite32((u32)pte, addr);
> - iowrite32(pte >> 32, addr + 4);
> -#endif
> }
>
> static void gen8_ggtt_insert_page(struct i915_address_space *vm,
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2016-09-12 8:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-09 20:02 [PATCH] drm/i915: remove writeq ifdeffery Matthew Auld
2016-09-09 21:49 ` ✓ Fi.CI.BAT: success for " Patchwork
2016-09-12 8:32 ` Joonas Lahtinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1473669130.3986.0.camel@linux.intel.com \
--to=joonas.lahtinen@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=matthew.auld@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).