From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mika Kahola Subject: Re: [PATCH v2 3/5] drm/i915: Change the placement of some static functions in intel_dp.c Date: Thu, 15 Sep 2016 10:41:23 +0300 Message-ID: <1473925283.20751.27.camel@intel.com> References: <1473815299-26961-1-git-send-email-manasi.d.navare@intel.com> <1473815299-26961-4-git-send-email-manasi.d.navare@intel.com> Reply-To: mika.kahola@intel.com Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id B5FA96E173 for ; Thu, 15 Sep 2016 07:41:24 +0000 (UTC) In-Reply-To: <1473815299-26961-4-git-send-email-manasi.d.navare@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Manasi Navare , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCAyMDE2LTA5LTEzIGF0IDE4OjA4IC0wNzAwLCBNYW5hc2kgTmF2YXJlIHdyb3RlOgo+ IFRoZXNlIHN0YXRpYyBoZWxwZXIgZnVuY3Rpb25zIGFyZSByZXF1aXJlZCB0byBiZSB1c2VkIHdp dGhpbiB1cGZyb250Cj4gbGluayB0cmFpbmluZyByZWxhdGVkIGZ1bmN0aW9ucyBzbyB0aGV5IG5l ZWQgdG8gYmUgcGxhY2VkIGF0IHRoZSB0b3AKPiBvZiB0aGUgZmlsZS4gSXQgYWxzbyBjaGFuZ2Vz IG1hY3JvIGRldiB0byBkZXZfcHJpdi4KPiAKV2UgY291bGQgc3BsaXQgdGhpcyBwYXRjaCBpbnRv IHR3byBwYXJ0cy4gT25lIGJlaW5nIG1vdmluZyBhcm91bmQgdGhlCmhlbHBlciBmdW5jdGlvbnMg YW5kIHRoZSBvdGhlciBvbmUgY2xlYW51cCBwYXRjaCB0byBjaGFuZ2UgZGV2IGluIGZhdm9yCm9m IGRldl9wcml2LgoKPiB2MjoKPiAqIERvbnQgbW92ZSBhcm91bmQgZnVuY3Rpb25zIGRlY2xhcmVk IGluIGludGVsX2Rydi5oIChSb2RyaWdvIFZpdmkpCj4gCj4gU2lnbmVkLW9mZi1ieTogTWFuYXNp IE5hdmFyZSA8bWFuYXNpLmQubmF2YXJlQGludGVsLmNvbT4KPiAtLS0KPiDCoGRyaXZlcnMvZ3B1 L2RybS9pOTE1L2ludGVsX2RwLmMgfCAxNTggKysrKysrKysrKysrKysrKysrKystLS0tLS0tLQo+ IC0tLS0tLS0tLS0tLQo+IMKgMSBmaWxlIGNoYW5nZWQsIDc5IGluc2VydGlvbnMoKyksIDc5IGRl bGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9k cC5jCj4gYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5jCj4gaW5kZXggMDdmOWE0OS4u YTMxOTEwMiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5jCj4g KysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYwo+IEBAIC0xOTAsNiArMTkwLDgx IEBAIGludGVsX2RwX21heF9kYXRhX3JhdGUoaW50IG1heF9saW5rX2Nsb2NrLCBpbnQKPiBtYXhf bGFuZXMpCj4gwqAJcmV0dXJuIChtYXhfbGlua19jbG9jayAqIG1heF9sYW5lcyAqIDgpIC8gMTA7 Cj4gwqB9Cj4gwqAKPiArc3RhdGljIGludAo+ICtpbnRlbF9kcF9zaW5rX3JhdGVzKHN0cnVjdCBp bnRlbF9kcCAqaW50ZWxfZHAsIGNvbnN0IGludAo+ICoqc2lua19yYXRlcykKPiArewo+ICsJaWYg KGludGVsX2RwLT5udW1fc2lua19yYXRlcykgewo+ICsJCSpzaW5rX3JhdGVzID0gaW50ZWxfZHAt PnNpbmtfcmF0ZXM7Cj4gKwkJcmV0dXJuIGludGVsX2RwLT5udW1fc2lua19yYXRlczsKPiArCX0K PiArCj4gKwkqc2lua19yYXRlcyA9IGRlZmF1bHRfcmF0ZXM7Cj4gKwo+ICsJcmV0dXJuIChpbnRl bF9kcF9tYXhfbGlua19idyhpbnRlbF9kcCkgPj4gMykgKyAxOwo+ICt9Cj4gKwo+ICtzdGF0aWMg aW50Cj4gK2ludGVsX2RwX3NvdXJjZV9yYXRlcyhzdHJ1Y3QgaW50ZWxfZHAgKmludGVsX2RwLCBj b25zdCBpbnQKPiAqKnNvdXJjZV9yYXRlcykKPiArewo+ICsJc3RydWN0IGludGVsX2RpZ2l0YWxf cG9ydCAqZGlnX3BvcnQgPQo+IGRwX3RvX2RpZ19wb3J0KGludGVsX2RwKTsKPiArCXN0cnVjdCBk cm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IHRvX2k5MTUoZGlnX3BvcnQtCj4gPmJhc2UuYmFz ZS5kZXYpOwo+ICsJaW50IHNpemU7Cj4gKwo+ICsJaWYgKElTX0JST1hUT04oZGV2X3ByaXYpKSB7 Cj4gKwkJKnNvdXJjZV9yYXRlcyA9IGJ4dF9yYXRlczsKPiArCQlzaXplID0gQVJSQVlfU0laRShi eHRfcmF0ZXMpOwo+ICsJfSBlbHNlIGlmIChJU19TS1lMQUtFKGRldl9wcml2KSB8fCBJU19LQUJZ TEFLRShkZXZfcHJpdikpIHsKPiArCQkqc291cmNlX3JhdGVzID0gc2tsX3JhdGVzOwo+ICsJCXNp emUgPSBBUlJBWV9TSVpFKHNrbF9yYXRlcyk7Cj4gKwl9IGVsc2Ugewo+ICsJCSpzb3VyY2VfcmF0 ZXMgPSBkZWZhdWx0X3JhdGVzOwo+ICsJCXNpemUgPSBBUlJBWV9TSVpFKGRlZmF1bHRfcmF0ZXMp Owo+ICsJfQo+ICsKPiArCS8qIFRoaXMgZGVwZW5kcyBvbiB0aGUgZmFjdCB0aGF0IDUuNCBpcyBs YXN0IHZhbHVlIGluIHRoZQo+IGFycmF5ICovCj4gKwlpZiAoIWludGVsX2RwX3NvdXJjZV9zdXBw b3J0c19oYnIyKGludGVsX2RwKSkKPiArCQlzaXplLS07Cj4gKwo+ICsJcmV0dXJuIHNpemU7Cj4g K30KPiArCj4gK3N0YXRpYyBpbnQgaW50ZXJzZWN0X3JhdGVzKGNvbnN0IGludCAqc291cmNlX3Jh dGVzLCBpbnQgc291cmNlX2xlbiwKPiArCQkJwqDCoMKgY29uc3QgaW50ICpzaW5rX3JhdGVzLCBp bnQgc2lua19sZW4sCj4gKwkJCcKgwqDCoGludCAqY29tbW9uX3JhdGVzKQo+ICt7Cj4gKwlpbnQg aSA9IDAsIGogPSAwLCBrID0gMDsKPiArCj4gKwl3aGlsZSAoaSA8IHNvdXJjZV9sZW4gJiYgaiA8 IHNpbmtfbGVuKSB7Cj4gKwkJaWYgKHNvdXJjZV9yYXRlc1tpXSA9PSBzaW5rX3JhdGVzW2pdKSB7 Cj4gKwkJCWlmIChXQVJOX09OKGsgPj0gRFBfTUFYX1NVUFBPUlRFRF9SQVRFUykpCj4gKwkJCQly ZXR1cm4gazsKPiArCQkJY29tbW9uX3JhdGVzW2tdID0gc291cmNlX3JhdGVzW2ldOwo+ICsJCQkr K2s7Cj4gKwkJCSsraTsKPiArCQkJKytqOwo+ICsJCX0gZWxzZSBpZiAoc291cmNlX3JhdGVzW2ld IDwgc2lua19yYXRlc1tqXSkgewo+ICsJCQkrK2k7Cj4gKwkJfSBlbHNlIHsKPiArCQkJKytqOwo+ ICsJCX0KPiArCX0KPiArCXJldHVybiBrOwo+ICt9Cj4gKwo+ICtzdGF0aWMgaW50IGludGVsX2Rw X2NvbW1vbl9yYXRlcyhzdHJ1Y3QgaW50ZWxfZHAgKmludGVsX2RwLAo+ICsJCQkJwqBpbnQgKmNv bW1vbl9yYXRlcykKPiArewo+ICsJY29uc3QgaW50ICpzb3VyY2VfcmF0ZXMsICpzaW5rX3JhdGVz Owo+ICsJaW50IHNvdXJjZV9sZW4sIHNpbmtfbGVuOwo+ICsKPiArCXNpbmtfbGVuID0gaW50ZWxf ZHBfc2lua19yYXRlcyhpbnRlbF9kcCwgJnNpbmtfcmF0ZXMpOwo+ICsJc291cmNlX2xlbiA9IGlu dGVsX2RwX3NvdXJjZV9yYXRlcyhpbnRlbF9kcCwgJnNvdXJjZV9yYXRlcyk7Cj4gKwo+ICsJcmV0 dXJuIGludGVyc2VjdF9yYXRlcyhzb3VyY2VfcmF0ZXMsIHNvdXJjZV9sZW4sCj4gKwkJCcKgwqDC oMKgwqDCoMKgc2lua19yYXRlcywgc2lua19sZW4sCj4gKwkJCcKgwqDCoMKgwqDCoMKgY29tbW9u X3JhdGVzKTsKPiArfQo+ICsKPiDCoHN0YXRpYyBlbnVtIGRybV9tb2RlX3N0YXR1cwo+IMKgaW50 ZWxfZHBfbW9kZV92YWxpZChzdHJ1Y3QgZHJtX2Nvbm5lY3RvciAqY29ubmVjdG9yLAo+IMKgCQnC oMKgwqDCoHN0cnVjdCBkcm1fZGlzcGxheV9tb2RlICptb2RlKQo+IEBAIC0xMjU2LDYwICsxMzMx LDIyIEBAIGludGVsX2RwX2F1eF9pbml0KHN0cnVjdCBpbnRlbF9kcCAqaW50ZWxfZHAsCj4gc3Ry dWN0IGludGVsX2Nvbm5lY3RvciAqY29ubmVjdG9yKQo+IMKgCWludGVsX2RwLT5hdXgudHJhbnNm ZXIgPSBpbnRlbF9kcF9hdXhfdHJhbnNmZXI7Cj4gwqB9Cj4gwqAKPiAtc3RhdGljIGludAo+IC1p bnRlbF9kcF9zaW5rX3JhdGVzKHN0cnVjdCBpbnRlbF9kcCAqaW50ZWxfZHAsIGNvbnN0IGludAo+ ICoqc2lua19yYXRlcykKPiAtewo+IC0JaWYgKGludGVsX2RwLT5udW1fc2lua19yYXRlcykgewo+ IC0JCSpzaW5rX3JhdGVzID0gaW50ZWxfZHAtPnNpbmtfcmF0ZXM7Cj4gLQkJcmV0dXJuIGludGVs X2RwLT5udW1fc2lua19yYXRlczsKPiAtCX0KPiAtCj4gLQkqc2lua19yYXRlcyA9IGRlZmF1bHRf cmF0ZXM7Cj4gLQo+IC0JcmV0dXJuIChpbnRlbF9kcF9tYXhfbGlua19idyhpbnRlbF9kcCkgPj4g MykgKyAxOwo+IC19Cj4gLQo+IMKgYm9vbCBpbnRlbF9kcF9zb3VyY2Vfc3VwcG9ydHNfaGJyMihz dHJ1Y3QgaW50ZWxfZHAgKmludGVsX2RwKQo+IMKgewo+IMKgCXN0cnVjdCBpbnRlbF9kaWdpdGFs X3BvcnQgKmRpZ19wb3J0ID0KPiBkcF90b19kaWdfcG9ydChpbnRlbF9kcCk7Cj4gLQlzdHJ1Y3Qg ZHJtX2RldmljZSAqZGV2ID0gZGlnX3BvcnQtPmJhc2UuYmFzZS5kZXY7Cj4gKwlzdHJ1Y3QgZHJt X2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSB0b19pOTE1KGRpZ19wb3J0LQo+ID5iYXNlLmJhc2Uu ZGV2KTsKPiDCoAo+IMKgCS8qIFdhRGlzYWJsZUhCUjI6c2tsICovCj4gLQlpZiAoSVNfU0tMX1JF VklEKGRldiwgMCwgU0tMX1JFVklEX0IwKSkKPiArCWlmIChJU19TS0xfUkVWSUQoZGV2X3ByaXYs IDAsIFNLTF9SRVZJRF9CMCkpCj4gwqAJCXJldHVybiBmYWxzZTsKPiDCoAo+IC0JaWYgKChJU19I QVNXRUxMKGRldikgJiYgIUlTX0hTV19VTFgoZGV2KSkgfHwKPiBJU19CUk9BRFdFTEwoZGV2KSB8 fAo+IC0JwqDCoMKgwqAoSU5URUxfSU5GTyhkZXYpLT5nZW4gPj0gOSkpCj4gKwlpZiAoKElTX0hB U1dFTEwoZGV2X3ByaXYpICYmICFJU19IU1dfVUxYKGRldl9wcml2KSkgfHwKPiArCcKgwqDCoMKg SVNfQlJPQURXRUxMKGRldl9wcml2KSB8fCAoSU5URUxfR0VOKGRldl9wcml2KSA+PSA5KSkKPiDC oAkJcmV0dXJuIHRydWU7Cj4gwqAJZWxzZQo+IMKgCQlyZXR1cm4gZmFsc2U7Cj4gwqB9Cj4gwqAK PiAtc3RhdGljIGludAo+IC1pbnRlbF9kcF9zb3VyY2VfcmF0ZXMoc3RydWN0IGludGVsX2RwICpp bnRlbF9kcCwgY29uc3QgaW50Cj4gKipzb3VyY2VfcmF0ZXMpCj4gLXsKPiAtCXN0cnVjdCBpbnRl bF9kaWdpdGFsX3BvcnQgKmRpZ19wb3J0ID0KPiBkcF90b19kaWdfcG9ydChpbnRlbF9kcCk7Cj4g LQlzdHJ1Y3QgZHJtX2RldmljZSAqZGV2ID0gZGlnX3BvcnQtPmJhc2UuYmFzZS5kZXY7Cj4gLQlp bnQgc2l6ZTsKPiAtCj4gLQlpZiAoSVNfQlJPWFRPTihkZXYpKSB7Cj4gLQkJKnNvdXJjZV9yYXRl cyA9IGJ4dF9yYXRlczsKPiAtCQlzaXplID0gQVJSQVlfU0laRShieHRfcmF0ZXMpOwo+IC0JfSBl bHNlIGlmIChJU19TS1lMQUtFKGRldikgfHwgSVNfS0FCWUxBS0UoZGV2KSkgewo+IC0JCSpzb3Vy Y2VfcmF0ZXMgPSBza2xfcmF0ZXM7Cj4gLQkJc2l6ZSA9IEFSUkFZX1NJWkUoc2tsX3JhdGVzKTsK PiAtCX0gZWxzZSB7Cj4gLQkJKnNvdXJjZV9yYXRlcyA9IGRlZmF1bHRfcmF0ZXM7Cj4gLQkJc2l6 ZSA9IEFSUkFZX1NJWkUoZGVmYXVsdF9yYXRlcyk7Cj4gLQl9Cj4gLQo+IC0JLyogVGhpcyBkZXBl bmRzIG9uIHRoZSBmYWN0IHRoYXQgNS40IGlzIGxhc3QgdmFsdWUgaW4gdGhlCj4gYXJyYXkgKi8K PiAtCWlmICghaW50ZWxfZHBfc291cmNlX3N1cHBvcnRzX2hicjIoaW50ZWxfZHApKQo+IC0JCXNp emUtLTsKPiAtCj4gLQlyZXR1cm4gc2l6ZTsKPiAtfQo+IC0KPiDCoHN0YXRpYyB2b2lkCj4gwqBp bnRlbF9kcF9zZXRfY2xvY2soc3RydWN0IGludGVsX2VuY29kZXIgKmVuY29kZXIsCj4gwqAJCcKg wqDCoHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpwaXBlX2NvbmZpZykKPiBAQCAtMTM0Myw0MyAr MTM4MCw2IEBAIGludGVsX2RwX3NldF9jbG9jayhzdHJ1Y3QgaW50ZWxfZW5jb2Rlcgo+ICplbmNv ZGVyLAo+IMKgCX0KPiDCoH0KPiDCoAo+IC1zdGF0aWMgaW50IGludGVyc2VjdF9yYXRlcyhjb25z dCBpbnQgKnNvdXJjZV9yYXRlcywgaW50IHNvdXJjZV9sZW4sCj4gLQkJCcKgwqDCoGNvbnN0IGlu dCAqc2lua19yYXRlcywgaW50IHNpbmtfbGVuLAo+IC0JCQnCoMKgwqBpbnQgKmNvbW1vbl9yYXRl cykKPiAtewo+IC0JaW50IGkgPSAwLCBqID0gMCwgayA9IDA7Cj4gLQo+IC0Jd2hpbGUgKGkgPCBz b3VyY2VfbGVuICYmIGogPCBzaW5rX2xlbikgewo+IC0JCWlmIChzb3VyY2VfcmF0ZXNbaV0gPT0g c2lua19yYXRlc1tqXSkgewo+IC0JCQlpZiAoV0FSTl9PTihrID49IERQX01BWF9TVVBQT1JURURf UkFURVMpKQo+IC0JCQkJcmV0dXJuIGs7Cj4gLQkJCWNvbW1vbl9yYXRlc1trXSA9IHNvdXJjZV9y YXRlc1tpXTsKPiAtCQkJKytrOwo+IC0JCQkrK2k7Cj4gLQkJCSsrajsKPiAtCQl9IGVsc2UgaWYg KHNvdXJjZV9yYXRlc1tpXSA8IHNpbmtfcmF0ZXNbal0pIHsKPiAtCQkJKytpOwo+IC0JCX0gZWxz ZSB7Cj4gLQkJCSsrajsKPiAtCQl9Cj4gLQl9Cj4gLQlyZXR1cm4gazsKPiAtfQo+IC0KPiAtc3Rh dGljIGludCBpbnRlbF9kcF9jb21tb25fcmF0ZXMoc3RydWN0IGludGVsX2RwICppbnRlbF9kcCwK PiAtCQkJCcKgaW50ICpjb21tb25fcmF0ZXMpCj4gLXsKPiAtCWNvbnN0IGludCAqc291cmNlX3Jh dGVzLCAqc2lua19yYXRlczsKPiAtCWludCBzb3VyY2VfbGVuLCBzaW5rX2xlbjsKPiAtCj4gLQlz aW5rX2xlbiA9IGludGVsX2RwX3NpbmtfcmF0ZXMoaW50ZWxfZHAsICZzaW5rX3JhdGVzKTsKPiAt CXNvdXJjZV9sZW4gPSBpbnRlbF9kcF9zb3VyY2VfcmF0ZXMoaW50ZWxfZHAsICZzb3VyY2VfcmF0 ZXMpOwo+IC0KPiAtCXJldHVybiBpbnRlcnNlY3RfcmF0ZXMoc291cmNlX3JhdGVzLCBzb3VyY2Vf bGVuLAo+IC0JCQnCoMKgwqDCoMKgwqDCoHNpbmtfcmF0ZXMsIHNpbmtfbGVuLAo+IC0JCQnCoMKg wqDCoMKgwqDCoGNvbW1vbl9yYXRlcyk7Cj4gLX0KPiAtCj4gwqBzdGF0aWMgdm9pZCBzbnByaW50 Zl9pbnRfYXJyYXkoY2hhciAqc3RyLCBzaXplX3QgbGVuLAo+IMKgCQkJwqDCoMKgwqDCoMKgwqBj b25zdCBpbnQgKmFycmF5LCBpbnQgbmVsZW0pCj4gwqB7Ci0tIApNaWthIEthaG9sYSAtIEludGVs IE9UQwoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50 ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBz Oi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==