From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/2] drm/i915: Only shrink the unbound objects during freeze
Date: Mon, 19 Sep 2016 11:31:37 +0300 [thread overview]
Message-ID: <1474273897.3344.6.camel@linux.intel.com> (raw)
In-Reply-To: <20160916192318.14030-1-chris@chris-wilson.co.uk>
On pe, 2016-09-16 at 20:23 +0100, Chris Wilson wrote:
> int i915_gem_freeze_late(struct drm_i915_private *dev_priv)
> {
> > struct drm_i915_gem_object *obj;
> @@ -4692,7 +4705,8 @@ int i915_gem_freeze_late(struct drm_i915_private *dev_priv)
> > * the objects as well.
> > */
>
> > - i915_gem_shrink_all(dev_priv);
> + mutex_lock(&dev_priv->drm.struct_mutex);
Previously the shrinking here was without a mutex. And the new
shrinking during _freeze is also mutex protected, any specific reason?
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-09-19 8:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-16 19:23 [PATCH 1/2] drm/i915: Only shrink the unbound objects during freeze Chris Wilson
2016-09-16 19:23 ` [PATCH 2/2] drm/i915/execlists: Reset RING registers upon resume Chris Wilson
2016-09-19 8:24 ` Joonas Lahtinen
2016-09-19 8:31 ` Joonas Lahtinen [this message]
2016-09-19 8:38 ` [PATCH 1/2] drm/i915: Only shrink the unbound objects during freeze Chris Wilson
2016-09-19 12:09 ` Joonas Lahtinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1474273897.3344.6.camel@linux.intel.com \
--to=joonas.lahtinen@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).