[PATCH] drm/i915: don't report compression when fbc disabled

[PATCH] drm/i915: don't report compression when fbc disabled

[vathsala nagaraju]

when i915_fbc_status is read while fbc is disabled,
it reports compressing to be true, which is confusing.
report compressing only when fbc is enabled.

Signed-off-by: vathsala nagaraju <vathsala.nagaraju@intel.com>
---
 drivers/gpu/drm/i915/i915_debugfs.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
index cfcc72e..fb10cfc 100644
--- a/drivers/gpu/drm/i915/i915_debugfs.c
+++ b/drivers/gpu/drm/i915/i915_debugfs.c
@@ -1658,7 +1658,8 @@ static int i915_fbc_status(struct seq_file *m, void *unused)
 		seq_printf(m, "FBC disabled: %s\n",
 			   dev_priv->fbc.no_fbc_reason);
 
-	if (INTEL_GEN(dev_priv) >= 7)
+	if (intel_fbc_is_active(dev_priv) &&
+	    INTEL_GEN(dev_priv) >= 7)
 		seq_printf(m, "Compressing: %s\n",
 			   yesno(I915_READ(FBC_STATUS2) &
 				 FBC_COMPRESSION_MASK));
-- 
2.7.4

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

✓ Fi.CI.BAT: success for drm/i915: don't report compression when fbc disabled

[Patchwork]

== Series Details ==

Series: drm/i915: don't report compression when fbc disabled
URL   : https://patchwork.freedesktop.org/series/12768/
State : success

== Summary ==

Series 12768v1 drm/i915: don't report compression when fbc disabled
https://patchwork.freedesktop.org/api/1.0/series/12768/revisions/1/mbox/

Test kms_pipe_crc_basic:
        Subgroup hang-read-crc-pipe-b:
                dmesg-warn -> PASS       (fi-hsw-4770k)
Test kms_psr_sink_crc:
        Subgroup psr_basic:
                dmesg-warn -> PASS       (fi-skl-6700hq)

fi-bdw-5557u     total:244  pass:222  dwarn:0   dfail:0   fail:7   skip:15 
fi-bsw-n3050     total:244  pass:191  dwarn:0   dfail:0   fail:23  skip:30 
fi-byt-n2820     total:244  pass:190  dwarn:0   dfail:0   fail:19  skip:35 
fi-hsw-4770k     total:244  pass:215  dwarn:0   dfail:0   fail:7   skip:22 
fi-hsw-4770r     total:244  pass:215  dwarn:0   dfail:0   fail:7   skip:22 
fi-ilk-650       total:244  pass:176  dwarn:0   dfail:0   fail:8   skip:60 
fi-ivb-3520m     total:244  pass:212  dwarn:0   dfail:0   fail:7   skip:25 
fi-ivb-3770      total:244  pass:207  dwarn:0   dfail:0   fail:0   skip:37 
fi-skl-6260u     total:244  pass:223  dwarn:0   dfail:0   fail:7   skip:14 
fi-skl-6700hq    total:244  pass:214  dwarn:0   dfail:0   fail:8   skip:22 
fi-skl-6700k     total:244  pass:212  dwarn:1   dfail:0   fail:7   skip:24 
fi-skl-6770hq    total:244  pass:221  dwarn:1   dfail:0   fail:8   skip:14 
fi-snb-2520m     total:244  pass:202  dwarn:0   dfail:0   fail:6   skip:36 
fi-snb-2600      total:244  pass:200  dwarn:0   dfail:0   fail:6   skip:38 

Results at /archive/results/CI_IGT_test/Patchwork_2568/

405fa9d85079a608a4f0da0e6136822c005e1c4b drm-intel-nightly: 2016y-09m-22d-12h-10m-28s UTC integration manifest
76313a6 drm/i915: don't report compression when fbc disabled

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm/i915: don't report compression when fbc disabled

[Paulo Zanoni]

Em Qui, 2016-09-22 às 14:19 +0530, vathsala nagaraju escreveu:
> when i915_fbc_status is read while fbc is disabled,
> it reports compressing to be true, which is confusing.
> report compressing only when fbc is enabled.
> 
> Signed-off-by: vathsala nagaraju <vathsala.nagaraju@intel.com>
> ---
>  drivers/gpu/drm/i915/i915_debugfs.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_debugfs.c
> b/drivers/gpu/drm/i915/i915_debugfs.c
> index cfcc72e..fb10cfc 100644
> --- a/drivers/gpu/drm/i915/i915_debugfs.c
> +++ b/drivers/gpu/drm/i915/i915_debugfs.c
> @@ -1658,7 +1658,8 @@ static int i915_fbc_status(struct seq_file *m,
> void *unused)
>  		seq_printf(m, "FBC disabled: %s\n",
>  			   dev_priv->fbc.no_fbc_reason);
>  
> -	if (INTEL_GEN(dev_priv) >= 7)
> +	if (intel_fbc_is_active(dev_priv) &&
> +	    INTEL_GEN(dev_priv) >= 7)

Reviewed-by: Paulo Zanoni <paulo.r.zanoni@intel.com>

I'll push this patch soon. Thanks for the patch!

>  		seq_printf(m, "Compressing: %s\n",
>  			   yesno(I915_READ(FBC_STATUS2) &
>  				 FBC_COMPRESSION_MASK));
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx