From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: Jani Nikula <jani.nikula@linux.intel.com>,
ville.syrjala@linux.intel.com, intel-gfx@lists.freedesktop.org
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Subject: Re: [PATCH i-g-t 1/5] tests: Use bash for debugfs_wedged and drm_lib.sh
Date: Fri, 07 Oct 2016 12:54:03 +0300 [thread overview]
Message-ID: <1475834043.6623.4.camel@linux.intel.com> (raw)
In-Reply-To: <87twcowqv9.fsf@intel.com>
On pe, 2016-10-07 at 10:38 +0300, Jani Nikula wrote:
> The "change" to use bash just reflects current reality. All the changes
> here look simple and sane, and immediately improve the results. The work
> is already done, no use blocking them because someone might eventually
> rewrite them in C. (And it will be a PITA to write the module reload
> test in C, so I wouldn't hold my breath.)
>
The scripts are really simple, most of the scripts even use POSIX sh
compliant constructs but just the wrong shebang. And sometimes some a
advanced bash feature here and there which could be replaced easily.
> For the series,
>
> Reviewed-by: Jani Nikula <jani.nikula@intel.com>
>
>
> PS. When I look at IGT and the macro/setjmp/longjmp magic to create the
> test/subtest/fixture infrastructure, making the tests look like they've
> been written in some extended version of C, I have to question whether C
> really is the right language for the tests. libdrm python bindings and
> python, anyone?
My patches to convert away from bash were to allow running the tests in
minimal initramfs environment where the kernel + IGT would be a
standalone bzImage suitable for netbooting, but we can go to another
direction too, and lets add Java as runtime requirement for I-G-T!
Regards, Joonas
<plaintext>I'm against converting to bash/python for no
benefit.</plaintext>
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-10-07 9:54 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-06 13:36 [PATCH i-g-t 1/5] tests: Use bash for debugfs_wedged and drm_lib.sh ville.syrjala
2016-10-06 13:36 ` [PATCH i-g-t 2/5] tests: Leave basic breadcrumbs in dmesg for shell script based tests ville.syrjala
2016-10-07 7:24 ` Jani Nikula
2016-10-07 10:06 ` Ville Syrjälä
2016-10-06 13:36 ` [PATCH i-g-t 3/5] tests/vgem_reload_basic: Leave breadcrumbs in dmesg ville.syrjala
2016-10-06 13:36 ` [PATCH i-g-t 4/5] tests/tools_test: Fix it up for intel_reg ville.syrjala
2016-10-06 13:36 ` [PATCH i-g-t 5/5] tools/intel_reg: Return SUCCESS after a succesful dump ville.syrjala
2016-10-07 7:15 ` [PATCH i-g-t 1/5] tests: Use bash for debugfs_wedged and drm_lib.sh Joonas Lahtinen
2016-10-07 7:38 ` Jani Nikula
2016-10-07 9:54 ` Joonas Lahtinen [this message]
2016-10-12 10:12 ` David Weinehall
2016-10-12 11:05 ` Joonas Lahtinen
2016-10-12 11:16 ` Jani Nikula
2016-10-12 11:29 ` Joonas Lahtinen
2016-10-12 13:04 ` Jani Nikula
2016-10-12 13:17 ` David Weinehall
2016-10-13 14:05 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1475834043.6623.4.camel@linux.intel.com \
--to=joonas.lahtinen@linux.intel.com \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox