* [PATCH] drm/i915: Remove unused BSM_MASK causing warning
@ 2016-10-12 7:18 Joonas Lahtinen
2016-10-12 7:42 ` Chris Wilson
0 siblings, 1 reply; 3+ messages in thread
From: Joonas Lahtinen @ 2016-10-12 7:18 UTC (permalink / raw)
To: Intel graphics driver community testing & development
Cc: Jani Nikula, Daniel Vetter
Remove never used BSM{,_MASK}. BSM_MASK #define also causes a warning.
include/drm/i915_drm.h:96:34: warning: result of ‘65535 << 20’
requires 37 bits to represent, but ‘int’ only has 32 bits
[-Wshiftoverflow=]
#define INTEL_BSM_MASK (0xFFFF << 20)
Reported-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
---
drivers/gpu/drm/i915/i915_reg.h | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
index acc767a..3105872 100644
--- a/drivers/gpu/drm/i915/i915_reg.h
+++ b/drivers/gpu/drm/i915/i915_reg.h
@@ -86,8 +86,7 @@ static inline bool i915_mmio_reg_valid(i915_reg_t reg)
#define DEVEN 0x54
#define DEVEN_MCHBAR_EN (1 << 28)
-#define BSM 0x5c
-#define BSM_MASK (0xFFFF << 20)
+/* BSM in include/drm/i915_drm.h */
#define HPLLCC 0xc0 /* 85x only */
#define GC_CLOCK_CONTROL_MASK (0x7 << 0)
--
2.7.4
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] drm/i915: Remove unused BSM_MASK causing warning
2016-10-12 7:18 [PATCH] drm/i915: Remove unused BSM_MASK causing warning Joonas Lahtinen
@ 2016-10-12 7:42 ` Chris Wilson
2016-10-12 8:04 ` Joonas Lahtinen
0 siblings, 1 reply; 3+ messages in thread
From: Chris Wilson @ 2016-10-12 7:42 UTC (permalink / raw)
To: Joonas Lahtinen
Cc: Jani Nikula, Daniel Vetter,
Intel graphics driver community testing & development
On Wed, Oct 12, 2016 at 10:18:54AM +0300, Joonas Lahtinen wrote:
> Remove never used BSM{,_MASK}. BSM_MASK #define also causes a warning.
>
> include/drm/i915_drm.h:96:34: warning: result of ‘65535 << 20’
> requires 37 bits to represent, but ‘int’ only has 32 bits
> [-Wshiftoverflow=]
> #define INTEL_BSM_MASK (0xFFFF << 20)
>
> Reported-by: Linus Torvalds <torvalds@linux-foundation.org>
> Signed-off-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> ---
> drivers/gpu/drm/i915/i915_reg.h | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
> index acc767a..3105872 100644
> --- a/drivers/gpu/drm/i915/i915_reg.h
> +++ b/drivers/gpu/drm/i915/i915_reg.h
> @@ -86,8 +86,7 @@ static inline bool i915_mmio_reg_valid(i915_reg_t reg)
> #define DEVEN 0x54
> #define DEVEN_MCHBAR_EN (1 << 28)
>
> -#define BSM 0x5c
> -#define BSM_MASK (0xFFFF << 20)
> +/* BSM in include/drm/i915_drm.h */
greps ok.
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-10-12 8:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-10-12 7:18 [PATCH] drm/i915: Remove unused BSM_MASK causing warning Joonas Lahtinen
2016-10-12 7:42 ` Chris Wilson
2016-10-12 8:04 ` Joonas Lahtinen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox