From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: David Weinehall <david.weinehall@linux.intel.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH i-g-t 1/5] tests: Use bash for debugfs_wedged and drm_lib.sh
Date: Wed, 12 Oct 2016 14:05:11 +0300 [thread overview]
Message-ID: <1476270311.2817.10.camel@linux.intel.com> (raw)
In-Reply-To: <20161012101245.dlv25s5cd42thb5u@boom>
On ke, 2016-10-12 at 13:12 +0300, David Weinehall wrote:
> On Fri, Oct 07, 2016 at 12:54:03PM +0300, Joonas Lahtinen wrote:
> > <plaintext>I'm against converting to bash/python for no
> > benefit.</plaintext>
>
> +1, Insightful.
>
> Most of the bashisms seem to be simple cases of the superfluous
> "function" in front of functions...
>
Indeed. I'm still all in for converting all scripts under tests
directory to POSIX. Last time it was Nack due to intent to convert over
to C, but if we reflect to reality, we could now do the next best
option and convert to POSIX?
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-10-12 11:05 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-06 13:36 [PATCH i-g-t 1/5] tests: Use bash for debugfs_wedged and drm_lib.sh ville.syrjala
2016-10-06 13:36 ` [PATCH i-g-t 2/5] tests: Leave basic breadcrumbs in dmesg for shell script based tests ville.syrjala
2016-10-07 7:24 ` Jani Nikula
2016-10-07 10:06 ` Ville Syrjälä
2016-10-06 13:36 ` [PATCH i-g-t 3/5] tests/vgem_reload_basic: Leave breadcrumbs in dmesg ville.syrjala
2016-10-06 13:36 ` [PATCH i-g-t 4/5] tests/tools_test: Fix it up for intel_reg ville.syrjala
2016-10-06 13:36 ` [PATCH i-g-t 5/5] tools/intel_reg: Return SUCCESS after a succesful dump ville.syrjala
2016-10-07 7:15 ` [PATCH i-g-t 1/5] tests: Use bash for debugfs_wedged and drm_lib.sh Joonas Lahtinen
2016-10-07 7:38 ` Jani Nikula
2016-10-07 9:54 ` Joonas Lahtinen
2016-10-12 10:12 ` David Weinehall
2016-10-12 11:05 ` Joonas Lahtinen [this message]
2016-10-12 11:16 ` Jani Nikula
2016-10-12 11:29 ` Joonas Lahtinen
2016-10-12 13:04 ` Jani Nikula
2016-10-12 13:17 ` David Weinehall
2016-10-13 14:05 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1476270311.2817.10.camel@linux.intel.com \
--to=joonas.lahtinen@linux.intel.com \
--cc=daniel.vetter@ffwll.ch \
--cc=david.weinehall@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox