From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: Jani Nikula <jani.nikula@linux.intel.com>,
David Weinehall <david.weinehall@linux.intel.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH i-g-t 1/5] tests: Use bash for debugfs_wedged and drm_lib.sh
Date: Wed, 12 Oct 2016 14:29:17 +0300 [thread overview]
Message-ID: <1476271757.2817.18.camel@linux.intel.com> (raw)
In-Reply-To: <87eg3lyg08.fsf@intel.com>
On ke, 2016-10-12 at 14:16 +0300, Jani Nikula wrote:
> If you really care, go ahead and send the patches to make these Bourne
> shell compatible, but then do also sign up for testing them on non-bash
> shells. The CI won't. I don't think it's worth the trouble, but YMMV.
If they're re-written using POSIX sh constructs only, I don't think
they need to be tested outside of POSIX sh? That's what standards are
for.
I also remember FreeBSD guys being all for letting bash dependency go.
So there'd be actual gains too.
./scripts/run-tests.sh: Bourne-Again shell script, UTF-8 Unicode text executable
./scripts/who.sh: Bourne-Again shell script, ASCII text executable
./tests/vgem_reload_basic: Bourne-Again shell script, ASCII text executable
./tests/debugfs_emon_crash: Bourne-Again shell script, ASCII text executable
./tests/drv_module_reload_basic: Bourne-Again shell script, ASCII text executable
./tests/ddx_intel_after_fbdev: Bourne-Again shell script, ASCII text executable
./tests/test_rte_check: Bourne-Again shell script, ASCII text executable
./tests/tools_test: Bourne-Again shell script, ASCII text executable
./tests/check_drm_clients: Bourne-Again shell script, ASCII text executable
./tests/sysfs_l3_parity: Bourne-Again shell script, ASCII text executable
./tests/drv_debugfs_reader: Bourne-Again shell script, ASCII text executable
./tests/kms_sysfs_edid_timing: Bourne-Again shell script, ASCII text executable
./tools/intel_aubdump.in: Bourne-Again shell script, ASCII text executable
All are easily convertible. So let's do this.
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-10-12 11:29 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-06 13:36 [PATCH i-g-t 1/5] tests: Use bash for debugfs_wedged and drm_lib.sh ville.syrjala
2016-10-06 13:36 ` [PATCH i-g-t 2/5] tests: Leave basic breadcrumbs in dmesg for shell script based tests ville.syrjala
2016-10-07 7:24 ` Jani Nikula
2016-10-07 10:06 ` Ville Syrjälä
2016-10-06 13:36 ` [PATCH i-g-t 3/5] tests/vgem_reload_basic: Leave breadcrumbs in dmesg ville.syrjala
2016-10-06 13:36 ` [PATCH i-g-t 4/5] tests/tools_test: Fix it up for intel_reg ville.syrjala
2016-10-06 13:36 ` [PATCH i-g-t 5/5] tools/intel_reg: Return SUCCESS after a succesful dump ville.syrjala
2016-10-07 7:15 ` [PATCH i-g-t 1/5] tests: Use bash for debugfs_wedged and drm_lib.sh Joonas Lahtinen
2016-10-07 7:38 ` Jani Nikula
2016-10-07 9:54 ` Joonas Lahtinen
2016-10-12 10:12 ` David Weinehall
2016-10-12 11:05 ` Joonas Lahtinen
2016-10-12 11:16 ` Jani Nikula
2016-10-12 11:29 ` Joonas Lahtinen [this message]
2016-10-12 13:04 ` Jani Nikula
2016-10-12 13:17 ` David Weinehall
2016-10-13 14:05 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1476271757.2817.18.camel@linux.intel.com \
--to=joonas.lahtinen@linux.intel.com \
--cc=daniel.vetter@ffwll.ch \
--cc=david.weinehall@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox