From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 2/5] drm/i915: Update debugfs describe_obj() to show fault-mappable
Date: Wed, 12 Oct 2016 14:44:05 +0300 [thread overview]
Message-ID: <1476272645.2817.24.camel@linux.intel.com> (raw)
In-Reply-To: <20161012111637.14784-2-chris@chris-wilson.co.uk>
On ke, 2016-10-12 at 12:16 +0100, Chris Wilson wrote:
> The current meaning of whether an object has a GGTT vma is very
> ill-defined (and note we don't check for any partials either), it just
> means that at some point it was in the GGTT but it may not be now. The
> information we really care about here is whether it is taking up
> precious mappable aperture space. This is the obj->fault_mappable flag.
> We have a redundant long form reprinting of this information, so remove
> that in favour of the compact flag.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
I'm sure I already reviewed this as a part of another patch, but better
as a separate one!
Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-10-12 11:44 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-12 11:16 [PATCH 1/5] drm/i915: Use fence_write() from rpm resume Chris Wilson
2016-10-12 11:16 ` [PATCH 2/5] drm/i915: Update debugfs describe_obj() to show fault-mappable Chris Wilson
2016-10-12 11:44 ` Joonas Lahtinen [this message]
2016-10-12 11:16 ` [PATCH 3/5] drm/i915: Move user fault tracking to a separate list Chris Wilson
2016-10-12 11:16 ` [PATCH 4/5] drm/i915: Use RPM as the barrier for controlling user mmap access Chris Wilson
2016-10-12 11:16 ` [PATCH 5/5] drm/i915: Remove superfluous locking around userfault_list Chris Wilson
2016-10-12 11:42 ` [PATCH 1/5] drm/i915: Use fence_write() from rpm resume Joonas Lahtinen
2016-10-12 12:19 ` ✗ Fi.CI.BAT: warning for series starting with [1/5] " Patchwork
2016-10-13 15:10 ` [PATCH 1/5] " Daniel Vetter
2016-10-13 15:25 ` Chris Wilson
2016-10-13 15:28 ` Daniel Vetter
2016-10-13 15:41 ` Chris Wilson
2016-10-17 6:52 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1476272645.2817.24.camel@linux.intel.com \
--to=joonas.lahtinen@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox