* [PATCH] drm/i915: Fix cxsr_latency_table reorg
@ 2016-10-14 13:55 Tvrtko Ursulin
2016-10-14 16:20 ` ✗ Fi.CI.BAT: warning for " Patchwork
2016-10-17 7:30 ` [PATCH] " Joonas Lahtinen
0 siblings, 2 replies; 4+ messages in thread
From: Tvrtko Ursulin @ 2016-10-14 13:55 UTC (permalink / raw)
To: Intel-gfx
From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
I have re-ordered some struct members in patch:
commit 44a655cae3043453f9dd8076538712d52e2e0ce4
Author: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Date: Thu Oct 13 11:09:23 2016 +0100
drm/i915: Shrink cxsr_latency_table
but that particular one is not initialized with named
initializers which broke it.
Move the bitfields back at the beginning. Space saving
is still there.
Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Fixes: 44a655cae304 ("drm/i915: Shrink cxsr_latency_table")
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Jani Nikula <jani.nikula@linux.intel.com>
---
drivers/gpu/drm/i915/intel_drv.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_drv.h b/drivers/gpu/drm/i915/intel_drv.h
index a885b2ac9618..5bc115496355 100644
--- a/drivers/gpu/drm/i915/intel_drv.h
+++ b/drivers/gpu/drm/i915/intel_drv.h
@@ -807,14 +807,14 @@ struct intel_watermark_params {
};
struct cxsr_latency {
+ bool is_desktop : 1;
+ bool is_ddr3 : 1;
u16 fsb_freq;
u16 mem_freq;
u16 display_sr;
u16 display_hpll_disable;
u16 cursor_sr;
u16 cursor_hpll_disable;
- bool is_desktop : 1;
- bool is_ddr3 : 1;
};
#define to_intel_atomic_state(x) container_of(x, struct intel_atomic_state, base)
--
2.7.4
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 4+ messages in thread
* ✗ Fi.CI.BAT: warning for drm/i915: Fix cxsr_latency_table reorg
2016-10-14 13:55 [PATCH] drm/i915: Fix cxsr_latency_table reorg Tvrtko Ursulin
@ 2016-10-14 16:20 ` Patchwork
2016-10-14 17:12 ` Saarinen, Jani
2016-10-17 7:30 ` [PATCH] " Joonas Lahtinen
1 sibling, 1 reply; 4+ messages in thread
From: Patchwork @ 2016-10-14 16:20 UTC (permalink / raw)
To: Tvrtko Ursulin; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Fix cxsr_latency_table reorg
URL : https://patchwork.freedesktop.org/series/13789/
State : warning
== Summary ==
Series 13789v1 drm/i915: Fix cxsr_latency_table reorg
https://patchwork.freedesktop.org/api/1.0/series/13789/revisions/1/mbox/
Test kms_pipe_crc_basic:
Subgroup read-crc-pipe-b-frame-sequence:
dmesg-warn -> PASS (fi-skl-6770hq)
Subgroup suspend-read-crc-pipe-b:
pass -> DMESG-WARN (fi-byt-j1900)
Test vgem_basic:
Subgroup unload:
skip -> PASS (fi-skl-6700k)
pass -> SKIP (fi-hsw-4770)
skip -> PASS (fi-kbl-7200u)
fi-bdw-5557u total:246 pass:231 dwarn:0 dfail:0 fail:0 skip:15
fi-bsw-n3050 total:246 pass:204 dwarn:0 dfail:0 fail:0 skip:42
fi-bxt-t5700 total:246 pass:216 dwarn:0 dfail:0 fail:0 skip:30
fi-byt-j1900 total:246 pass:213 dwarn:1 dfail:0 fail:1 skip:31
fi-byt-n2820 total:246 pass:210 dwarn:0 dfail:0 fail:1 skip:35
fi-hsw-4770 total:246 pass:223 dwarn:0 dfail:0 fail:0 skip:23
fi-hsw-4770r total:246 pass:224 dwarn:0 dfail:0 fail:0 skip:22
fi-ilk-650 total:246 pass:184 dwarn:0 dfail:0 fail:2 skip:60
fi-ivb-3520m total:246 pass:221 dwarn:0 dfail:0 fail:0 skip:25
fi-ivb-3770 total:246 pass:221 dwarn:0 dfail:0 fail:0 skip:25
fi-kbl-7200u total:246 pass:222 dwarn:0 dfail:0 fail:0 skip:24
fi-skl-6260u total:246 pass:232 dwarn:0 dfail:0 fail:0 skip:14
fi-skl-6700hq total:246 pass:223 dwarn:0 dfail:0 fail:0 skip:23
fi-skl-6700k total:246 pass:221 dwarn:1 dfail:0 fail:0 skip:24
fi-skl-6770hq total:246 pass:230 dwarn:1 dfail:0 fail:1 skip:14
fi-snb-2520m total:246 pass:210 dwarn:0 dfail:0 fail:0 skip:36
fi-snb-2600 total:246 pass:209 dwarn:0 dfail:0 fail:0 skip:37
Results at /archive/results/CI_IGT_test/Patchwork_2723/
e086610ff079f1bf1fe91d4ab175443590cacb8d drm-intel-nightly: 2016y-10m-14d-11h-43m-09s UTC integration manifest
a854fc9 drm/i915: Fix cxsr_latency_table reorg
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: ✗ Fi.CI.BAT: warning for drm/i915: Fix cxsr_latency_table reorg
2016-10-14 16:20 ` ✗ Fi.CI.BAT: warning for " Patchwork
@ 2016-10-14 17:12 ` Saarinen, Jani
0 siblings, 0 replies; 4+ messages in thread
From: Saarinen, Jani @ 2016-10-14 17:12 UTC (permalink / raw)
To: intel-gfx@lists.freedesktop.org, Tvrtko Ursulin
> == Series Details ==
>
> Series: drm/i915: Fix cxsr_latency_table reorg
> URL : https://patchwork.freedesktop.org/series/13789/
> State : warning
>
> == Summary ==
>
> Series 13789v1 drm/i915: Fix cxsr_latency_table reorg
> https://patchwork.freedesktop.org/api/1.0/series/13789/revisions/1/mbox/
>
> Test kms_pipe_crc_basic:
> Subgroup read-crc-pipe-b-frame-sequence:
> dmesg-warn -> PASS (fi-skl-6770hq)
> Subgroup suspend-read-crc-pipe-b:
> pass -> DMESG-WARN (fi-byt-j1900)
https://bugs.freedesktop.org/show_bug.cgi?id=98040
> Test vgem_basic:
> Subgroup unload:
> skip -> PASS (fi-skl-6700k)
> pass -> SKIP (fi-hsw-4770)
> skip -> PASS (fi-kbl-7200u)
>
> fi-bdw-5557u total:246 pass:231 dwarn:0 dfail:0 fail:0 skip:15
> fi-bsw-n3050 total:246 pass:204 dwarn:0 dfail:0 fail:0 skip:42
> fi-bxt-t5700 total:246 pass:216 dwarn:0 dfail:0 fail:0 skip:30
> fi-byt-j1900 total:246 pass:213 dwarn:1 dfail:0 fail:1 skip:31
> fi-byt-n2820 total:246 pass:210 dwarn:0 dfail:0 fail:1 skip:35
> fi-hsw-4770 total:246 pass:223 dwarn:0 dfail:0 fail:0 skip:23
> fi-hsw-4770r total:246 pass:224 dwarn:0 dfail:0 fail:0 skip:22
> fi-ilk-650 total:246 pass:184 dwarn:0 dfail:0 fail:2 skip:60
> fi-ivb-3520m total:246 pass:221 dwarn:0 dfail:0 fail:0 skip:25
> fi-ivb-3770 total:246 pass:221 dwarn:0 dfail:0 fail:0 skip:25
> fi-kbl-7200u total:246 pass:222 dwarn:0 dfail:0 fail:0 skip:24
> fi-skl-6260u total:246 pass:232 dwarn:0 dfail:0 fail:0 skip:14
> fi-skl-6700hq total:246 pass:223 dwarn:0 dfail:0 fail:0 skip:23
> fi-skl-6700k total:246 pass:221 dwarn:1 dfail:0 fail:0 skip:24
> fi-skl-6770hq total:246 pass:230 dwarn:1 dfail:0 fail:1 skip:14
> fi-snb-2520m total:246 pass:210 dwarn:0 dfail:0 fail:0 skip:36
> fi-snb-2600 total:246 pass:209 dwarn:0 dfail:0 fail:0 skip:37
>
> Results at /archive/results/CI_IGT_test/Patchwork_2723/
>
> e086610ff079f1bf1fe91d4ab175443590cacb8d drm-intel-nightly: 2016y-10m-
> 14d-11h-43m-09s UTC integration manifest
> a854fc9 drm/i915: Fix cxsr_latency_table reorg
>
Jani Saarinen
Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/i915: Fix cxsr_latency_table reorg
2016-10-14 13:55 [PATCH] drm/i915: Fix cxsr_latency_table reorg Tvrtko Ursulin
2016-10-14 16:20 ` ✗ Fi.CI.BAT: warning for " Patchwork
@ 2016-10-17 7:30 ` Joonas Lahtinen
1 sibling, 0 replies; 4+ messages in thread
From: Joonas Lahtinen @ 2016-10-17 7:30 UTC (permalink / raw)
To: Tvrtko Ursulin, Intel-gfx
On pe, 2016-10-14 at 14:55 +0100, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>
> I have re-ordered some struct members in patch:
>
> commit 44a655cae3043453f9dd8076538712d52e2e0ce4
> > Author: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> Date: Thu Oct 13 11:09:23 2016 +0100
>
> drm/i915: Shrink cxsr_latency_table
>
> but that particular one is not initialized with named
> initializers which broke it.
>
Wrong commit message above this line?
Patch itself is;
Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-10-17 7:30 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-10-14 13:55 [PATCH] drm/i915: Fix cxsr_latency_table reorg Tvrtko Ursulin
2016-10-14 16:20 ` ✗ Fi.CI.BAT: warning for " Patchwork
2016-10-14 17:12 ` Saarinen, Jani
2016-10-17 7:30 ` [PATCH] " Joonas Lahtinen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox