public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Imre Deak <imre.deak@intel.com>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] intel-ci: Add gem_exec_suspend/basic-S3/S4-devices to BAT
Date: Mon, 17 Oct 2016 17:46:50 +0300	[thread overview]
Message-ID: <1476715610.32479.26.camel@intel.com> (raw)
In-Reply-To: <20161017143203.GO20761@phenom.ffwll.local>

On ma, 2016-10-17 at 16:32 +0200, Daniel Vetter wrote:
> On Mon, Oct 17, 2016 at 03:39:04PM +0300, Imre Deak wrote:
> > Add gem_exec_suspend/basic-s3-devices and basic-s4-devices subtests
> > to
> > BAT. At the same time remove basic-s4 from the list, which is atm
> > implicitly disabled via HIBERNATION=n in kconfig. We would need at
> > least
> > basic S4 coverage provided by basic-s4-devices, which requires
> > HIBERNATION=y.
> > 
> > Signed-off-by: Imre Deak <imre.deak@intel.com>
> 
> What's the impact on BAT runtime with this? 

I measured 8 sec for S3-devices and 9 sec for S4-devices on my APL.

> Afaik we're already over budget ... Where do you safe the time to
> afford this?

I didn't, but we don't have any S4 coverage in CI atm and it's the
minimum that can be added. The S3-devices subtest is not critical,
although it would be useful for cases where we wouldn't get any logs
for the full S3 test.

--Imre

> -Daniel
> 
> > ---
> >  tests/intel-ci/fast-feedback.testlist | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/tests/intel-ci/fast-feedback.testlist b/tests/intel-
> > ci/fast-feedback.testlist
> > index f59ec98..efa7e86 100644
> > --- a/tests/intel-ci/fast-feedback.testlist
> > +++ b/tests/intel-ci/fast-feedback.testlist
> > @@ -73,8 +73,9 @@ igt@gem_exec_store@basic-default
> >  igt@gem_exec_store@basic-render
> >  igt@gem_exec_store@basic-vebox
> >  igt@gem_exec_suspend@basic
> > +igt@gem_exec_suspend@basic-s3-devices
> >  igt@gem_exec_suspend@basic-s3
> > -igt@gem_exec_suspend@basic-s4
> > +igt@gem_exec_suspend@basic-s4-devices
> >  igt@gem_flink_basic@bad-flink
> >  igt@gem_flink_basic@bad-open
> >  igt@gem_flink_basic@basic
> > -- 
> > 2.5.0
> > 
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
> 
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2016-10-17 14:47 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-17 12:39 [PATCH] intel-ci: Add gem_exec_suspend/basic-S3/S4-devices to BAT Imre Deak
2016-10-17 14:32 ` Daniel Vetter
2016-10-17 14:46   ` Imre Deak [this message]
2016-10-17 14:56     ` Jani Nikula
2016-10-17 15:01     ` Saarinen, Jani
2016-10-17 15:02       ` Imre Deak
2016-10-18  7:34     ` Daniel Vetter
2016-10-18  9:03       ` Petri Latvala
2016-10-18  9:23         ` Ville Syrjälä
2016-11-25  9:50 ` Petri Latvala

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1476715610.32479.26.camel@intel.com \
    --to=imre.deak@intel.com \
    --cc=daniel@ffwll.ch \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox