From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: Zhenyu Wang <zhenyuw@linux.intel.com>, daniel@ffwll.ch
Cc: intel-gfx@lists.freedesktop.org, zhiyuan.lv@intel.com
Subject: Re: [PATCH] drm/i915/gvt: Fix build failure after intel_engine_cs change
Date: Tue, 18 Oct 2016 09:47:56 +0300 [thread overview]
Message-ID: <1476773276.3117.2.camel@linux.intel.com> (raw)
In-Reply-To: <20161018014007.29369-1-zhenyuw@linux.intel.com>
On ti, 2016-10-18 at 09:40 +0800, Zhenyu Wang wrote:
> @@ -134,7 +134,7 @@ static int render_mmio_to_ring_id(struct intel_gvt *gvt, unsigned int reg)
>
> reg &= ~GENMASK(11, 0);
> for (i = 0; i < I915_NUM_ENGINES; i++) {
> - if (gvt->dev_priv->engine[i].mmio_base == reg)
> + if (gvt->dev_priv->engine[i]->mmio_base == reg)
> return i;
> }
This loop is bad now that engine[i] might be NULL. Use for_each_engine
instead.
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-10-18 6:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-18 1:40 [PATCH] drm/i915/gvt: Fix build failure after intel_engine_cs change Zhenyu Wang
2016-10-18 3:24 ` ✗ Fi.CI.BAT: failure for " Patchwork
2016-10-18 5:39 ` Saarinen, Jani
2016-10-18 5:52 ` Zhenyu Wang
2016-10-18 8:32 ` Chris Wilson
2016-10-18 6:47 ` Joonas Lahtinen [this message]
2016-10-18 6:46 ` [PATCH] " Zhenyu Wang
2016-10-18 8:39 ` Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1476773276.3117.2.camel@linux.intel.com \
--to=joonas.lahtinen@linux.intel.com \
--cc=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=zhenyuw@linux.intel.com \
--cc=zhiyuan.lv@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox