From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH i-g-t 0/3] Convert sh scripts to C variants.
Date: Fri, 21 Oct 2016 10:38:17 +0300 [thread overview]
Message-ID: <1477035497.3098.7.camel@linux.intel.com> (raw)
In-Reply-To: <87lgxipwg8.fsf@intel.com>
On pe, 2016-10-21 at 00:00 +0300, Jani Nikula wrote:
> > On Thu, 20 Oct 2016, Marius Vlad <marius.c.vlad@intel.com> wrote:
> >
> > This series adds some library support to help converting sh
> > scripts to C version. Converted drv_module_reload_basic and
> > kms_sysfs_edid_timing.
>
> >
> > 18 files changed, 600 insertions(+), 180 deletions(-)
>
> Someone please justify this, plus pulling in two new dependencies. I can
> think of a thing or two, but it needs to be in the commit messages. And
> I'm not convinced by the justification I came up with.
Hmm, not sure how Daniel instructed things. Original idea was to just
execv the same commands as the scripts do. To get rid of the
interpreter differences and allow running in a minimal environment.
I'm myself fine with using the libraries too, I think the tests can
then be improved upon, just like Chris has commented on a few of them.
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-10-21 7:38 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-20 19:36 [PATCH i-g-t 0/3] Convert sh scripts to C variants Marius Vlad
2016-10-20 19:36 ` [PATCH i-g-t 1/3] lib/{igt_sysfs, igt_aux}: Make available to other users kick_fbcon() (unbind_fbcon()), and added helpers to igt_aux Marius Vlad
2016-10-20 20:09 ` Chris Wilson
2016-10-24 18:08 ` Marius Vlad
2016-10-24 8:40 ` Daniel Vetter
2016-10-26 21:02 ` Marius Vlad
2016-10-27 6:40 ` Daniel Vetter
2016-10-20 19:36 ` [PATCH i-g-t 2/3] tests/drv_module_reload_basic: Convert sh script to C version Marius Vlad
2016-10-20 19:52 ` Chris Wilson
2016-10-24 18:05 ` Marius Vlad
2016-10-24 20:34 ` Chris Wilson
2016-10-21 9:39 ` Petri Latvala
2016-10-24 18:06 ` Marius Vlad
2016-10-20 19:36 ` [PATCH i-g-t 3/3] tests/kms_sysfs_edid_timing: " Marius Vlad
2016-10-20 19:58 ` Chris Wilson
2016-10-20 21:00 ` [PATCH i-g-t 0/3] Convert sh scripts to C variants Jani Nikula
2016-10-21 7:38 ` Joonas Lahtinen [this message]
2016-10-24 8:46 ` Daniel Vetter
2016-10-24 8:49 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1477035497.3098.7.camel@linux.intel.com \
--to=joonas.lahtinen@linux.intel.com \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox