From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lyude Paul Subject: Re: [PATCH 1/2] drm/i915: Remove redundant reprobe in i915_drm_resume Date: Thu, 03 Nov 2016 12:42:45 -0400 Message-ID: <1478191365.4192.10.camel@redhat.com> References: <1478187758-32740-1-git-send-email-lyude@redhat.com> <1478187758-32740-2-git-send-email-lyude@redhat.com> <20161103160253.GA24715@nuc-i3427.alporthouse.com> <1478189469.28703.8.camel@redhat.com> <1478189515.28703.9.camel@redhat.com> <20161103162543.GB24715@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20161103162543.GB24715@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson Cc: Daniel Vetter , intel-gfx@lists.freedesktop.org, Lyude , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCAyMDE2LTExLTAzIGF0IDE2OjI1ICswMDAwLCBDaHJpcyBXaWxzb24gd3JvdGU6Cj4g T24gVGh1LCBOb3YgMDMsIDIwMTYgYXQgMTI6MTE6NTVQTSAtMDQwMCwgTHl1ZGUgUGF1bCB3cm90 ZToKPiA+IAo+ID4gT24gVGh1LCAyMDE2LTExLTAzIGF0IDEyOjExIC0wNDAwLCBMeXVkZSBQYXVs IHdyb3RlOgo+ID4gPiAKPiA+ID4gT24gVGh1LCAyMDE2LTExLTAzIGF0IDE2OjAyICswMDAwLCBD aHJpcyBXaWxzb24gd3JvdGU6Cj4gPiA+ID4gCj4gPiA+ID4gCj4gPiA+ID4gT24gVGh1LCBOb3Yg MDMsIDIwMTYgYXQgMTE6NDI6MzdBTSAtMDQwMCwgTHl1ZGUgd3JvdGU6Cj4gPiA+ID4gPiAKPiA+ ID4gPiA+IAo+ID4gPiA+ID4gCj4gPiA+ID4gPiBXZWluZSdzIGludmVzdGlnYXRpb24gb24gYmVu Y2htYXJraW5nIHRoZSBzdXNwZW5kL3Jlc3VtZSBwcm9jZXNzCj4gPiA+ID4gPiBwb2ludGVkCj4g PiA+ID4gPiBvdXQgYSBsb3Qgb2YgdGhlIHRpbWUgaW4gc3VzcGVuZC9yZXN1bWUgaXMgYmVpbmcg c3BlbnQgcmVwcm9iaW5nLgo+ID4gPiA+ID4gV2hpbGUKPiA+ID4gPiA+IHRoZSByZXByb2Jpbmcg cHJvY2VzcyBpcyBhIGxlbmd0aHkgb25lIGZvciBnb29kIHJlYXNvbiwgd2UgZG9uJ3QgbmVlZAo+ ID4gPiA+ID4gdG8KPiA+ID4gPiA+IGhvbGQgdXAgdGhlIGVudGlyZSBzdXNwZW5kL3Jlc3VtZSBw cm9jZXNzIHdoaWxlIHdlIHdhaXQgZm9yIGl0IHRvCj4gPiA+ID4gPiBmaW5pc2guIEx1Y2tpbHkg YXMgaXQgdHVybnMgb3V0LCB3ZSBhbHJlYWR5IHRyaWdnZXIgYSBmdWxsIGNvbm5lY3Rvcgo+ID4g PiA+ID4gcmVwcm9iZSBpbiBpOTE1X2hwZF9wb2xsX2luaXRfd29yaygpLCBzbyB3ZSBjYW4ganVz dCBkaXRjaCByZXByb2JpbmcKPiA+ID4gPiA+IGluCj4gPiA+ID4gPiBpOTE1X2RybV9yZXN1bWUo KSBlbnRpcmVseS4KPiA+ID4gPiA+IAo+ID4gPiA+ID4gVGhpcyB3b24ndCBsZWFkIHRvIGxlc3Mg dGltZSBzcGVudCByZXN1bWluZyBqdXN0IHlldCBzaW5jZSBub3cgdGhlCj4gPiA+ID4gPiBib3R0 bGVuZWNrIHdpbGwgYmUgd2FpdGluZyBmb3IgdGhlIG1vZGVfY29uZmlnIGxvY2sgaW4KPiA+ID4g PiA+IGRybV9rbXNfaGVscGVyX3BvbGxfZW5hYmxlKCksIHNpbmNlIHRoYXQgd2lsbCBiZSBoZWxk IGFzIGxvbmcgYXMKPiA+ID4gPiA+IGk5MTVfaHBkX3BvbGxfaW5pdF93b3JrKCkgaXMgcmVwcm9i aW5nIGFsbCBvZiB0aGUgY29ubmVjdG9ycy4gQnV0Cj4gPiA+ID4gPiB3ZSdsbAo+ID4gPiA+ID4g YWRkcmVzcyB0aGF0IGluIHRoZSBuZXh0IHBhdGNoLgo+ID4gPiA+ID4gCj4gPiA+ID4gPiBTaWdu ZWQtb2ZmLWJ5OiBMeXVkZSA8bHl1ZGVAcmVkaGF0LmNvbT4KPiA+ID4gPiA+IENjOiBEYXZpZCBX ZWluZWhhbGwgPGRhdmlkLndlaW5laGFsbEBsaW51eC5pbnRlbC5jb20+Cj4gPiA+ID4gPiAtLS0K PiA+ID4gPiA+IMKgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuYyB8IDIgLS0KPiA+ID4g PiA+IMKgMSBmaWxlIGNoYW5nZWQsIDIgZGVsZXRpb25zKC0pCj4gPiA+ID4gPiAKPiA+ID4gPiA+ IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5jCj4gPiA+ID4gPiBi L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmMKPiA+ID4gPiA+IGluZGV4IGJmYjJlZmQu LjUzMmNjMGYgMTAwNjQ0Cj4gPiA+ID4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1 X2Rydi5jCj4gPiA+ID4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5jCj4g PiA+ID4gPiBAQCAtMTYwMiw4ICsxNjAyLDYgQEAgc3RhdGljIGludCBpOTE1X2RybV9yZXN1bWUo c3RydWN0IGRybV9kZXZpY2UKPiA+ID4gPiA+ICpkZXYpCj4gPiA+ID4gPiDCoAnCoCogbm90aWZp Y2F0aW9ucy4KPiA+ID4gPiA+IMKgCcKgKiAqLwo+ID4gPiA+ID4gwqAJaW50ZWxfaHBkX2luaXQo ZGV2X3ByaXYpOwo+ID4gPiA+ID4gLQkvKiBDb25maWcgbWF5IGhhdmUgY2hhbmdlZCBiZXR3ZWVu IHN1c3BlbmQgYW5kIHJlc3VtZSAqLwo+ID4gPiA+ID4gLQlkcm1faGVscGVyX2hwZF9pcnFfZXZl bnQoZGV2KTsKPiA+ID4gPiAKPiA+ID4gPiBUaGUgY29tbWVudCBpcyBzdGlsbCBhcHQuIFRoaXMg Y29kZSBpcyBrbm93biB0byBiZSBicm9rZW4gc2luY2UgaXQKPiA+ID4gPiBkb2Vzbid0IGRldGVj dCBhIGNoYW5nZSBpbiBtb25pdG9ycyAoZS5nLiBhIGNoYW5nZSBpbiBleHRlcm5hbAo+ID4gPiA+ IGNvbm5lY3RvcnMKPiA+ID4gPiBmcm9tIGRvY2tpbmcpIGJldHdlZW4gc3VzcGVuZCBhbmQgcmVz ZW5kLiBXZSBzdGlsbCBoYXZlIHRvIHNlbmQgdGhlCj4gPiA+ID4gdWV2ZW50Lgo+ID4gPiA+IAo+ ID4gPiA+ICsJZHJtX2ttc19oZWxwZXJfaG90cGx1Z19ldmVudChkZXYpOwo+ID4gPiAKPiA+ID4g SSBtaWdodCBub3QgaGF2ZSBleHBsYWluZWQgbXlzZWxmIHZlcnkgd2VsbC4gVGhlIHdheSB0aGlu Z3Mgc2hvdWxkIGxvb2sKPiA+ID4gd2l0aAo+ID4gPiB0aGlzIHBhdGNoIGlzIGxpa2UgdGhpczoK PiA+ID4gCj4gPiA+IGk5MTVfZHJtX3Jlc3VtZSgpCj4gPiA+IMKgLT4gaW50ZWxfaHBkX2luaXQo KQo+ID4gPiDCoCDCoC0+IHNldHMgZGV2X3ByaXYtPmhvdHBsdWcucG9sbF9lbmFibGVkIHRvIHRy dWUKPiA+IFdob29wcywgcy90cnVlL2ZhbHNlLwo+ID4gCj4gPiA+IAo+ID4gPiDCoCDCoC0+IHNj aGVkdWxlcyBkZXZfcHJpdi0+aG90cGx1Zy5wb2xsX2luaXRfd29yawo+ID4gPiDCoC0+IGNvbnRp bnVlIHJlc3VtZeKApgo+ID4gPiAKPiA+ID4gYXQgdGhlIHNhbWUgdGltZToKPiA+ID4gCj4gPiA+ IGk5MTVfaHBkX3BvbGxfaW5pdF93b3JrKCkgZ2V0cyBzY2hlZHVsZWQgYW5kIHN0YXJ0cwo+ID4g PiDCoC0+IHNpbmNlIGRldl9wcml2LT5ob3RwbHVnLnBvbGxfZW5hYmxlZCA9PSBmYWxzZSwKPiA+ ID4gZHJtX2hlbHBlcl9ocGRfaXJxX2V2ZW50KCkKPiA+ID4gaXMgY2FsbGVkCj4gPiA+IMKgIC0+ IGRybV9oZWxwZXJfaHBkX2lycV9ldmVudCgpIHJlcHJvYmVzIGNvbm5lY3RvcnMKPiA+ID4gwqDC oMKgLT4gaWYgYW55dGhpbmcgY2hhbmdlZCwgZHJtX2ttc19oZWxwZXJfaG90cGx1Z19ldmVudCgp IGdldHMgY2FsbGVkLgo+IAo+IGRybV9oZWxwZXJfaHBkX2lycV9ldmVudCgpIGRvZXMgbm90IGRl dGVjdCBhIGNoYW5nZSBpbiBtb25pdG9ycywgZm9yCj4gZXhhbXBsZSwgc28gdGhlcmUgaXMgbm8g dWV2ZW50IGluIHRoYXQgY2FzZS4KCkkgc3RpbGwgdGhpbmsgeW91J3JlIG1pc3Rha2VuIChhbmQg SSB3b3VsZG4ndCBibGFtZSB5b3UsCmRybV9oZWxwZXJfaHBkX2lycV9ldmVudCgpIGhhcyBhIHJh dGhlciBtaXNsZWFkaW5nIG5hbWUpLiBDb250ZW50cwpvZsKgZHJtX2hlbHBlcl9ocGRfaXJxX2V2 ZW50KCkKCmJvb2wgZHJtX2hlbHBlcl9ocGRfaXJxX2V2ZW50KHN0cnVjdCBkcm1fZGV2aWNlICpk ZXYpCnsKCXN0cnVjdCBkcm1fY29ubmVjdG9yICpjb25uZWN0b3I7CgllbnVtIGRybV9jb25uZWN0 b3Jfc3RhdHVzIG9sZF9zdGF0dXM7Cglib29sIGNoYW5nZWQgPSBmYWxzZTsKCglpZiAoIWRldi0+ bW9kZV9jb25maWcucG9sbF9lbmFibGVkKQoJCXJldHVybiBmYWxzZTsKCgltdXRleF9sb2NrKCZk ZXYtPm1vZGVfY29uZmlnLm11dGV4KTsKCWRybV9mb3JfZWFjaF9jb25uZWN0b3IoY29ubmVjdG9y LCBkZXYpIHsKCgkJLyogT25seSBoYW5kbGUgSFBEIGNhcGFibGUgY29ubmVjdG9ycy4gKi8KCQlp ZiAoIShjb25uZWN0b3ItPnBvbGxlZCAmIERSTV9DT05ORUNUT1JfUE9MTF9IUEQpKQoJCQljb250 aW51ZTsKCgkJb2xkX3N0YXR1cyA9IGNvbm5lY3Rvci0+c3RhdHVzOwoKCQljb25uZWN0b3ItPnN0 YXR1cyA9IGNvbm5lY3Rvci0+ZnVuY3MtPmRldGVjdChjb25uZWN0b3IsIGZhbHNlKTsKCQlEUk1f REVCVUdfS01TKCJbQ09OTkVDVE9SOiVkOiVzXSBzdGF0dXMgdXBkYXRlZCBmcm9tICVzIHRvCiVz XG4iLAoJCQnCoMKgwqDCoMKgwqBjb25uZWN0b3ItPmJhc2UuaWQsCgkJCcKgwqDCoMKgwqDCoGNv bm5lY3Rvci0+bmFtZSwKCQkJwqDCoMKgwqDCoMKgZHJtX2dldF9jb25uZWN0b3Jfc3RhdHVzX25h bWUob2xkX3N0YXR1cyksCgkJCcKgwqDCoMKgwqDCoGRybV9nZXRfY29ubmVjdG9yX3N0YXR1c19u YW1lKGNvbm5lY3Rvci0+c3RhdHVzKSk7CgkJaWYgKG9sZF9zdGF0dXMgIT0gY29ubmVjdG9yLT5z dGF0dXMpCgkJCWNoYW5nZWQgPSB0cnVlOwoJfQoKCW11dGV4X3VubG9jaygmZGV2LT5tb2RlX2Nv bmZpZy5tdXRleCk7CgoJaWYgKGNoYW5nZWQpCgkJZHJtX2ttc19oZWxwZXJfaG90cGx1Z19ldmVu dChkZXYpOwoKCXJldHVybiBjaGFuZ2VkOwp9CgpVbmxlc3MgSSBtYWRlIGEgbWlzdGFrZSBzb21l d2hlcmUgZG93biB0aGUgbGluZSBvZiB3cml0aW5nIHRoZXNlOiBwb2xsX2VuYWJsZWQKd2lsbCBi ZSBzZXQgdG8gdHJ1ZSAoZHVlIHRvIHRoZSBjaGFuZ2UgZG9uZSBpbiB0aGUgc2Vjb25kIHBhdGNo IHdoZXJlIHdlIG1vdmUKdGhlIGNhbGwgZm9yIGVuYWJsaW5nIHBvbGxpbmcgdXAgc28gdGhhdCBp dCBnZXRzIGNhbGxlZCBiZWZvcmUKaW50ZWxfaHBkX2luaXQoKSksIHdoaWNoIGNhdXNlcyBpdCB0 byBnbyB0aHJvdWdoIGFsbCB0aGUgY29ubmVjdG9ycyBhbmQgY2FsbApjb25uZWN0b3ItPmZ1bmNz LT5kZXRlY3QoKSAod2hpY2ggd2lsbCBiZSBpbnRlbF9kcF9kZXRlY3QoKSwKaW50ZWxfaGRtaV9k ZXRlY3QoKSwgZXRjLiBBbmQgdGhlbiBzZW5kIGEgdWV2ZW50IGlmIHRoZWlyIHN0YXR1cyBjaGFu Z2VkLgoKVGhpcyBiZWluZyBzYWlkIHRoZXJlJ3MgYSBjb3VwbGUgb2YgY2FzZXMgSSBrbm93IHdl IGRvbid0IGhhbmRsZSBjb3JyZWN0bHkgZnJvbQp3cml0aW5nIHVwIGlndCB0ZXN0cyB3aXRoIHRo ZSBjaGFtZWxpdW06IHdlIGRvbid0IHNpbXVsYXRlIGEgZGlzY29ubmVjdCArCmNvbm5lY3Qgd2hl biB0aGUgRURJRCBjaGFuZ2VkIGZyb20gd2hhdCB3ZSBoYWQgbGFzdCwgc28gaWYgd2Ugc3VzcGVu ZCB0aGUgc3lzdGVtCndpdGggbW9uaXRvciBBIGNvbm5lY3RlZCB0byBwb3J0IGZvbyBhbmQgcmVz dW1lIGl0IHdpdGggbW9uaXRvciBCIGNvbm5lY3RlZCB0bwpwb3J0IGZvbywgaXQgd2lsbCBzdGls bCB0aGluayB3ZSdyZSBjb25uZWN0ZWQgdG8gbW9uaXRvciBBLiBIb3dldmVyLCB3ZSBkb24ndApo YW5kbGUgdGhpcyBwcm9wZXJseSB3aXRoIHRoZSBjdXJyZW50IGNvZGUgZWl0aGVyLgoKQXMgZm9y IGNvbm5lY3Rvci0+ZnVuY3MtPmRldGVjdCgpLCBpdCBkb2VzIGRvIGEgcmVhbCBjb25uZWN0b3Ig cmVwcm9iZSBhcwpvcHBvc2VkIHRvIGp1c3QgY2hlY2tpbmcgdGhlIHN0YXR1cyBvZiB0aGUgSFBE IHBpbnMsIEknZCBsb29rIGF0IHRoZSBkZXRlY3QoKQpmdW5jdGlvbnMgaWYgeW91J3JlIHN0aWxs IHNrZXB0aWNhbC4KCj4gLUNocmlzCj4gCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZy ZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2ludGVsLWdmeAo=