intel-gfx.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/2] drm: Add missing mutex_destroy in drm_dev_init
@ 2016-11-10 13:36 Joonas Lahtinen
  2016-11-10 13:36 ` [PATCH 2/2] drm/i915: Update i915_driver_load kerneldoc Joonas Lahtinen
                   ` (2 more replies)
  0 siblings, 3 replies; 7+ messages in thread
From: Joonas Lahtinen @ 2016-11-10 13:36 UTC (permalink / raw)
  To: Intel graphics driver community testing & development
  Cc: Joonas Lahtinen, Direct Rendering Infrastructure - Development

Add 3 missing mutex_destroy to drm_dev_init teardown.

Signed-off-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
---
 drivers/gpu/drm/drm_drv.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/gpu/drm/drm_drv.c b/drivers/gpu/drm/drm_drv.c
index 6efdba4..ba144b3 100644
--- a/drivers/gpu/drm/drm_drv.c
+++ b/drivers/gpu/drm/drm_drv.c
@@ -568,6 +568,9 @@ int drm_dev_init(struct drm_device *dev,
 	drm_fs_inode_free(dev->anon_inode);
 err_free:
 	mutex_destroy(&dev->master_mutex);
+	mutex_destroy(&dev->ctxlist_mutex);
+	mutex_destroy(&dev->filelist_mutex);
+	mutex_destroy(&dev->struct_mutex);
 	return ret;
 }
 EXPORT_SYMBOL(drm_dev_init);
-- 
2.7.4

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [PATCH 2/2] drm/i915: Update i915_driver_load kerneldoc
  2016-11-10 13:36 [PATCH 1/2] drm: Add missing mutex_destroy in drm_dev_init Joonas Lahtinen
@ 2016-11-10 13:36 ` Joonas Lahtinen
  2016-11-11 17:51   ` Chris Wilson
  2016-11-10 13:50 ` [PATCH v2] drm: Add missing mutex_destroy in drm_dev_init/release Joonas Lahtinen
  2016-11-10 14:16 ` ✓ Fi.CI.BAT: success for series starting with [v2] drm: Add missing mutex_destroy in drm_dev_init/release (rev2) Patchwork
  2 siblings, 1 reply; 7+ messages in thread
From: Joonas Lahtinen @ 2016-11-10 13:36 UTC (permalink / raw)
  To: Intel graphics driver community testing & development
  Cc: Joonas Lahtinen, Direct Rendering Infrastructure - Development

Update i915_driver_load kerneldoc to match code.

Cc: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
---
 drivers/gpu/drm/i915/i915_drv.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
index 9e5a547..d023c1a 100644
--- a/drivers/gpu/drm/i915/i915_drv.c
+++ b/drivers/gpu/drm/i915/i915_drv.c
@@ -1168,8 +1168,8 @@ static void i915_driver_unregister(struct drm_i915_private *dev_priv)
 
 /**
  * i915_driver_load - setup chip and create an initial config
- * @dev: DRM device
- * @flags: startup flags
+ * @pdev: PCI device
+ * @ent: matching PCI ID entry
  *
  * The driver load routine has to do several things:
  *   - drive output discovery via intel_modeset_init()
-- 
2.7.4

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [PATCH v2] drm: Add missing mutex_destroy in drm_dev_init/release
  2016-11-10 13:36 [PATCH 1/2] drm: Add missing mutex_destroy in drm_dev_init Joonas Lahtinen
  2016-11-10 13:36 ` [PATCH 2/2] drm/i915: Update i915_driver_load kerneldoc Joonas Lahtinen
@ 2016-11-10 13:50 ` Joonas Lahtinen
  2016-11-10 14:45   ` Chris Wilson
  2016-11-10 14:16 ` ✓ Fi.CI.BAT: success for series starting with [v2] drm: Add missing mutex_destroy in drm_dev_init/release (rev2) Patchwork
  2 siblings, 1 reply; 7+ messages in thread
From: Joonas Lahtinen @ 2016-11-10 13:50 UTC (permalink / raw)
  To: Intel graphics driver community testing & development
  Cc: Joonas Lahtinen, Direct Rendering Infrastructure - Development

Add 3 missing mutex_destroy to drm_dev_init teardown and
drm_dev_release.

v2:
- Also include drm_dev_release

Signed-off-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
---
 drivers/gpu/drm/drm_drv.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/gpu/drm/drm_drv.c b/drivers/gpu/drm/drm_drv.c
index 6efdba4..d1cb739 100644
--- a/drivers/gpu/drm/drm_drv.c
+++ b/drivers/gpu/drm/drm_drv.c
@@ -568,6 +568,9 @@ int drm_dev_init(struct drm_device *dev,
 	drm_fs_inode_free(dev->anon_inode);
 err_free:
 	mutex_destroy(&dev->master_mutex);
+	mutex_destroy(&dev->ctxlist_mutex);
+	mutex_destroy(&dev->filelist_mutex);
+	mutex_destroy(&dev->struct_mutex);
 	return ret;
 }
 EXPORT_SYMBOL(drm_dev_init);
@@ -630,6 +633,9 @@ static void drm_dev_release(struct kref *ref)
 	drm_minor_free(dev, DRM_MINOR_CONTROL);
 
 	mutex_destroy(&dev->master_mutex);
+	mutex_destroy(&dev->ctxlist_mutex);
+	mutex_destroy(&dev->filelist_mutex);
+	mutex_destroy(&dev->struct_mutex);
 	kfree(dev->unique);
 	kfree(dev);
 }
-- 
2.7.4

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* ✓ Fi.CI.BAT: success for series starting with [v2] drm: Add missing mutex_destroy in drm_dev_init/release (rev2)
  2016-11-10 13:36 [PATCH 1/2] drm: Add missing mutex_destroy in drm_dev_init Joonas Lahtinen
  2016-11-10 13:36 ` [PATCH 2/2] drm/i915: Update i915_driver_load kerneldoc Joonas Lahtinen
  2016-11-10 13:50 ` [PATCH v2] drm: Add missing mutex_destroy in drm_dev_init/release Joonas Lahtinen
@ 2016-11-10 14:16 ` Patchwork
  2016-11-14 12:31   ` Joonas Lahtinen
  2 siblings, 1 reply; 7+ messages in thread
From: Patchwork @ 2016-11-10 14:16 UTC (permalink / raw)
  To: Joonas Lahtinen; +Cc: intel-gfx

== Series Details ==

Series: series starting with [v2] drm: Add missing mutex_destroy in drm_dev_init/release (rev2)
URL   : https://patchwork.freedesktop.org/series/15110/
State : success

== Summary ==

Series 15110v2 Series without cover letter
https://patchwork.freedesktop.org/api/1.0/series/15110/revisions/2/mbox/


fi-bdw-5557u     total:244  pass:229  dwarn:0   dfail:0   fail:0   skip:15 
fi-bsw-n3050     total:244  pass:204  dwarn:0   dfail:0   fail:0   skip:40 
fi-bxt-t5700     total:244  pass:216  dwarn:0   dfail:0   fail:0   skip:28 
fi-byt-j1900     total:244  pass:216  dwarn:0   dfail:0   fail:0   skip:28 
fi-byt-n2820     total:244  pass:212  dwarn:0   dfail:0   fail:0   skip:32 
fi-hsw-4770      total:244  pass:224  dwarn:0   dfail:0   fail:0   skip:20 
fi-hsw-4770r     total:244  pass:224  dwarn:0   dfail:0   fail:0   skip:20 
fi-ilk-650       total:244  pass:191  dwarn:0   dfail:0   fail:0   skip:53 
fi-ivb-3520m     total:244  pass:222  dwarn:0   dfail:0   fail:0   skip:22 
fi-ivb-3770      total:244  pass:222  dwarn:0   dfail:0   fail:0   skip:22 
fi-kbl-7200u     total:244  pass:222  dwarn:0   dfail:0   fail:0   skip:22 
fi-skl-6260u     total:244  pass:230  dwarn:0   dfail:0   fail:0   skip:14 
fi-skl-6700hq    total:244  pass:223  dwarn:0   dfail:0   fail:0   skip:21 
fi-skl-6700k     total:244  pass:222  dwarn:1   dfail:0   fail:0   skip:21 
fi-skl-6770hq    total:244  pass:230  dwarn:0   dfail:0   fail:0   skip:14 
fi-snb-2520m     total:244  pass:212  dwarn:0   dfail:0   fail:0   skip:32 
fi-snb-2600      total:244  pass:211  dwarn:0   dfail:0   fail:0   skip:33 

eb88955cdc6a1f4dabff6bc27747c1c9e9a3aaef drm-intel-nightly: 2016y-11m-10d-09h-29m-41s UTC integration manifest
e4c309e drm/i915: Update i915_driver_load kerneldoc
b6023a9 drm: Add missing mutex_destroy in drm_dev_init/release

== Logs ==

For more details see: https://intel-gfx-ci.01.org/CI/Patchwork_2955/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH v2] drm: Add missing mutex_destroy in drm_dev_init/release
  2016-11-10 13:50 ` [PATCH v2] drm: Add missing mutex_destroy in drm_dev_init/release Joonas Lahtinen
@ 2016-11-10 14:45   ` Chris Wilson
  0 siblings, 0 replies; 7+ messages in thread
From: Chris Wilson @ 2016-11-10 14:45 UTC (permalink / raw)
  To: Joonas Lahtinen
  Cc: Intel graphics driver community testing & development,
	Direct Rendering Infrastructure - Development

On Thu, Nov 10, 2016 at 03:50:35PM +0200, Joonas Lahtinen wrote:
> Add 3 missing mutex_destroy to drm_dev_init teardown and
> drm_dev_release.
> 
> v2:
> - Also include drm_dev_release
> 
> Signed-off-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH 2/2] drm/i915: Update i915_driver_load kerneldoc
  2016-11-10 13:36 ` [PATCH 2/2] drm/i915: Update i915_driver_load kerneldoc Joonas Lahtinen
@ 2016-11-11 17:51   ` Chris Wilson
  0 siblings, 0 replies; 7+ messages in thread
From: Chris Wilson @ 2016-11-11 17:51 UTC (permalink / raw)
  To: Joonas Lahtinen
  Cc: Intel graphics driver community testing & development,
	Direct Rendering Infrastructure - Development

On Thu, Nov 10, 2016 at 03:36:34PM +0200, Joonas Lahtinen wrote:
> Update i915_driver_load kerneldoc to match code.
> 
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Signed-off-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: ✓ Fi.CI.BAT: success for series starting with [v2] drm: Add missing mutex_destroy in drm_dev_init/release (rev2)
  2016-11-10 14:16 ` ✓ Fi.CI.BAT: success for series starting with [v2] drm: Add missing mutex_destroy in drm_dev_init/release (rev2) Patchwork
@ 2016-11-14 12:31   ` Joonas Lahtinen
  0 siblings, 0 replies; 7+ messages in thread
From: Joonas Lahtinen @ 2016-11-14 12:31 UTC (permalink / raw)
  To: intel-gfx

On to, 2016-11-10 at 14:16 +0000, Patchwork wrote:
> == Series Details ==
> 
> Series: series starting with [v2] drm: Add missing mutex_destroy in drm_dev_init/release (rev2)
> URL   : https://patchwork.freedesktop.org/series/15110/
> State : success

Daniel applied the other patch and I the second, thanks for review.

Regards, Joonas
-- 
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2016-11-14 12:31 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-10 13:36 [PATCH 1/2] drm: Add missing mutex_destroy in drm_dev_init Joonas Lahtinen
2016-11-10 13:36 ` [PATCH 2/2] drm/i915: Update i915_driver_load kerneldoc Joonas Lahtinen
2016-11-11 17:51   ` Chris Wilson
2016-11-10 13:50 ` [PATCH v2] drm: Add missing mutex_destroy in drm_dev_init/release Joonas Lahtinen
2016-11-10 14:45   ` Chris Wilson
2016-11-10 14:16 ` ✓ Fi.CI.BAT: success for series starting with [v2] drm: Add missing mutex_destroy in drm_dev_init/release (rev2) Patchwork
2016-11-14 12:31   ` Joonas Lahtinen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).