intel-gfx.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: Lyude Paul <lyude@redhat.com>
To: Tomeu Vizoso <tomeu@tomeuvizoso.net>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Subject: Re: [RFC i-g-t 0/4] intel-gpu-tools: Add support for the Chamelium
Date: Fri, 11 Nov 2016 12:53:50 -0500	[thread overview]
Message-ID: <1478886830.5059.1.camel@redhat.com> (raw)
In-Reply-To: <CAAObsKDLRfqGpAMaH_=kCnFF9Y0-M2_OUNnVL95XESQVzDhsUg@mail.gmail.com>

Alright, quick question: should we be going with your branch then or
mine?

On Wed, 2016-11-09 at 16:09 +0100, Tomeu Vizoso wrote:
> Hi Lyude,
> 
> I think this looks very good.
> 
> On 8 November 2016 at 01:05, Lyude <lyude@redhat.com> wrote:
> > 
> > 
> >  - While writing this patch series, I found that quite a few of the
> > RPC calls
> >    for chameleond don't work as expected. For instance, I have had
> > absolutely
> >    no luck getting CRCs from any of the display types that the
> > chamelium
> >    supports.
> 
> When I looked at this a few months ago, frame CRCs were working just
> fine. I was using libsoup, so maybe there's some problem with the
> unpacking of the checksum?

I'm pretty sure it's on the chameleond side of things. Using the test
server application in chameleond's source shows the same issue. 
> 
> > 
> > This isn't a huge deal though, since we usually just use the
> >    native CRC read back on the GPU anyway.
> 
> I'm not completely sure what you mean by that, but not all graphic
> pipelines are able to provide frame CRCs so I think this Chamelium
> work will be very useful when running tests that do check frame CRCs.
I wasn't aware of that, thanks for letting me know

> 
> Regards,
> 
> Tomeu
> 
> > 
> > 
> >  - Among other things that are broken with the chameleon, video
> > signal
> >    detection for DisplayPort is one of them. After the first
> > plug/unplug cycle,
> >    the DisplayPort receiver gets stuck and gives the wrong results
> > for
> >    WaitForInputStable. Luckily I've already got a fix I'll be
> > submitting to the
> >    ChromeOS guys when I get around to setting up their homebrew git
> > tools:
> > 
> >         https://github.com/Lyude/chameleond/tree/wip/chameleon-fixe
> > s
> > 
> >    For now, expect the dp-display tests to fail without those
> > patches.
> > 
> > Lyude (4):
> >   igt_aux: Add igt_skip_without_suspend_support()
> >   igt_aux: Add igt_set_autoresume_delay()
> >   igt_aux: Add some list helpers from wayland
> >   Add support for hotplug testing with the Chamelium
> > 
> >  configure.ac           |  13 +
> >  lib/Makefile.am        |  10 +-
> >  lib/igt.h              |   1 +
> >  lib/igt_aux.c          |  94 ++++++++
> >  lib/igt_aux.h          |  41 ++++
> >  lib/igt_chamelium.c    | 628
> > +++++++++++++++++++++++++++++++++++++++++++++++++
> >  lib/igt_chamelium.h    |  77 ++++++
> >  lib/igt_kms.c          | 107 +++++++++
> >  lib/igt_kms.h          |  13 +-
> >  scripts/run-tests.sh   |   4 +-
> >  tests/Makefile.am      |   5 +-
> >  tests/Makefile.sources |   1 +
> >  tests/chamelium.c      | 549
> > ++++++++++++++++++++++++++++++++++++++++++
> >  13 files changed, 1538 insertions(+), 5 deletions(-)
> >  create mode 100644 lib/igt_chamelium.c
> >  create mode 100644 lib/igt_chamelium.h
> >  create mode 100644 tests/chamelium.c
> > 
> > --
> > 2.7.4
> > 
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
-- 
Cheers,
	Lyude
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2016-11-11 17:53 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-08  0:05 [RFC i-g-t 0/4] intel-gpu-tools: Add support for the Chamelium Lyude
2016-11-08  0:05 ` [RFC i-g-t 1/4] igt_aux: Add igt_skip_without_suspend_support() Lyude
2016-11-08  0:05 ` [RFC i-g-t 2/4] igt_aux: Add igt_set_autoresume_delay() Lyude
2016-11-08  9:39   ` Chris Wilson
2016-11-08  0:05 ` [RFC i-g-t 3/4] igt_aux: Add some list helpers from wayland Lyude
2016-11-08  9:37   ` Chris Wilson
2016-11-08  0:05 ` [RFC i-g-t 4/4] Add support for hotplug testing with the Chamelium Lyude
2016-11-09 15:18   ` Tomeu Vizoso
2016-11-14  7:05   ` Daniel Vetter
2016-11-14 16:46     ` Lyude Paul
2016-11-09 15:09 ` [RFC i-g-t 0/4] intel-gpu-tools: Add support for " Tomeu Vizoso
2016-11-11 17:53   ` Lyude Paul [this message]
2016-11-15 11:44     ` Tomeu Vizoso
2016-11-15 21:44       ` Lyude Paul
2016-11-16 11:52         ` Tomeu Vizoso
2016-11-28 20:10           ` Lyude Paul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1478886830.5059.1.camel@redhat.com \
    --to=lyude@redhat.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=tomeu@tomeuvizoso.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).