From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Prune the reservation shared fence array
Date: Tue, 15 Nov 2016 16:38:19 +0200 [thread overview]
Message-ID: <1479220699.3260.1.camel@linux.intel.com> (raw)
In-Reply-To: <20161114085327.16327-1-chris@chris-wilson.co.uk>
On ma, 2016-11-14 at 08:53 +0000, Chris Wilson wrote:
> +++ b/drivers/gpu/drm/i915/i915_vma.c
> @@ -53,6 +53,12 @@ i915_vma_retire(struct i915_gem_active *active,
> if (--obj->active_count)
> return;
>
> + /* Prune the shared fence arrays iff completely idle (inc. external) */
> + ww_mutex_lock(&obj->resv->lock, NULL);
> + if (reservation_object_test_signaled_rcu(obj->resv, true))
> + reservation_object_add_excl_fence(obj->resv, NULL);
> + ww_mutex_unlock(&obj->resv->lock);
> +
This is not the first instance of "resv->lock" usage, but I think we
should not be doing that, and add reservation_* functions instead...
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-11-15 14:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-14 8:53 [PATCH] drm/i915: Prune the reservation shared fence array Chris Wilson
2016-11-14 10:07 ` ✗ Fi.CI.BAT: warning for " Patchwork
2016-11-15 14:38 ` Joonas Lahtinen [this message]
2016-11-15 15:26 ` [PATCH] " Chris Wilson
2016-11-15 15:33 ` Chris Wilson
-- strict thread matches above, loose matches on Subject: below --
2017-11-07 22:06 Chris Wilson
2017-11-08 15:09 ` Joonas Lahtinen
2017-11-08 15:51 ` Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1479220699.3260.1.camel@linux.intel.com \
--to=joonas.lahtinen@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).