From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joonas Lahtinen Subject: Re: [PATCH v2 4/4] drm/i915: Fix i915_gem_evict_for_vma (soft-pinning) Date: Fri, 18 Nov 2016 11:18:09 +0200 Message-ID: <1479460689.3594.10.camel@linux.intel.com> References: <20161117120844.27340-1-chris@chris-wilson.co.uk> <20161117120844.27340-4-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3B5626E922 for ; Fri, 18 Nov 2016 09:18:15 +0000 (UTC) In-Reply-To: <20161117120844.27340-4-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gdG8sIDIwMTYtMTEtMTcgYXQgMTI6MDggKzAwMDAsIENocmlzIFdpbHNvbiB3cm90ZTrCoAo+ IC1pbnQKPiAtaTkxNV9nZW1fZXZpY3RfZm9yX3ZtYShzdHJ1Y3QgaTkxNV92bWEgKnRhcmdldCkK PiAraW50IGk5MTVfZ2VtX2V2aWN0X2Zvcl92bWEoc3RydWN0IGk5MTVfdm1hICp0YXJnZXQsIHVu c2lnbmVkIGludCBmbGFncykKPiDCoHsKPiAtCXN0cnVjdCBkcm1fbW1fbm9kZSAqbm9kZSwgKm5l eHQ7Cj4gKwlMSVNUX0hFQUQoZXZpY3Rpb25fbGlzdCk7Cj4gKwlzdHJ1Y3QgZHJtX21tX25vZGUg Km5vZGU7Cj4gKwl1NjQgc3RhcnQgPSB0YXJnZXQtPm5vZGUuc3RhcnQ7Cj4gKwl1NjQgZW5kID0g c3RhcnQgKyB0YXJnZXQtPm5vZGUuc2l6ZTsKPiArCXN0cnVjdCBpOTE1X3ZtYSAqdm1hLCAqbmV4 dDsKPiArCWJvb2wgY2hlY2tfY29sb3I7Cj4gKwlpbnQgcmV0ID0gMDsKPiDCoAo+IMKgCWxvY2tk ZXBfYXNzZXJ0X2hlbGQoJnRhcmdldC0+dm0tPmRldi0+c3RydWN0X211dGV4KTsKPiArCXRyYWNl X2k5MTVfZ2VtX2V2aWN0X3ZtYSh0YXJnZXQsIGZsYWdzKTsKPiArCgpEYW5pZWwgYWxyZWFkeSBt aXNyZWFkIHRoaXMsIHNvIEkgdGhpbmsgaXQgbWlnaHQgYmUgd29ydGggY29tbWVudGluZzsKCj4g KwljaGVja19jb2xvciA9IHRhcmdldC0+dm0tPm1tLmNvbG9yX2FkanVzdDsKPiArCWlmIChjaGVj a19jb2xvcikgewoKCQkvKiBFeHRlbmQgdGhlIHNlYXJjaCBhcmVhIHRvIGNvdmVyIGd1YXJkIHBh Z2VzLiAqLwoKPiArCQlpZiAoc3RhcnQgPiB0YXJnZXQtPnZtLT5zdGFydCkKPiArCQkJc3RhcnQg LT0gNDA5NjsKPiArCQlpZiAoZW5kIDwgdGFyZ2V0LT52bS0+c3RhcnQgKyB0YXJnZXQtPnZtLT50 b3RhbCkKPiArCQkJZW5kICs9IDQwOTY7Cj4gKwl9Cgo8U05JUD4KCj4gKwkJaWYgKGZsYWdzICYg UElOX05PTkJMT0NLICYmCj4gKwkJwqDCoMKgwqAoaTkxNV92bWFfaXNfcGlubmVkKHZtYSkgfHwg aTkxNV92bWFfaXNfYWN0aXZlKHZtYSkpKSB7Cj4gKwkJCXJldCA9IC1FTk9TUEM7Cj4gKwkJCWJy ZWFrOwo+ICsJCX0KCmk5MTVfdm1hX2lzX3Bpbm5lZCgpIGJlaW5nIHRydWUgd2lsbCBleGl0IHRo aXMgbG9vcCB3aXRoIC1FTk9TUEMgd2l0aApvciB3aXRob3V0IE5PQkxPQ0ssIGp1c3Qgc2tpcHBp bmcgdGhlIGV4ZWNfZW50cnkgdGVzdCB3aXRob3V0IGl0LiBJCndvdWxkIGNsYXJpZnkgdGhhdC4g Tm93IGl0J3MgYml0IG9kZC4KCj4gwqAKPiAtCQkJcmV0dXJuIC1FTk9TUEM7Cj4gKwkJLyogT3Zl cmxhcCBvZiBvYmplY3RzIGluIHRoZSBzYW1lIGJhdGNoPyAqLwo+ICsJCWlmIChpOTE1X3ZtYV9p c19waW5uZWQodm1hKSkgewo+ICsJCQlyZXQgPSAtRU5PU1BDOwo+ICsJCQlpZiAodm1hLT5leGVj X2VudHJ5ICYmCj4gKwkJCcKgwqDCoMKgdm1hLT5leGVjX2VudHJ5LT5mbGFncyAmIEVYRUNfT0JK RUNUX1BJTk5FRCkKPiArCQkJCXJldCA9IC1FSU5WQUw7Cj4gKwkJCWJyZWFrOwo+IMKgCQl9Cj4g wqAKPiAtCQlyZXQgPSBpOTE1X3ZtYV91bmJpbmQodm1hKTsKPiAtCQlpZiAocmV0KQo+IC0JCQly ZXR1cm4gcmV0Owo+ICsJCV9faTkxNV92bWFfcGluKHZtYSk7CgpJIGRvbid0IHF1aXRlIHNlZSB3 aHk/IEFyZSB5b3UgZXhwZWN0aW5nIHRoZSBpdGVyYXRpb24gdG8gaGl0IHNhbWUgdm1hCnR3aWNl PyBPciBzb21lYm9keSBtb3ZpbmcgaXQgd2hpbGUgd2UgaXRlcmF0ZS4KCj4gKwkJbGlzdF9hZGQo JnZtYS0+ZXhlY19saXN0LCAmZXZpY3Rpb25fbGlzdCk7CgpJJ2QgcHJlZmVyIGFuIHVuaW9uIGlu c3RlYWQgb2YgYnJ1dGFsbHkgcmV1c2luZyBtZW1iZXIgZm9yIG90aGVyCnB1cnBvc2VzLgoKPiDC oAl9Cj4gwqAKPiAtCXJldHVybiAwOwo+ICsJbGlzdF9mb3JfZWFjaF9lbnRyeV9zYWZlKHZtYSwg bmV4dCwgJmV2aWN0aW9uX2xpc3QsIGV4ZWNfbGlzdCkgewo+ICsJCWxpc3RfZGVsX2luaXQoJnZt YS0+ZXhlY19saXN0KTsKPiArCQlfX2k5MTVfdm1hX3VucGluKHZtYSk7Cj4gKwkJaWYgKHJldCA9 PSAwKQo+ICsJCQlyZXQgPSBpOTE1X3ZtYV91bmJpbmQodm1hKTsKPiArCX0KPiArCj4gKwlyZXR1 cm4gcmV0Owo+IMKgfQo+IMKgCgpSZWdhcmRzLCBKb29uYXMKLS0gCkpvb25hcyBMYWh0aW5lbgpP cGVuIFNvdXJjZSBUZWNobm9sb2d5IENlbnRlcgpJbnRlbCBDb3Jwb3JhdGlvbgpfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBs aXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVz a3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK