From: Imre Deak <imre.deak@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>,
Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v5] drm/i915: Be more careful to drop the GT wakeref
Date: Fri, 18 Nov 2016 14:25:20 +0200 [thread overview]
Message-ID: <1479471920.19861.8.camel@intel.com> (raw)
In-Reply-To: <20161118115016.GA28142@nuc-i3427.alporthouse.com>
On pe, 2016-11-18 at 11:50 +0000, Chris Wilson wrote:
> On Fri, Nov 18, 2016 at 01:22:11PM +0200, Joonas Lahtinen wrote:
> > On ti, 2016-11-15 at 16:46 +0000, Chris Wilson wrote:
> > > @@ -218,7 +218,12 @@ static void i915_gem_request_retire(struct
> > > drm_i915_gem_request *request)
> > > */
> > > list_del(&request->ring_link);
> > > request->ring->last_retired_head = request->postfix;
> > > - request->i915->gt.active_requests--;
> > > + if (!--request->i915->gt.active_requests) {
> >
> > BUG_ON(!request->i915->gt.active_requests) at the top?
> >
> > Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
>
> Thanks. Hmm, this may catch that one-off report of
> GEM_BUG_ON(gt.awake)
> upon suspend. I don't think that made it to bugzilla.
This one?:
https://bugs.freedesktop.org/show_bug.cgi?id=98670
> -Chris
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-11-18 12:25 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-15 14:26 [PATCH] drm/i915: Be more careful to drop the GT wakeref Chris Wilson
2016-11-15 14:31 ` Chris Wilson
2016-11-15 15:23 ` [PATCH v3] " Chris Wilson
2016-11-15 15:24 ` [PATCH v4] " Chris Wilson
2016-11-15 14:47 ` ✓ Fi.CI.BAT: success for " Patchwork
2016-11-15 16:16 ` ✓ Fi.CI.BAT: success for drm/i915: Be more careful to drop the GT wakeref (rev4) Patchwork
2016-11-15 16:46 ` [PATCH v5] drm/i915: Be more careful to drop the GT wakeref Chris Wilson
2016-11-18 11:22 ` Joonas Lahtinen
2016-11-18 11:39 ` Chris Wilson
2016-11-18 11:50 ` Chris Wilson
2016-11-18 12:25 ` Imre Deak [this message]
2016-11-18 12:35 ` Chris Wilson
2016-11-15 17:45 ` ✗ Fi.CI.BAT: warning for drm/i915: Be more careful to drop the GT wakeref (rev5) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1479471920.19861.8.camel@intel.com \
--to=imre.deak@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=joonas.lahtinen@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).