From: Animesh Manna <animesh.manna@intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: [PATCH 3/5] drm/i915/bxt: Added _DSM call to set HPD_CTL.
Date: Wed, 23 Nov 2016 21:48:25 +0530 [thread overview]
Message-ID: <1479917907-2468-4-git-send-email-animesh.manna@intel.com> (raw)
In-Reply-To: <1479917907-2468-1-git-send-email-animesh.manna@intel.com>
_DSM is added to program HPD_CTL(0x1094) register
of PMC from i915 driver which will be called
based on driver feature flag. PMC hpd control register
programming will enable PMC to get hpd interrupt
during dc9.
Signed-off-by: Animesh Manna <animesh.manna@intel.com>
---
drivers/gpu/drm/i915/intel_acpi.c | 44 ++++++++++++++++++++++++++++++++-------
1 file changed, 37 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_acpi.c b/drivers/gpu/drm/i915/intel_acpi.c
index 8c878ab..15d3b84 100755
--- a/drivers/gpu/drm/i915/intel_acpi.c
+++ b/drivers/gpu/drm/i915/intel_acpi.c
@@ -10,6 +10,8 @@
#define INTEL_DSM_REVISION_ID 1 /* For Calpella anyway... */
#define INTEL_DSM_FN_PLATFORM_MUX_INFO 1 /* No args */
+#define INTEL_DSM_SET_HPD_WAKEUP 17
+#define HPD_WAKEUP_EN_VAL 0xFCF0
static struct intel_dsm_priv {
acpi_handle dhandle;
@@ -118,6 +120,25 @@ static void intel_dsm_platform_mux_info(void)
ACPI_FREE(pkg);
}
+static void intel_dsm_set_hpd_wakeup(u8 *guid)
+{
+ union acpi_object *obj;
+ union acpi_object argv4 = {
+ .integer.type = ACPI_TYPE_INTEGER,
+ .integer.value = HPD_WAKEUP_EN_VAL,
+ };
+
+ obj = acpi_evaluate_dsm_typed(intel_dsm_priv.dhandle, guid,
+ INTEL_DSM_REVISION_ID, INTEL_DSM_SET_HPD_WAKEUP,
+ &argv4, ACPI_TYPE_INTEGER);
+
+ if (!obj)
+ DRM_DEBUG_DRIVER("failed to evaluate _DSM\n");
+
+ ACPI_FREE(obj);
+}
+
+
static bool intel_dsm_pci_probe(struct pci_dev *pdev)
{
acpi_handle dhandle;
@@ -134,14 +155,23 @@ static bool intel_dsm_pci_probe(struct pci_dev *pdev)
else
guid = intel_dsm_guid;
- if (!acpi_check_dsm(dhandle, guid, INTEL_DSM_REVISION_ID,
- 1 << INTEL_DSM_FN_PLATFORM_MUX_INFO)) {
- DRM_DEBUG_KMS("no _DSM method for intel device\n");
- return false;
- }
-
intel_dsm_priv.dhandle = dhandle;
- intel_dsm_platform_mux_info();
+
+ if (acpi_check_dsm(dhandle, guid, INTEL_DSM_REVISION_ID,
+ 1 << INTEL_DSM_FN_PLATFORM_MUX_INFO))
+ intel_dsm_platform_mux_info();
+ else
+ DRM_DEBUG_KMS("no _DSM method for mux-info\n");
+
+ /* Need to ensure vbt parsing is completed. */
+ if (dev_priv->vbt.hpd_wakeup_enabled &&
+ acpi_check_dsm(dhandle, guid, INTEL_DSM_REVISION_ID,
+ 1 << INTEL_DSM_SET_HPD_WAKEUP))
+ intel_dsm_set_hpd_wakeup(guid);
+ else {
+ dev_priv->vbt.hpd_wakeup_enabled = false;
+ DRM_DEBUG_KMS("no _DSM method for hpd-enabling\n");
+ }
return true;
}
--
1.9.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-11-23 16:05 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-23 16:18 [PATCH 0/5] HPD support during suspend for BXT/APL Animesh Manna
2016-11-23 16:18 ` [PATCH 1/5] drm/i915/bxt: Corrected the guid for bxt Animesh Manna
2016-11-23 16:32 ` Chris Wilson
2016-11-28 10:56 ` Animesh Manna
2016-11-28 11:24 ` Jani Nikula
2016-11-28 16:21 ` Animesh Manna
2016-11-23 16:18 ` [PATCH 2/5] drm/i915/bxt: VBT changes for hpd as wakeup feature Animesh Manna
2016-11-24 14:27 ` Jani Nikula
2016-11-23 16:18 ` Animesh Manna [this message]
2016-11-23 18:17 ` [PATCH 3/5] drm/i915/bxt: Added _DSM call to set HPD_CTL Ville Syrjälä
2016-11-28 16:06 ` Animesh Manna
2016-11-28 16:27 ` Ville Syrjälä
2016-11-24 14:22 ` Jani Nikula
2016-11-23 16:18 ` [PATCH 4/5] drm/i915/bxt: Block D3 during suspend Animesh Manna
2016-11-23 16:18 ` [PATCH 5/5] drm/i915: Enable HPD interrupts with master ctl interrupt Animesh Manna
2016-11-23 17:01 ` Imre Deak
2016-11-28 13:39 ` Animesh Manna
2016-11-28 14:41 ` Imre Deak
2016-11-23 17:10 ` Ville Syrjälä
2016-11-28 15:49 ` Animesh Manna
2016-11-28 16:02 ` Ville Syrjälä
2016-11-23 17:46 ` ✗ Fi.CI.BAT: warning for HPD support during suspend for BXT/APL Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1479917907-2468-4-git-send-email-animesh.manna@intel.com \
--to=animesh.manna@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox