From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915/debugfs: Increment return value of gt.next_seqno
Date: Thu, 24 Nov 2016 14:15:07 +0200 [thread overview]
Message-ID: <1479989707.2911.8.camel@linux.intel.com> (raw)
In-Reply-To: <20161124094752.19129-1-chris@chris-wilson.co.uk>
On to, 2016-11-24 at 09:47 +0000, Chris Wilson wrote:
> The i915_next_seqno read value is to be the next seqno used by the
> kernel. However, in the conversion to atomics ops for gt.next_seqno, in
> commit 28176ef4cfa5 ("drm/i915: Reserve space in the global seqno during
> request allocation"), this was changed from a post-increment to a
> pre-increment. This increment was missed from the value reported by
> debugfs, so in effect it was reporting the current seqno (last
> assigned), not the next seqno.
>
> Fixes: 28176ef4cfa5 ("drm/i915: Reserve space in the global seqno during request allocation")
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=81209
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
<SNIP>
> @@ -1026,7 +1026,7 @@ i915_next_seqno_get(void *data, u64 *val)
> {
> struct drm_i915_private *dev_priv = data;
>
> - *val = atomic_read(&dev_priv->gt.global_timeline.next_seqno);
> + *val = 1 + atomic_read(&dev_priv->gt.global_timeline.next_seqno);
The variable name really should be last_seqno or so...
But as a hotfix;
Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Regards, joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-11-24 12:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-24 9:47 [PATCH] drm/i915/debugfs: Increment return value of gt.next_seqno Chris Wilson
2016-11-24 10:45 ` ✗ Fi.CI.BAT: warning for " Patchwork
2016-11-24 11:25 ` Saarinen, Jani
2016-11-24 12:15 ` Joonas Lahtinen [this message]
2016-11-24 12:26 ` [PATCH] " Chris Wilson
2016-11-24 12:49 ` Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1479989707.2911.8.camel@linux.intel.com \
--to=joonas.lahtinen@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox