From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Intel graphics driver community testing & development
<intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] drm/i915: Catch non-existent registers in find_fw_domain
Date: Wed, 07 Dec 2016 16:08:03 +0200 [thread overview]
Message-ID: <1481119683.5745.13.camel@linux.intel.com> (raw)
In-Reply-To: <20161207140149.GA7955@nuc-i3427.alporthouse.com>
On ke, 2016-12-07 at 14:01 +0000, Chris Wilson wrote:
> On Wed, Dec 07, 2016 at 03:49:39PM +0200, Joonas Lahtinen wrote:
> >
> > + WARN_ON(entry->domains & ~dev_priv->uncore.fw_domains);
>
> Ok, this is going to be hard to diagnose in the wild, how about
>
> WARN(entry->domains & ~fw_domains,
> "Attempting to use register 0x%04x from uninitialised fw domain %x\n",
> offset, entry->domains & ~fw_domains); ?
That's an excellent idea. Although I'll call it "forcewake domain" for
clarity.
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-12-07 14:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-07 13:49 [PATCH] drm/i915: Catch non-existent registers in find_fw_domain Joonas Lahtinen
2016-12-07 14:01 ` Chris Wilson
2016-12-07 14:08 ` Joonas Lahtinen [this message]
2016-12-07 14:22 ` [PATCH v2] " Joonas Lahtinen
2016-12-07 14:40 ` Chris Wilson
2016-12-07 18:18 ` Tvrtko Ursulin
2016-12-07 18:28 ` Chris Wilson
2016-12-08 7:53 ` Joonas Lahtinen
2016-12-07 17:45 ` ✓ Fi.CI.BAT: success for drm/i915: Catch non-existent registers in find_fw_domain (rev2) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1481119683.5745.13.camel@linux.intel.com \
--to=joonas.lahtinen@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox