Re: [PATCH v7 0/8] GEN-9 Arbitrated Bandwidth WM WA's & IPC

From: "Zanoni, Paulo R" <paulo.r.zanoni@intel.com>
To: "daniel@ffwll.ch" <daniel@ffwll.ch>
Cc: "intel-gfx@lists.freedesktop.org"
	<intel-gfx@lists.freedesktop.org>,
	"Lankhorst, Maarten" <maarten.lankhorst@intel.com>
Subject: Re: [PATCH v7 0/8] GEN-9 Arbitrated Bandwidth WM WA's & IPC
Date: Thu, 8 Dec 2016 16:12:37 +0000	[thread overview]
Message-ID: <1481213551.2375.34.camel@intel.com> (raw)
In-Reply-To: <20161208160051.dwurp2ft24ngetnj@phenom.ffwll.local>

Em Qui, 2016-12-08 às 17:00 +0100, Daniel Vetter escreveu:
> On Wed, Dec 07, 2016 at 05:35:09PM -0200, Paulo Zanoni wrote:
> > 
> > Em Qui, 2016-12-01 às 21:19 +0530, Mahesh Kumar escreveu:
> > > 
> > > This series implements following set of functionality
> > > 	Implement IPC WA's for Broxton/KBL
> > > 	Enable IPC in supported platforms
> > > 	Convert WM calculation to fixed point calculation
> > > 	Calculation of System memory Bandwidth for SKL/KBL/BXT
> > > 	Implementation of Arbitrated memory Bandwidth related WM WA's
> > 
> > Pushed patches 1, 2, 3, 5 and 6, with small bikesheds applied.
> > Thanks
> > for the patches!
> > 
> > (actually I had a little problem with dim, so right now only dinq
> > has
> > the patches, drm-tip doesn't, soon they will appear)
> 
> Hm, what did go boom with dim?

This was my first commit/push since the change. I had followed the
instructions on your email (including the dim setup stage), and then
when I did "dim push-queued" it complained that I didn't have the audio
remotes in my tree. After the error message I was not sure what was the
correct way to proceed.

I suppose we could change dim setup so that it really adds every single
remote that's needed? Also, why doesn't it just add the remotes itself?

>  If the pushing worked, then you can re-run
> just the drm-tip rebuilding with
> 
> $ dim rebuild-tip

Good to know, thanks for that.

> 
> Might also be worth it to upgrade to latest dim, we've dropped a few
> bugfixes in the branch push/pull logic in a few places since the big
> conversion, you might hit them.

I always upgrade to the latest version before using it.

> 
> If all this doesn't help, pls ping me on irc with a pastebin of
> what's
> going on. For testing you can always run

I sent you an email yesterday with the error message pasted... Maybe
you'll find it soon :).

> 
> $ dim pq
> 
> To repush dinq - dim will complain if you'll do a non-ff push and
> abort,
> so it's safe.
> -Daniel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx