intel-gfx.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
To: dri-devel@lists.freedesktop.org
Cc: intel-gfx@lists.freedesktop.org
Subject: [PATCH 1/4] drm/atomic: Delete wrong comment.
Date: Thu, 15 Dec 2016 15:29:42 +0100	[thread overview]
Message-ID: <1481812185-19098-2-git-send-email-maarten.lankhorst@linux.intel.com> (raw)
In-Reply-To: <1481812185-19098-1-git-send-email-maarten.lankhorst@linux.intel.com>

drm_atomic_state_put is called unconditionally, so TEST_ONLY is no
different from commit.

Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
---
 drivers/gpu/drm/drm_atomic.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/gpu/drm/drm_atomic.c b/drivers/gpu/drm/drm_atomic.c
index 60697482b94c..d1d252261bf1 100644
--- a/drivers/gpu/drm/drm_atomic.c
+++ b/drivers/gpu/drm/drm_atomic.c
@@ -2195,10 +2195,6 @@ int drm_mode_atomic_ioctl(struct drm_device *dev,
 		goto out;
 
 	if (arg->flags & DRM_MODE_ATOMIC_TEST_ONLY) {
-		/*
-		 * Unlike commit, check_only does not clean up state.
-		 * Below we call drm_atomic_state_put for it.
-		 */
 		ret = drm_atomic_check_only(state);
 	} else if (arg->flags & DRM_MODE_ATOMIC_NONBLOCK) {
 		ret = drm_atomic_nonblocking_commit(state);
-- 
2.7.4

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2016-12-15 14:29 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-15 14:29 [PATCH 0/4] drm: Resurrect atomic rmfb code Maarten Lankhorst
2016-12-15 14:29 ` Maarten Lankhorst [this message]
2016-12-15 15:19   ` [Intel-gfx] [PATCH 1/4] drm/atomic: Delete wrong comment Daniel Vetter
2017-01-04 11:15     ` [PATCH] drm/atomic: Fix outdated comment Maarten Lankhorst
2017-01-04 11:22       ` Chris Wilson
2017-01-04 11:28         ` Daniel Vetter
2017-01-04 11:34           ` [PATCH v2] " Maarten Lankhorst
2017-01-04 15:41             ` Daniel Vetter
2016-12-15 14:29 ` [PATCH 2/4] drm/i915: Fix POWER_DOMAIN_AUDIO refcounting Maarten Lankhorst
2017-01-11 16:13   ` Daniel Vetter
2017-01-16 11:00     ` Maarten Lankhorst
2017-01-23  7:43       ` [Intel-gfx] " Daniel Vetter
2016-12-15 14:29 ` [PATCH 3/4] drm/i915: Disable all crtcs during driver unload Maarten Lankhorst
2017-01-11 16:15   ` Daniel Vetter
2016-12-15 14:29 ` [PATCH 4/4] drm: Resurrect atomic rmfb code, v2 Maarten Lankhorst
2017-01-11 16:15   ` Daniel Vetter
2017-01-24 21:44     ` Matt Roper
2017-01-25  4:54       ` Daniel Vetter
2017-01-25  8:09         ` Thomas Hellstrom
2017-01-25  8:36           ` Maarten Lankhorst
2017-01-25 18:05             ` Sinclair Yeh
2017-01-26  9:55               ` Maarten Lankhorst
2017-01-26 18:39                 ` Sinclair Yeh
2017-02-09 12:29                   ` Maarten Lankhorst
2017-02-09 15:58                     ` Sinclair Yeh
2017-01-25 11:30           ` [PATCH v3 4/4] drm: Resurrect atomic rmfb code, v3 Maarten Lankhorst
2017-02-15 13:56             ` Jani Nikula
2017-02-15 16:28               ` [Intel-gfx] " Sinclair Yeh
2017-02-16  9:45                 ` Jani Nikula
2017-02-16 11:00                   ` [Intel-gfx] " Maarten Lankhorst
2016-12-15 16:23 ` ✗ Fi.CI.BAT: warning for drm: Resurrect atomic rmfb code Patchwork
2016-12-15 16:25   ` Maarten Lankhorst

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1481812185-19098-2-git-send-email-maarten.lankhorst@linux.intel.com \
    --to=maarten.lankhorst@linux.intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).