From: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
To: dri-devel@lists.freedesktop.org
Cc: intel-gfx@lists.freedesktop.org
Subject: [PATCH 3/4] drm/i915: Disable all crtcs during driver unload.
Date: Thu, 15 Dec 2016 15:29:44 +0100 [thread overview]
Message-ID: <1481812185-19098-4-git-send-email-maarten.lankhorst@linux.intel.com> (raw)
In-Reply-To: <1481812185-19098-1-git-send-email-maarten.lankhorst@linux.intel.com>
We may keep the crtc's enabled when userspace unsets all framebuffers but
keeps the crtc active. This exposes a WARN in fbc_global disable, and
a lot of bugs in our hardware readout code. Solve this by disabling
all crtc's for now.
Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
---
drivers/gpu/drm/i915/i915_drv.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
index 6428588518aa..bb0d7517b678 100644
--- a/drivers/gpu/drm/i915/i915_drv.c
+++ b/drivers/gpu/drm/i915/i915_drv.c
@@ -43,6 +43,7 @@
#include <drm/drmP.h>
#include <drm/drm_crtc_helper.h>
+#include <drm/drm_atomic_helper.h>
#include <drm/i915_drm.h>
#include "i915_drv.h"
@@ -1282,6 +1283,10 @@ void i915_driver_unload(struct drm_device *dev)
intel_display_power_get(dev_priv, POWER_DOMAIN_INIT);
+ drm_modeset_lock_all(dev);
+ drm_atomic_helper_disable_all(dev, dev->mode_config.acquire_ctx);
+ drm_modeset_unlock_all(dev);
+
i915_driver_unregister(dev_priv);
drm_vblank_cleanup(dev);
--
2.7.4
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-12-15 14:29 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-15 14:29 [PATCH 0/4] drm: Resurrect atomic rmfb code Maarten Lankhorst
2016-12-15 14:29 ` [PATCH 1/4] drm/atomic: Delete wrong comment Maarten Lankhorst
2016-12-15 15:19 ` [Intel-gfx] " Daniel Vetter
2017-01-04 11:15 ` [PATCH] drm/atomic: Fix outdated comment Maarten Lankhorst
2017-01-04 11:22 ` Chris Wilson
2017-01-04 11:28 ` Daniel Vetter
2017-01-04 11:34 ` [PATCH v2] " Maarten Lankhorst
2017-01-04 15:41 ` Daniel Vetter
2016-12-15 14:29 ` [PATCH 2/4] drm/i915: Fix POWER_DOMAIN_AUDIO refcounting Maarten Lankhorst
2017-01-11 16:13 ` Daniel Vetter
2017-01-16 11:00 ` Maarten Lankhorst
2017-01-23 7:43 ` [Intel-gfx] " Daniel Vetter
2016-12-15 14:29 ` Maarten Lankhorst [this message]
2017-01-11 16:15 ` [PATCH 3/4] drm/i915: Disable all crtcs during driver unload Daniel Vetter
2016-12-15 14:29 ` [PATCH 4/4] drm: Resurrect atomic rmfb code, v2 Maarten Lankhorst
2017-01-11 16:15 ` Daniel Vetter
2017-01-24 21:44 ` Matt Roper
2017-01-25 4:54 ` Daniel Vetter
2017-01-25 8:09 ` Thomas Hellstrom
2017-01-25 8:36 ` Maarten Lankhorst
2017-01-25 18:05 ` Sinclair Yeh
2017-01-26 9:55 ` Maarten Lankhorst
2017-01-26 18:39 ` Sinclair Yeh
2017-02-09 12:29 ` Maarten Lankhorst
2017-02-09 15:58 ` Sinclair Yeh
2017-01-25 11:30 ` [PATCH v3 4/4] drm: Resurrect atomic rmfb code, v3 Maarten Lankhorst
2017-02-15 13:56 ` Jani Nikula
2017-02-15 16:28 ` [Intel-gfx] " Sinclair Yeh
2017-02-16 9:45 ` Jani Nikula
2017-02-16 11:00 ` [Intel-gfx] " Maarten Lankhorst
2016-12-15 16:23 ` ✗ Fi.CI.BAT: warning for drm: Resurrect atomic rmfb code Patchwork
2016-12-15 16:25 ` Maarten Lankhorst
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1481812185-19098-4-git-send-email-maarten.lankhorst@linux.intel.com \
--to=maarten.lankhorst@linux.intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).