Re: [PATCH v2 0/9] drm/i915: Add a per-pipe plane identifier enum (v2)

Ville Syrjälä
2016-11-23T20:16:58Z

On Tue, Nov 22, 2016 at 06:01:55PM +0200, ville.syrjala@linux.intel.com wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> I ended up tweaking quite a few of the patches (and even adding a new one)
> based on Paulo's review, so figured I'd repost the entire thing.
>
> I didn't do the _ID_ rename thing, at least not yet. I'll have to
> think about it more if I could come up with some nice way to deal
> with the per-pipe id vs. the A/B/C plane id.
>
> Anyways, enough of these got r-bs so that I can at least move
> forward with VLV/CHV watermark rewrite #4 now.
>
> Ville Syrjälä (9):
> drm/i915: Add per-pipe plane identifier
> drm/i915: Add crtc->plane_ids_mask
> drm/i915: Use enum plane_id in SKL wm code
> drm/i915: Use enum plane_id in SKL plane code
> drm/i915: Use enum plane_id in VLV/CHV sprite code
> drm/i915: Use enum plane_id in VLV/CHV wm code

Pushed upto here. Thanks for the reviews.

> drm/i915: s/plane/plane_id/ in skl+ plane register defines
> drm/i915: Don't populate plane->plane for cursors and sprites
> drm/i915: Rename the local 'plane' variable to 'plane_id' in primary
> plane code
>
> drivers/gpu/drm/i915/i915_drv.h | 30 ++++-
> drivers/gpu/drm/i915/i915_reg.h | 104 +++++++-------
> drivers/gpu/drm/i915/intel_display.c | 96 ++++++-------
> drivers/gpu/drm/i915/intel_drv.h | 6 +-
> drivers/gpu/drm/i915/intel_pm.c | 253 ++++++++++++++++-------------------
> drivers/gpu/drm/i915/intel_sprite.c | 118 ++++++++--------
> 6 files changed, 304 insertions(+), 303 deletions(-)
>
> --
> 2.7.4

--
Ville Syrjälä
Intel OTC