From: Ander Conselvan De Oliveira <conselvan2@gmail.com>
To: Rodrigo Vivi <rodrigo.vivi@intel.com>, intel-gfx@lists.freedesktop.org
Cc: Mika Kuoppala <mika.kuoppala@intel.com>
Subject: Re: [PATCH 3/3] drm/i915: Simplify gem stolen initialization.
Date: Mon, 19 Dec 2016 09:20:08 +0200 [thread overview]
Message-ID: <1482132008.3482.6.camel@gmail.com> (raw)
In-Reply-To: <1482096988-400-3-git-send-email-rodrigo.vivi@intel.com>
On Sun, 2016-12-18 at 13:36 -0800, Rodrigo Vivi wrote:
> Let's take usage of IS_LP to simplify the gem stolen
> initialization as suggest by Tvrtko.
>
> Also assume that all new LP platforms follows the chv+
> and others bdw+.
>
> Broxton and Geminilake were probably using the incorrect path
> so far.
This patch doesn't change the path for bxt or glk, they will still use
chv_get_stolen_reserved(), which is correct. It does make things clearer though,
so with the above note removed, you can apply
Reviewed-by: Ander Conselvan de Oliveira <conselvan2@gmail.com>
to the whole series.
Ander
>
> Cc: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
> Cc: Imre Deak <imre.deak@intel.com>
> Cc: Mika Kuoppala <mika.kuoppala@intel.com>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> ---
> drivers/gpu/drm/i915/i915_gem_stolen.c | 9 ++++-----
> 1 file changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_gem_stolen.c
> b/drivers/gpu/drm/i915/i915_gem_stolen.c
> index 3d24227..98deaa7 100644
> --- a/drivers/gpu/drm/i915/i915_gem_stolen.c
> +++ b/drivers/gpu/drm/i915/i915_gem_stolen.c
> @@ -454,13 +454,12 @@ int i915_gem_init_stolen(struct drm_i915_private
> *dev_priv)
> &reserved_size);
> break;
> default:
> - if (IS_BROADWELL(dev_priv) ||
> - IS_SKYLAKE(dev_priv) || IS_KABYLAKE(dev_priv))
> - bdw_get_stolen_reserved(dev_priv, &reserved_base,
> + if (IS_LP(dev_priv))
> + chv_get_stolen_reserved(dev_priv, &reserved_base,
> &reserved_size);
> else
> - chv_get_stolen_reserved(dev_priv, &reserved_base,
> - &reserved_size);
> + bdw_get_stolen_reserved(dev_priv, &reserved_base,
> + &reserved_size);
> break;
> }
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-12-19 7:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-18 21:36 [PATCH 1/3] drm/i915: Expand is_lp backwards to gen8_lp and gen7_lp Rodrigo Vivi
2016-12-18 21:36 ` [PATCH 2/3] drm/i915: Rename get stolen functions for LP platforms chv+ Rodrigo Vivi
2016-12-19 9:16 ` Daniel Vetter
2016-12-18 21:36 ` [PATCH 3/3] drm/i915: Simplify gem stolen initialization Rodrigo Vivi
2016-12-19 7:20 ` Ander Conselvan De Oliveira [this message]
2016-12-19 19:05 ` [PATCH] " Rodrigo Vivi
2016-12-19 9:16 ` [PATCH 3/3] " Daniel Vetter
2016-12-18 22:15 ` ✓ Fi.CI.BAT: success for series starting with [1/3] drm/i915: Expand is_lp backwards to gen8_lp and gen7_lp Patchwork
2016-12-19 9:15 ` [PATCH 1/3] " Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1482132008.3482.6.camel@gmail.com \
--to=conselvan2@gmail.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=mika.kuoppala@intel.com \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).