From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ander Conselvan De Oliveira Subject: Re: [PATCH 04/14] drm/i915: Clean up the .get_cdclk() assignment if ladder Date: Tue, 20 Dec 2016 11:46:43 +0200 Message-ID: <1482227203.5778.11.camel@gmail.com> References: <20161219123501.3750-1-ville.syrjala@linux.intel.com> <20161219123501.3750-5-ville.syrjala@linux.intel.com> <874m1zes9z.fsf@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-pg0-x243.google.com (mail-pg0-x243.google.com [IPv6:2607:f8b0:400e:c05::243]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9813C8968D for ; Tue, 20 Dec 2016 09:46:49 +0000 (UTC) Received: by mail-pg0-x243.google.com with SMTP id i5so1725443pgh.2 for ; Tue, 20 Dec 2016 01:46:49 -0800 (PST) In-Reply-To: <874m1zes9z.fsf@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Jani Nikula , ville.syrjala@linux.intel.com, intel-gfx@lists.freedesktop.org Cc: Rodrigo Vivi List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCAyMDE2LTEyLTE5IGF0IDE5OjM1ICswMjAwLCBKYW5pIE5pa3VsYSB3cm90ZToKPiBP biBNb24sIDE5IERlYyAyMDE2LCB2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbSB3cm90ZToK PiA+IAo+ID4gRnJvbTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVs LmNvbT4KPiA+IAo+ID4gTGV0J3MgY2xlYW4gdXAgdGhlIG1lc3Mgd2UgaGF2ZSBpbiB0aGUgaWYg bGFkZGVyIHRoYXQgYXNzaWducyB0aGUKPiA+IC5nZXRfY2RjbGsoKSBob29rcy4gVGhlIGdyb3Vw aW5nIG9mIHRoZSBwbGF0Zm9ybXMgYnkgdGhlIGZ1bmN0aW9uCj4gPiByZXN1bHRzIGluIGEgdGhp bmcgdGhhdCdzIG5vdCByZWFsbHkgbGVnaWJsZSwgc28gbGV0J3MgZG8gaXQgdGhlCj4gPiBvdGhl ciB3YXkgYXJvdW5kIGFuZCBvcmRlciB0aGUgaWYgbGFkZGVyIGJ5IHBsYXRmb3JtIGFuZCBkdXBs aWNhdGUKPiA+IHdoYXRldmVyIGFzc2lnbm1lbnRzIHdlIG5lZWQuCj4gPiAKPiA+IFRvIGZ1cnRo ZXIgYXZvaWQgY29uZnVzaW9uIHdpdGggdGhlIGZ1bmN0aW9uIG5hbWVzIGxldCdzIHJlbmFtZQo+ ID4gdGhlbSB0byBqdXN0IGZpeGVkXzxmcmVxPl9nZXRfY2RjbGsoKS4gVGhlIG90aGVyIG9wdGlv biB3b3VsZAo+ID4gYmUgdG8gZHVwbGljYXRlIHRoZSBmdW5jdGlvbnMgZW50aXJlbHkgYnV0IGl0 IHNlZW1zIHF1aXRlCj4gPiBwb2ludGxlc3MgdG8gZG8gdGhhdCBzaW5jZSBlYWNoIG9uZSBqdXN0 IHJldHVybnMgYSBmaXhlZCB2YWx1ZS4KPiA+IAo+ID4gU2lnbmVkLW9mZi1ieTogVmlsbGUgU3ly asOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KPiA+IC0tLQo+ID4gwqBkcml2 ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMgfCA0MSArKysrKysrKysrKysrKysrKysr KystLS0tLS0tLS0tCj4gPiAtLS0tLQo+ID4gwqAxIGZpbGUgY2hhbmdlZCwgMjQgaW5zZXJ0aW9u cygrKSwgMTcgZGVsZXRpb25zKC0pCj4gPiAKPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPiA+IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf ZGlzcGxheS5jCj4gPiBpbmRleCBiYmZlZjM0ODc4M2IuLjI5ZjkxZTc5OTI3MiAxMDA2NDQKPiA+ IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+ID4gKysrIGIvZHJp dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gPiBAQCAtNzM3OSwyMiArNzM3OSwy MiBAQCBzdGF0aWMgaW50IHZhbGxleXZpZXdfZ2V0X2NkY2xrKHN0cnVjdAo+ID4gZHJtX2k5MTVf cHJpdmF0ZSAqZGV2X3ByaXYpCj4gPiDCoAkJCQnCoMKgwqDCoMKgwqBDQ0tfRElTUExBWV9DTE9D S19DT05UUk9MKTsKPiA+IMKgfQo+ID4gwqAKPiA+IC1zdGF0aWMgaW50IGlsa19nZXRfY2RjbGso c3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ID4gK3N0YXRpYyBpbnQgZml4ZWRf NDUwbWh6X2dldF9jZGNsayhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gPiDC oHsKPiA+IMKgCXJldHVybiA0NTAwMDA7Cj4gPiDCoH0KPiA+IMKgCj4gPiAtc3RhdGljIGludCBp OTQ1X2dldF9jZGNsayhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gPiArc3Rh dGljIGludCBmaXhlZF80MDBtaHpfZ2V0X2NkY2xrKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpk ZXZfcHJpdikKPiA+IMKgewo+ID4gwqAJcmV0dXJuIDQwMDAwMDsKPiA+IMKgfQo+ID4gwqAKPiA+ IC1zdGF0aWMgaW50IGk5MTVfZ2V0X2NkY2xrKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZf cHJpdikKPiA+ICtzdGF0aWMgaW50IGZpeGVkXzMzM21oel9nZXRfY2RjbGsoc3RydWN0IGRybV9p OTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ID4gwqB7Cj4gPiDCoAlyZXR1cm4gMzMzMzMzOwo+ID4g wqB9Cj4gPiDCoAo+ID4gLXN0YXRpYyBpbnQgaTl4eF9taXNjX2dldF9jZGNsayhzdHJ1Y3QgZHJt X2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gPiArc3RhdGljIGludCBmaXhlZF8yMDBtaHpfZ2V0 X2NkY2xrKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiA+IMKgewo+ID4gwqAJ cmV0dXJuIDIwMDAwMDsKPiA+IMKgfQo+ID4gQEAgLTc0NDQsNyArNzQ0NCw3IEBAIHN0YXRpYyBp bnQgaTkxNWdtX2dldF9jZGNsayhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZQo+ID4gKmRldl9wcml2 KQo+ID4gwqAJfQo+ID4gwqB9Cj4gPiDCoAo+ID4gLXN0YXRpYyBpbnQgaTg2NV9nZXRfY2RjbGso c3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ID4gK3N0YXRpYyBpbnQgZml4ZWRf MjY2bWh6X2dldF9jZGNsayhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gPiDC oHsKPiA+IMKgCXJldHVybiAyNjY2Njc7Cj4gPiDCoH0KPiA+IEBAIC03NDg3LDcgKzc0ODcsNyBA QCBzdGF0aWMgaW50IGk4NXhfZ2V0X2NkY2xrKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlCj4gPiAq ZGV2X3ByaXYpCj4gPiDCoAlyZXR1cm4gMDsKPiA+IMKgfQo+ID4gwqAKPiA+IC1zdGF0aWMgaW50 IGk4MzBfZ2V0X2NkY2xrKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiA+ICtz dGF0aWMgaW50IGZpeGVkXzEzM21oel9nZXRfY2RjbGsoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUg KmRldl9wcml2KQo+ID4gwqB7Cj4gPiDCoAlyZXR1cm4gMTMzMzMzOwo+ID4gwqB9Cj4gPiBAQCAt MTYwOTgsMzIgKzE2MDk4LDM5IEBAIHZvaWQgaW50ZWxfaW5pdF9kaXNwbGF5X2hvb2tzKHN0cnVj dAo+ID4gZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gPiDCoAkJZGV2X3ByaXYtPmRpc3Bs YXkuZ2V0X2NkY2xrID0gaGFzd2VsbF9nZXRfY2RjbGs7Cj4gPiDCoAllbHNlIGlmIChJU19WQUxM RVlWSUVXKGRldl9wcml2KSB8fCBJU19DSEVSUllWSUVXKGRldl9wcml2KSkKPiA+IMKgCQlkZXZf cHJpdi0+ZGlzcGxheS5nZXRfY2RjbGsgPSB2YWxsZXl2aWV3X2dldF9jZGNsazsKPiA+ICsJZWxz ZSBpZiAoSVNfR0VONihkZXZfcHJpdikgfHwgSVNfSVZZQlJJREdFKGRldl9wcml2KSkKPiA+ICsJ CWRldl9wcml2LT5kaXNwbGF5LmdldF9jZGNsayA9IGZpeGVkXzQwMG1oel9nZXRfY2RjbGs7Cj4g PiDCoAllbHNlIGlmIChJU19HRU41KGRldl9wcml2KSkKPiA+IC0JCWRldl9wcml2LT5kaXNwbGF5 LmdldF9jZGNsayA9IGlsa19nZXRfY2RjbGs7Cj4gPiAtCWVsc2UgaWYgKElTX0k5NDVHKGRldl9w cml2KSB8fCBJU19JOTY1RyhkZXZfcHJpdikgfHwKPiA+IC0JCcKgSVNfR0VONihkZXZfcHJpdikg fHwgSVNfSVZZQlJJREdFKGRldl9wcml2KSkKPiA+IC0JCWRldl9wcml2LT5kaXNwbGF5LmdldF9j ZGNsayA9IGk5NDVfZ2V0X2NkY2xrOwo+ID4gKwkJZGV2X3ByaXYtPmRpc3BsYXkuZ2V0X2NkY2xr ID0gZml4ZWRfNDUwbWh6X2dldF9jZGNsazsKPiA+IMKgCWVsc2UgaWYgKElTX0dNNDUoZGV2X3By aXYpKQo+ID4gwqAJCWRldl9wcml2LT5kaXNwbGF5LmdldF9jZGNsayA9IGdtNDVfZ2V0X2NkY2xr Owo+ID4gKwllbHNlIGlmIChJU19HNFgoZGV2X3ByaXYpKQo+ID4gKwkJZGV2X3ByaXYtPmRpc3Bs YXkuZ2V0X2NkY2xrID0gZzMzX2dldF9jZGNsazsKPiA+IMKgCWVsc2UgaWYgKElTX0k5NjVHTShk ZXZfcHJpdikpCj4gPiDCoAkJZGV2X3ByaXYtPmRpc3BsYXkuZ2V0X2NkY2xrID0gaTk2NWdtX2dl dF9jZGNsazsKPiA+ICsJZWxzZSBpZiAoSVNfSTk2NUcoZGV2X3ByaXYpKQo+ID4gKwkJZGV2X3By aXYtPmRpc3BsYXkuZ2V0X2NkY2xrID0gZml4ZWRfNDAwbWh6X2dldF9jZGNsazsKPiA+IMKgCWVs c2UgaWYgKElTX1BJTkVWSUVXKGRldl9wcml2KSkKPiA+IMKgCQlkZXZfcHJpdi0+ZGlzcGxheS5n ZXRfY2RjbGsgPSBwbnZfZ2V0X2NkY2xrOwo+ID4gLQllbHNlIGlmIChJU19HMzMoZGV2X3ByaXYp IHx8IElTX0c0WChkZXZfcHJpdikpCj4gPiArCWVsc2UgaWYgKElTX0czMyhkZXZfcHJpdikpCj4g PiDCoAkJZGV2X3ByaXYtPmRpc3BsYXkuZ2V0X2NkY2xrID0gZzMzX2dldF9jZGNsazsKPiA+IC0J ZWxzZSBpZiAoSVNfSTkxNUcoZGV2X3ByaXYpKQo+ID4gLQkJZGV2X3ByaXYtPmRpc3BsYXkuZ2V0 X2NkY2xrID0gaTkxNV9nZXRfY2RjbGs7Cj4gPiAtCWVsc2UgaWYgKElTX0k5NDVHTShkZXZfcHJp dikgfHwgSVNfSTg0NUcoZGV2X3ByaXYpKQo+ID4gLQkJZGV2X3ByaXYtPmRpc3BsYXkuZ2V0X2Nk Y2xrID0gaTl4eF9taXNjX2dldF9jZGNsazsKPiA+ICsJZWxzZSBpZiAoSVNfSTk0NUdNKGRldl9w cml2KSkKPiA+ICsJCWRldl9wcml2LT5kaXNwbGF5LmdldF9jZGNsayA9IGZpeGVkXzIwMG1oel9n ZXRfY2RjbGs7Cj4gPiArCWVsc2UgaWYgKElTX0k5NDVHKGRldl9wcml2KSkKPiA+ICsJCWRldl9w cml2LT5kaXNwbGF5LmdldF9jZGNsayA9IGZpeGVkXzQwMG1oel9nZXRfY2RjbGs7Cj4gPiDCoAll bHNlIGlmIChJU19JOTE1R00oZGV2X3ByaXYpKQo+ID4gwqAJCWRldl9wcml2LT5kaXNwbGF5Lmdl dF9jZGNsayA9IGk5MTVnbV9nZXRfY2RjbGs7Cj4gPiArCWVsc2UgaWYgKElTX0k5MTVHKGRldl9w cml2KSkKPiA+ICsJCWRldl9wcml2LT5kaXNwbGF5LmdldF9jZGNsayA9IGZpeGVkXzMzM21oel9n ZXRfY2RjbGs7Cj4gPiDCoAllbHNlIGlmIChJU19JODY1RyhkZXZfcHJpdikpCj4gPiAtCQlkZXZf cHJpdi0+ZGlzcGxheS5nZXRfY2RjbGsgPSBpODY1X2dldF9jZGNsazsKPiA+ICsJCWRldl9wcml2 LT5kaXNwbGF5LmdldF9jZGNsayA9IGZpeGVkXzI2Nm1oel9nZXRfY2RjbGs7Cj4gPiDCoAllbHNl IGlmIChJU19JODVYKGRldl9wcml2KSkKPiA+IMKgCQlkZXZfcHJpdi0+ZGlzcGxheS5nZXRfY2Rj bGsgPSBpODV4X2dldF9jZGNsazsKPiA+ICsJZWxzZcKgwqBpZiAoSVNfSTg0NUcoZGV2X3ByaXYp KQo+ID4gKwkJZGV2X3ByaXYtPmRpc3BsYXkuZ2V0X2NkY2xrID0gZml4ZWRfMjAwbWh6X2dldF9j ZGNsazsKPiA+IMKgCWVsc2UgeyAvKiA4MzAgKi8KPiA+IMKgCQlXQVJOKCFJU19JODMwKGRldl9w cml2KSwgIlVua25vd24gcGxhdGZvcm0uIEFzc3VtaW5nIDEzMwo+ID4gTUh6IENEQ0xLXG4iKTsK PiA+IC0JCWRldl9wcml2LT5kaXNwbGF5LmdldF9jZGNsayA9IGk4MzBfZ2V0X2NkY2xrOwo+ID4g KwkJZGV2X3ByaXYtPmRpc3BsYXkuZ2V0X2NkY2xrID0gZml4ZWRfMTMzbWh6X2dldF9jZGNsazsK PiA+IMKgCX0KPiBJIHdvbmRlciBpZiAic3dpdGNoIChkZXZfcHJpdi0+aW5mby5wbGF0Zm9ybSki IGlzIGEgdmlhYmxlIGFsdGVybmF0aXZlCj4gdG8gc29tZSBvZiB0aGUgd29yc3QgaWYgbGFkZGVy cyB3ZSBoYXZlLCBsaWtlIHRoaXMgb25lLgoKSG93IGFib3V0IHNvbWV0aGluZyBsaWtlIHRoaXM/ CgpzdHJ1Y3QgY2RjbGtfaWZhY2UgewoJaW50ICgqZ2V0KSguLi4pOwoJdm9pZCAoKnNldCkoLi4u KTsKCWludCAoKmNhbGMpKC4uLik7CgoJaW50IGZpeGVkOwp9OwoKc3RhdGljIGludCBmaXhlZF9j ZGNsa19nZXQoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQp7CglyZXR1cm4gSU5U RUxfSU5GTyhkZXZfcHJpdiktPmNkY2xrLmZpeGVkOwp9CgojZGVmaW5lIEZJWEVEX0NEQ0xLKHZh bHVlKQlcCgl7IC5nZXQgPSBmaXhlZF9jZGNsa19nZXQsIC5maXhlZCA9IHZhbHVlIH0KCnN0cnVj dCBjZGNsa19pZmFjZSBza2xfY2RjbGsgPSB7CgkuZ2V0ID0gc2tsX2dldF9jZGNsaywKCS5zZXQg PSBza2xfc2V0X2NkY2xrLAoJLmNhbGMgPSBza2xfZ2V0X2NkY2xrLAp9OwoKLi4uCgpBbmQgdGhl biBpbiBkZXZpY2UgaW5mbyB3ZSBqdXN0IGRvIGVpdGhlcgoKwqAgLmNkY2xrID0gRklYRURfQ0RD TEsodmFsdWUpLAoKb3LCoAoKwqAgLmNkY2xrID0gc2tsX2NkY2xrLAoKQW5kZXIKCj4gCj4gQlIs Cj4gSmFuaS4KPiAKPiAKPiA+IAo+ID4gwqAKPiA+IMKgCWlmIChJU19HRU41KGRldl9wcml2KSkg ewpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1n ZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9s aXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK