From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ander Conselvan De Oliveira Subject: Re: [PATCH 04/14] drm/i915: Clean up the .get_cdclk() assignment if ladder Date: Tue, 20 Dec 2016 12:20:37 +0200 Message-ID: <1482229237.5778.15.camel@gmail.com> References: <20161219123501.3750-1-ville.syrjala@linux.intel.com> <20161219123501.3750-5-ville.syrjala@linux.intel.com> <874m1zes9z.fsf@intel.com> <1482227203.5778.11.camel@gmail.com> <87bmw6oqtq.fsf@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-pg0-x243.google.com (mail-pg0-x243.google.com [IPv6:2607:f8b0:400e:c05::243]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4823A6E938 for ; Tue, 20 Dec 2016 10:20:44 +0000 (UTC) Received: by mail-pg0-x243.google.com with SMTP id w68so5429784pgw.3 for ; Tue, 20 Dec 2016 02:20:44 -0800 (PST) In-Reply-To: <87bmw6oqtq.fsf@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Jani Nikula , ville.syrjala@linux.intel.com, intel-gfx@lists.freedesktop.org Cc: Rodrigo Vivi List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCAyMDE2LTEyLTIwIGF0IDEyOjA4ICswMjAwLCBKYW5pIE5pa3VsYSB3cm90ZToKPiBP biBUdWUsIDIwIERlYyAyMDE2LCBBbmRlciBDb25zZWx2YW4gRGUgT2xpdmVpcmEgPGNvbnNlbHZh bjJAZ21haWwuY29tPiB3cm90ZToKPiA+IAo+ID4gT24gTW9uLCAyMDE2LTEyLTE5IGF0IDE5OjM1 ICswMjAwLCBKYW5pIE5pa3VsYSB3cm90ZToKPiA+ID4gCj4gPiA+IE9uIE1vbiwgMTkgRGVjIDIw MTYsIHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tIHdyb3RlOgo+ID4gPiA+IAo+ID4gPiA+ IAo+ID4gPiA+IEZyb206IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRl bC5jb20+Cj4gPiA+ID4gCj4gPiA+ID4gTGV0J3MgY2xlYW4gdXAgdGhlIG1lc3Mgd2UgaGF2ZSBp biB0aGUgaWYgbGFkZGVyIHRoYXQgYXNzaWducyB0aGUKPiA+ID4gPiAuZ2V0X2NkY2xrKCkgaG9v a3MuIFRoZSBncm91cGluZyBvZiB0aGUgcGxhdGZvcm1zIGJ5IHRoZSBmdW5jdGlvbgo+ID4gPiA+ IHJlc3VsdHMgaW4gYSB0aGluZyB0aGF0J3Mgbm90IHJlYWxseSBsZWdpYmxlLCBzbyBsZXQncyBk byBpdCB0aGUKPiA+ID4gPiBvdGhlciB3YXkgYXJvdW5kIGFuZCBvcmRlciB0aGUgaWYgbGFkZGVy IGJ5IHBsYXRmb3JtIGFuZCBkdXBsaWNhdGUKPiA+ID4gPiB3aGF0ZXZlciBhc3NpZ25tZW50cyB3 ZSBuZWVkLgo+ID4gPiA+IAo+ID4gPiA+IFRvIGZ1cnRoZXIgYXZvaWQgY29uZnVzaW9uIHdpdGgg dGhlIGZ1bmN0aW9uIG5hbWVzIGxldCdzIHJlbmFtZQo+ID4gPiA+IHRoZW0gdG8ganVzdCBmaXhl ZF88ZnJlcT5fZ2V0X2NkY2xrKCkuIFRoZSBvdGhlciBvcHRpb24gd291bGQKPiA+ID4gPiBiZSB0 byBkdXBsaWNhdGUgdGhlIGZ1bmN0aW9ucyBlbnRpcmVseSBidXQgaXQgc2VlbXMgcXVpdGUKPiA+ ID4gPiBwb2ludGxlc3MgdG8gZG8gdGhhdCBzaW5jZSBlYWNoIG9uZSBqdXN0IHJldHVybnMgYSBm aXhlZCB2YWx1ZS4KPiA+ID4gPiAKPiA+ID4gPiBTaWduZWQtb2ZmLWJ5OiBWaWxsZSBTeXJqw6Rs w6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPgo+ID4gPiA+IC0tLQo+ID4gPiA+IMKg ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jIHwgNDEgKysrKysrKysrKysrKysr KysrKysrLS0tLS0tCj4gPiA+ID4gLS0tLQo+ID4gPiA+IC0tLS0tCj4gPiA+ID4gwqAxIGZpbGUg Y2hhbmdlZCwgMjQgaW5zZXJ0aW9ucygrKSwgMTcgZGVsZXRpb25zKC0pCj4gPiA+ID4gCj4gPiA+ ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+ID4g PiA+IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gPiA+ID4gaW5kZXgg YmJmZWYzNDg3ODNiLi4yOWY5MWU3OTkyNzIgMTAwNjQ0Cj4gPiA+ID4gLS0tIGEvZHJpdmVycy9n cHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gPiA+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJt L2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gPiA+ID4gQEAgLTczNzksMjIgKzczNzksMjIgQEAgc3Rh dGljIGludCB2YWxsZXl2aWV3X2dldF9jZGNsayhzdHJ1Y3QKPiA+ID4gPiBkcm1faTkxNV9wcml2 YXRlICpkZXZfcHJpdikKPiA+ID4gPiDCoAkJCQnCoMKgwqDCoMKgwqBDQ0tfRElTUExBWV9DTE9D S19DT05UUk9MKTsKPiA+ID4gPiDCoH0KPiA+ID4gPiDCoAo+ID4gPiA+IC1zdGF0aWMgaW50IGls a19nZXRfY2RjbGsoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ID4gPiA+ICtz dGF0aWMgaW50IGZpeGVkXzQ1MG1oel9nZXRfY2RjbGsoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUg KmRldl9wcml2KQo+ID4gPiA+IMKgewo+ID4gPiA+IMKgCXJldHVybiA0NTAwMDA7Cj4gPiA+ID4g wqB9Cj4gPiA+ID4gwqAKPiA+ID4gPiAtc3RhdGljIGludCBpOTQ1X2dldF9jZGNsayhzdHJ1Y3Qg ZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gPiA+ID4gK3N0YXRpYyBpbnQgZml4ZWRfNDAw bWh6X2dldF9jZGNsayhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gPiA+ID4g wqB7Cj4gPiA+ID4gwqAJcmV0dXJuIDQwMDAwMDsKPiA+ID4gPiDCoH0KPiA+ID4gPiDCoAo+ID4g PiA+IC1zdGF0aWMgaW50IGk5MTVfZ2V0X2NkY2xrKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpk ZXZfcHJpdikKPiA+ID4gPiArc3RhdGljIGludCBmaXhlZF8zMzNtaHpfZ2V0X2NkY2xrKHN0cnVj dCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiA+ID4gPiDCoHsKPiA+ID4gPiDCoAlyZXR1 cm4gMzMzMzMzOwo+ID4gPiA+IMKgfQo+ID4gPiA+IMKgCj4gPiA+ID4gLXN0YXRpYyBpbnQgaTl4 eF9taXNjX2dldF9jZGNsayhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gPiA+ ID4gK3N0YXRpYyBpbnQgZml4ZWRfMjAwbWh6X2dldF9jZGNsayhzdHJ1Y3QgZHJtX2k5MTVfcHJp dmF0ZSAqZGV2X3ByaXYpCj4gPiA+ID4gwqB7Cj4gPiA+ID4gwqAJcmV0dXJuIDIwMDAwMDsKPiA+ ID4gPiDCoH0KPiA+ID4gPiBAQCAtNzQ0NCw3ICs3NDQ0LDcgQEAgc3RhdGljIGludCBpOTE1Z21f Z2V0X2NkY2xrKHN0cnVjdAo+ID4gPiA+IGRybV9pOTE1X3ByaXZhdGUKPiA+ID4gPiAqZGV2X3By aXYpCj4gPiA+ID4gwqAJfQo+ID4gPiA+IMKgfQo+ID4gPiA+IMKgCj4gPiA+ID4gLXN0YXRpYyBp bnQgaTg2NV9nZXRfY2RjbGsoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ID4g PiA+ICtzdGF0aWMgaW50IGZpeGVkXzI2Nm1oel9nZXRfY2RjbGsoc3RydWN0IGRybV9pOTE1X3By aXZhdGUgKmRldl9wcml2KQo+ID4gPiA+IMKgewo+ID4gPiA+IMKgCXJldHVybiAyNjY2Njc7Cj4g PiA+ID4gwqB9Cj4gPiA+ID4gQEAgLTc0ODcsNyArNzQ4Nyw3IEBAIHN0YXRpYyBpbnQgaTg1eF9n ZXRfY2RjbGsoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUKPiA+ID4gPiAqZGV2X3ByaXYpCj4gPiA+ ID4gwqAJcmV0dXJuIDA7Cj4gPiA+ID4gwqB9Cj4gPiA+ID4gwqAKPiA+ID4gPiAtc3RhdGljIGlu dCBpODMwX2dldF9jZGNsayhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gPiA+ ID4gK3N0YXRpYyBpbnQgZml4ZWRfMTMzbWh6X2dldF9jZGNsayhzdHJ1Y3QgZHJtX2k5MTVfcHJp dmF0ZSAqZGV2X3ByaXYpCj4gPiA+ID4gwqB7Cj4gPiA+ID4gwqAJcmV0dXJuIDEzMzMzMzsKPiA+ ID4gPiDCoH0KPiA+ID4gPiBAQCAtMTYwOTgsMzIgKzE2MDk4LDM5IEBAIHZvaWQgaW50ZWxfaW5p dF9kaXNwbGF5X2hvb2tzKHN0cnVjdAo+ID4gPiA+IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2 KQo+ID4gPiA+IMKgCQlkZXZfcHJpdi0+ZGlzcGxheS5nZXRfY2RjbGsgPSBoYXN3ZWxsX2dldF9j ZGNsazsKPiA+ID4gPiDCoAllbHNlIGlmIChJU19WQUxMRVlWSUVXKGRldl9wcml2KSB8fCBJU19D SEVSUllWSUVXKGRldl9wcml2KSkKPiA+ID4gPiDCoAkJZGV2X3ByaXYtPmRpc3BsYXkuZ2V0X2Nk Y2xrID0gdmFsbGV5dmlld19nZXRfY2RjbGs7Cj4gPiA+ID4gKwllbHNlIGlmIChJU19HRU42KGRl dl9wcml2KSB8fCBJU19JVllCUklER0UoZGV2X3ByaXYpKQo+ID4gPiA+ICsJCWRldl9wcml2LT5k aXNwbGF5LmdldF9jZGNsayA9IGZpeGVkXzQwMG1oel9nZXRfY2RjbGs7Cj4gPiA+ID4gwqAJZWxz ZSBpZiAoSVNfR0VONShkZXZfcHJpdikpCj4gPiA+ID4gLQkJZGV2X3ByaXYtPmRpc3BsYXkuZ2V0 X2NkY2xrID0gaWxrX2dldF9jZGNsazsKPiA+ID4gPiAtCWVsc2UgaWYgKElTX0k5NDVHKGRldl9w cml2KSB8fCBJU19JOTY1RyhkZXZfcHJpdikgfHwKPiA+ID4gPiAtCQnCoElTX0dFTjYoZGV2X3By aXYpIHx8IElTX0lWWUJSSURHRShkZXZfcHJpdikpCj4gPiA+ID4gLQkJZGV2X3ByaXYtPmRpc3Bs YXkuZ2V0X2NkY2xrID0gaTk0NV9nZXRfY2RjbGs7Cj4gPiA+ID4gKwkJZGV2X3ByaXYtPmRpc3Bs YXkuZ2V0X2NkY2xrID0gZml4ZWRfNDUwbWh6X2dldF9jZGNsazsKPiA+ID4gPiDCoAllbHNlIGlm IChJU19HTTQ1KGRldl9wcml2KSkKPiA+ID4gPiDCoAkJZGV2X3ByaXYtPmRpc3BsYXkuZ2V0X2Nk Y2xrID0gZ200NV9nZXRfY2RjbGs7Cj4gPiA+ID4gKwllbHNlIGlmIChJU19HNFgoZGV2X3ByaXYp KQo+ID4gPiA+ICsJCWRldl9wcml2LT5kaXNwbGF5LmdldF9jZGNsayA9IGczM19nZXRfY2RjbGs7 Cj4gPiA+ID4gwqAJZWxzZSBpZiAoSVNfSTk2NUdNKGRldl9wcml2KSkKPiA+ID4gPiDCoAkJZGV2 X3ByaXYtPmRpc3BsYXkuZ2V0X2NkY2xrID0gaTk2NWdtX2dldF9jZGNsazsKPiA+ID4gPiArCWVs c2UgaWYgKElTX0k5NjVHKGRldl9wcml2KSkKPiA+ID4gPiArCQlkZXZfcHJpdi0+ZGlzcGxheS5n ZXRfY2RjbGsgPSBmaXhlZF80MDBtaHpfZ2V0X2NkY2xrOwo+ID4gPiA+IMKgCWVsc2UgaWYgKElT X1BJTkVWSUVXKGRldl9wcml2KSkKPiA+ID4gPiDCoAkJZGV2X3ByaXYtPmRpc3BsYXkuZ2V0X2Nk Y2xrID0gcG52X2dldF9jZGNsazsKPiA+ID4gPiAtCWVsc2UgaWYgKElTX0czMyhkZXZfcHJpdikg fHwgSVNfRzRYKGRldl9wcml2KSkKPiA+ID4gPiArCWVsc2UgaWYgKElTX0czMyhkZXZfcHJpdikp Cj4gPiA+ID4gwqAJCWRldl9wcml2LT5kaXNwbGF5LmdldF9jZGNsayA9IGczM19nZXRfY2RjbGs7 Cj4gPiA+ID4gLQllbHNlIGlmIChJU19JOTE1RyhkZXZfcHJpdikpCj4gPiA+ID4gLQkJZGV2X3By aXYtPmRpc3BsYXkuZ2V0X2NkY2xrID0gaTkxNV9nZXRfY2RjbGs7Cj4gPiA+ID4gLQllbHNlIGlm IChJU19JOTQ1R00oZGV2X3ByaXYpIHx8IElTX0k4NDVHKGRldl9wcml2KSkKPiA+ID4gPiAtCQlk ZXZfcHJpdi0+ZGlzcGxheS5nZXRfY2RjbGsgPSBpOXh4X21pc2NfZ2V0X2NkY2xrOwo+ID4gPiA+ ICsJZWxzZSBpZiAoSVNfSTk0NUdNKGRldl9wcml2KSkKPiA+ID4gPiArCQlkZXZfcHJpdi0+ZGlz cGxheS5nZXRfY2RjbGsgPSBmaXhlZF8yMDBtaHpfZ2V0X2NkY2xrOwo+ID4gPiA+ICsJZWxzZSBp ZiAoSVNfSTk0NUcoZGV2X3ByaXYpKQo+ID4gPiA+ICsJCWRldl9wcml2LT5kaXNwbGF5LmdldF9j ZGNsayA9IGZpeGVkXzQwMG1oel9nZXRfY2RjbGs7Cj4gPiA+ID4gwqAJZWxzZSBpZiAoSVNfSTkx NUdNKGRldl9wcml2KSkKPiA+ID4gPiDCoAkJZGV2X3ByaXYtPmRpc3BsYXkuZ2V0X2NkY2xrID0g aTkxNWdtX2dldF9jZGNsazsKPiA+ID4gPiArCWVsc2UgaWYgKElTX0k5MTVHKGRldl9wcml2KSkK PiA+ID4gPiArCQlkZXZfcHJpdi0+ZGlzcGxheS5nZXRfY2RjbGsgPSBmaXhlZF8zMzNtaHpfZ2V0 X2NkY2xrOwo+ID4gPiA+IMKgCWVsc2UgaWYgKElTX0k4NjVHKGRldl9wcml2KSkKPiA+ID4gPiAt CQlkZXZfcHJpdi0+ZGlzcGxheS5nZXRfY2RjbGsgPSBpODY1X2dldF9jZGNsazsKPiA+ID4gPiAr CQlkZXZfcHJpdi0+ZGlzcGxheS5nZXRfY2RjbGsgPSBmaXhlZF8yNjZtaHpfZ2V0X2NkY2xrOwo+ ID4gPiA+IMKgCWVsc2UgaWYgKElTX0k4NVgoZGV2X3ByaXYpKQo+ID4gPiA+IMKgCQlkZXZfcHJp di0+ZGlzcGxheS5nZXRfY2RjbGsgPSBpODV4X2dldF9jZGNsazsKPiA+ID4gPiArCWVsc2XCoMKg aWYgKElTX0k4NDVHKGRldl9wcml2KSkKPiA+ID4gPiArCQlkZXZfcHJpdi0+ZGlzcGxheS5nZXRf Y2RjbGsgPSBmaXhlZF8yMDBtaHpfZ2V0X2NkY2xrOwo+ID4gPiA+IMKgCWVsc2UgeyAvKiA4MzAg Ki8KPiA+ID4gPiDCoAkJV0FSTighSVNfSTgzMChkZXZfcHJpdiksICJVbmtub3duIHBsYXRmb3Jt LiBBc3N1bWluZwo+ID4gPiA+IDEzMwo+ID4gPiA+IE1IeiBDRENMS1xuIik7Cj4gPiA+ID4gLQkJ ZGV2X3ByaXYtPmRpc3BsYXkuZ2V0X2NkY2xrID0gaTgzMF9nZXRfY2RjbGs7Cj4gPiA+ID4gKwkJ ZGV2X3ByaXYtPmRpc3BsYXkuZ2V0X2NkY2xrID0gZml4ZWRfMTMzbWh6X2dldF9jZGNsazsKPiA+ ID4gPiDCoAl9Cj4gPiA+IEkgd29uZGVyIGlmICJzd2l0Y2ggKGRldl9wcml2LT5pbmZvLnBsYXRm b3JtKSIgaXMgYSB2aWFibGUgYWx0ZXJuYXRpdmUKPiA+ID4gdG8gc29tZSBvZiB0aGUgd29yc3Qg aWYgbGFkZGVycyB3ZSBoYXZlLCBsaWtlIHRoaXMgb25lLgo+ID4gSG93IGFib3V0IHNvbWV0aGlu ZyBsaWtlIHRoaXM/Cj4gSSBsaWtlIHRoaXMsIGJ1dCBwcm9iYWJseSB0b28gaW50cnVzaXZlIHRv IGFzayBWaWxsZSB0byBwdXQgdGhpcyBpbgo+IG1pZC1zZXJpZXMuIEEgdXNlZnVsIGNsZWFudXAg YWZ0ZXJ3YXJkcz8KCkkgYWdyZWUuIEkgY2FuIGV2ZW4gdm9sdW50ZWVyIHRvIGRvIGl0IGFmdGVy IFZpbGxlJ3MgcGF0Y2hlcyBsYW5kLgoKQW5kZXIKCj4gCj4gQlIsCj4gSmFuaS4KPiAKPiAKPiA+ IAo+ID4gCj4gPiBzdHJ1Y3QgY2RjbGtfaWZhY2Ugewo+ID4gCWludCAoKmdldCkoLi4uKTsKPiA+ IAl2b2lkICgqc2V0KSguLi4pOwo+ID4gCWludCAoKmNhbGMpKC4uLik7Cj4gPiAKPiA+IAlpbnQg Zml4ZWQ7Cj4gPiB9Owo+ID4gCj4gPiBzdGF0aWMgaW50IGZpeGVkX2NkY2xrX2dldChzdHJ1Y3Qg ZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gPiB7Cj4gPiAJcmV0dXJuIElOVEVMX0lORk8o ZGV2X3ByaXYpLT5jZGNsay5maXhlZDsKPiA+IH0KPiA+IAo+ID4gI2RlZmluZSBGSVhFRF9DRENM Syh2YWx1ZSkJXAo+ID4gCXsgLmdldCA9IGZpeGVkX2NkY2xrX2dldCwgLmZpeGVkID0gdmFsdWUg fQo+ID4gCj4gPiBzdHJ1Y3QgY2RjbGtfaWZhY2Ugc2tsX2NkY2xrID0gewo+ID4gCS5nZXQgPSBz a2xfZ2V0X2NkY2xrLAo+ID4gCS5zZXQgPSBza2xfc2V0X2NkY2xrLAo+ID4gCS5jYWxjID0gc2ts X2dldF9jZGNsaywKPiA+IH07Cj4gPiAKPiA+IC4uLgo+ID4gCj4gPiBBbmQgdGhlbiBpbiBkZXZp Y2UgaW5mbyB3ZSBqdXN0IGRvIGVpdGhlcgo+ID4gCj4gPiDCoCAuY2RjbGsgPSBGSVhFRF9DRENM Syh2YWx1ZSksCj4gPiAKPiA+IG9ywqAKPiA+IAo+ID4gwqAgLmNkY2xrID0gc2tsX2NkY2xrLAo+ ID4gCj4gPiBBbmRlcgo+ID4gCj4gPiA+IAo+ID4gPiAKPiA+ID4gQlIsCj4gPiA+IEphbmkuCj4g PiA+IAo+ID4gPiAKPiA+ID4gPiAKPiA+ID4gPiAKPiA+ID4gPiDCoAo+ID4gPiA+IMKgCWlmIChJ U19HRU41KGRldl9wcml2KSkgewpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVz a3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9p bnRlbC1nZngK