From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ander Conselvan De Oliveira <conselvan2@gmail.com>
Subject: Re: [PATCH 04/14] drm/i915: Clean up the .get_cdclk()
 assignment if ladder
Date: Tue, 20 Dec 2016 15:42:16 +0200
Message-ID: <1482241336.5778.31.camel@gmail.com>
References: <20161219172840.31842-1-ville.syrjala@linux.intel.com>
 <20161219172840.31842-5-ville.syrjala@linux.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mail-pf0-x241.google.com (mail-pf0-x241.google.com
 [IPv6:2607:f8b0:400e:c00::241])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 068D06E0E9
 for <intel-gfx@lists.freedesktop.org>; Tue, 20 Dec 2016 13:43:38 +0000 (UTC)
Received: by mail-pf0-x241.google.com with SMTP id 144so9066239pfv.0
 for <intel-gfx@lists.freedesktop.org>; Tue, 20 Dec 2016 05:43:38 -0800 (PST)
In-Reply-To: <20161219172840.31842-5-ville.syrjala@linux.intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: ville.syrjala@linux.intel.com, intel-gfx@lists.freedesktop.org, Jani Nikula <jani.nikula@linux.intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
List-Id: intel-gfx@lists.freedesktop.org

T24gTW9uLCAyMDE2LTEyLTE5IGF0IDE5OjI4ICswMjAwLCB2aWxsZS5zeXJqYWxhQGxpbnV4Lmlu
dGVsLmNvbSB3cm90ZToKPiBGcm9tOiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGlu
dXguaW50ZWwuY29tPgo+IAo+IExldCdzIGNsZWFuIHVwIHRoZSBtZXNzIHdlIGhhdmUgaW4gdGhl
IGlmIGxhZGRlciB0aGF0IGFzc2lnbnMgdGhlCj4gLmdldF9jZGNsaygpIGhvb2tzLiBUaGUgZ3Jv
dXBpbmcgb2YgdGhlIHBsYXRmb3JtcyBieSB0aGUgZnVuY3Rpb24KPiByZXN1bHRzIGluIGEgdGhp
bmcgdGhhdCdzIG5vdCByZWFsbHkgbGVnaWJsZSwgc28gbGV0J3MgZG8gaXQgdGhlCj4gb3RoZXIg
d2F5IGFyb3VuZCBhbmQgb3JkZXIgdGhlIGlmIGxhZGRlciBieSBwbGF0Zm9ybSBhbmQgZHVwbGlj
YXRlCj4gd2hhdGV2ZXIgYXNzaWdubWVudHMgd2UgbmVlZC4KPiAKPiBUbyBmdXJ0aGVyIGF2b2lk
IGNvbmZ1c2lvbiB3aXRoIHRoZSBmdW5jdGlvbiBuYW1lcyBsZXQncyByZW5hbWUKPiB0aGVtIHRv
IGp1c3QgZml4ZWRfPGZyZXE+X2dldF9jZGNsaygpLiBUaGUgb3RoZXIgb3B0aW9uIHdvdWxkCj4g
YmUgdG8gZHVwbGljYXRlIHRoZSBmdW5jdGlvbnMgZW50aXJlbHkgYnV0IGl0IHNlZW1zIHF1aXRl
Cj4gcG9pbnRsZXNzIHRvIGRvIHRoYXQgc2luY2UgZWFjaCBvbmUganVzdCByZXR1cm5zIGEgZml4
ZWQgdmFsdWUuCj4gCj4gU2lnbmVkLW9mZi1ieTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJq
YWxhQGxpbnV4LmludGVsLmNvbT4KPiAtLS0KPiDCoGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs
X2Rpc3BsYXkuYyB8IDQxICsrKysrKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLQo+IC0tLQo+
IMKgMSBmaWxlIGNoYW5nZWQsIDI0IGluc2VydGlvbnMoKyksIDE3IGRlbGV0aW9ucygtKQo+IAo+
IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPiBiL2Ry
aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+IGluZGV4IGJiZmVmMzQ4NzgzYi4u
MjlmOTFlNzk5MjcyIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rp
c3BsYXkuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+IEBA
IC03Mzc5LDIyICs3Mzc5LDIyIEBAIHN0YXRpYyBpbnQgdmFsbGV5dmlld19nZXRfY2RjbGsoc3Ry
dWN0Cj4gZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gwqAJCQkJwqDCoMKgwqDCoMKgQ0NL
X0RJU1BMQVlfQ0xPQ0tfQ09OVFJPTCk7Cj4gwqB9Cj4gwqAKPiAtc3RhdGljIGludCBpbGtfZ2V0
X2NkY2xrKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiArc3RhdGljIGludCBm
aXhlZF80NTBtaHpfZ2V0X2NkY2xrKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikK
PiDCoHsKPiDCoAlyZXR1cm4gNDUwMDAwOwo+IMKgfQo+IMKgCj4gLXN0YXRpYyBpbnQgaTk0NV9n
ZXRfY2RjbGsoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ICtzdGF0aWMgaW50
IGZpeGVkXzQwMG1oel9nZXRfY2RjbGsoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2
KQo+IMKgewo+IMKgCXJldHVybiA0MDAwMDA7Cj4gwqB9Cj4gwqAKPiAtc3RhdGljIGludCBpOTE1
X2dldF9jZGNsayhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gK3N0YXRpYyBp
bnQgZml4ZWRfMzMzbWh6X2dldF9jZGNsayhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3By
aXYpCj4gwqB7Cj4gwqAJcmV0dXJuIDMzMzMzMzsKPiDCoH0KPiDCoAo+IC1zdGF0aWMgaW50IGk5
eHhfbWlzY19nZXRfY2RjbGsoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ICtz
dGF0aWMgaW50IGZpeGVkXzIwMG1oel9nZXRfY2RjbGsoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUg
KmRldl9wcml2KQo+IMKgewo+IMKgCXJldHVybiAyMDAwMDA7Cj4gwqB9Cj4gQEAgLTc0NDQsNyAr
NzQ0NCw3IEBAIHN0YXRpYyBpbnQgaTkxNWdtX2dldF9jZGNsayhzdHJ1Y3QgZHJtX2k5MTVfcHJp
dmF0ZQo+ICpkZXZfcHJpdikKPiDCoAl9Cj4gwqB9Cj4gwqAKPiAtc3RhdGljIGludCBpODY1X2dl
dF9jZGNsayhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gK3N0YXRpYyBpbnQg
Zml4ZWRfMjY2bWh6X2dldF9jZGNsayhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYp
Cj4gwqB7Cj4gwqAJcmV0dXJuIDI2NjY2NzsKPiDCoH0KPiBAQCAtNzQ4Nyw3ICs3NDg3LDcgQEAg
c3RhdGljIGludCBpODV4X2dldF9jZGNsayhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZQo+ICpkZXZf
cHJpdikKPiDCoAlyZXR1cm4gMDsKPiDCoH0KPiDCoAo+IC1zdGF0aWMgaW50IGk4MzBfZ2V0X2Nk
Y2xrKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiArc3RhdGljIGludCBmaXhl
ZF8xMzNtaHpfZ2V0X2NkY2xrKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiDC
oHsKPiDCoAlyZXR1cm4gMTMzMzMzOwo+IMKgfQo+IEBAIC0xNjA5OCwzMiArMTYwOTgsMzkgQEAg
dm9pZCBpbnRlbF9pbml0X2Rpc3BsYXlfaG9va3Moc3RydWN0Cj4gZHJtX2k5MTVfcHJpdmF0ZSAq
ZGV2X3ByaXYpCj4gwqAJCWRldl9wcml2LT5kaXNwbGF5LmdldF9jZGNsayA9IGhhc3dlbGxfZ2V0
X2NkY2xrOwo+IMKgCWVsc2UgaWYgKElTX1ZBTExFWVZJRVcoZGV2X3ByaXYpIHx8IElTX0NIRVJS
WVZJRVcoZGV2X3ByaXYpKQo+IMKgCQlkZXZfcHJpdi0+ZGlzcGxheS5nZXRfY2RjbGsgPSB2YWxs
ZXl2aWV3X2dldF9jZGNsazsKPiArCWVsc2UgaWYgKElTX0dFTjYoZGV2X3ByaXYpIHx8IElTX0lW
WUJSSURHRShkZXZfcHJpdikpCj4gKwkJZGV2X3ByaXYtPmRpc3BsYXkuZ2V0X2NkY2xrID0gZml4
ZWRfNDAwbWh6X2dldF9jZGNsazsKPiDCoAllbHNlIGlmIChJU19HRU41KGRldl9wcml2KSkKPiAt
CQlkZXZfcHJpdi0+ZGlzcGxheS5nZXRfY2RjbGsgPSBpbGtfZ2V0X2NkY2xrOwo+IC0JZWxzZSBp
ZiAoSVNfSTk0NUcoZGV2X3ByaXYpIHx8IElTX0k5NjVHKGRldl9wcml2KSB8fAo+IC0JCcKgSVNf
R0VONihkZXZfcHJpdikgfHwgSVNfSVZZQlJJREdFKGRldl9wcml2KSkKPiAtCQlkZXZfcHJpdi0+
ZGlzcGxheS5nZXRfY2RjbGsgPSBpOTQ1X2dldF9jZGNsazsKPiArCQlkZXZfcHJpdi0+ZGlzcGxh
eS5nZXRfY2RjbGsgPSBmaXhlZF80NTBtaHpfZ2V0X2NkY2xrOwo+IMKgCWVsc2UgaWYgKElTX0dN
NDUoZGV2X3ByaXYpKQo+IMKgCQlkZXZfcHJpdi0+ZGlzcGxheS5nZXRfY2RjbGsgPSBnbTQ1X2dl
dF9jZGNsazsKPiArCWVsc2UgaWYgKElTX0c0WChkZXZfcHJpdikpCj4gKwkJZGV2X3ByaXYtPmRp
c3BsYXkuZ2V0X2NkY2xrID0gZzMzX2dldF9jZGNsazsKPiDCoAllbHNlIGlmIChJU19JOTY1R00o
ZGV2X3ByaXYpKQo+IMKgCQlkZXZfcHJpdi0+ZGlzcGxheS5nZXRfY2RjbGsgPSBpOTY1Z21fZ2V0
X2NkY2xrOwo+ICsJZWxzZSBpZiAoSVNfSTk2NUcoZGV2X3ByaXYpKQo+ICsJCWRldl9wcml2LT5k
aXNwbGF5LmdldF9jZGNsayA9IGZpeGVkXzQwMG1oel9nZXRfY2RjbGs7Cj4gwqAJZWxzZSBpZiAo
SVNfUElORVZJRVcoZGV2X3ByaXYpKQo+IMKgCQlkZXZfcHJpdi0+ZGlzcGxheS5nZXRfY2RjbGsg
PSBwbnZfZ2V0X2NkY2xrOwo+IC0JZWxzZSBpZiAoSVNfRzMzKGRldl9wcml2KSB8fCBJU19HNFgo
ZGV2X3ByaXYpKQo+ICsJZWxzZSBpZiAoSVNfRzMzKGRldl9wcml2KSkKPiDCoAkJZGV2X3ByaXYt
PmRpc3BsYXkuZ2V0X2NkY2xrID0gZzMzX2dldF9jZGNsazsKPiAtCWVsc2UgaWYgKElTX0k5MTVH
KGRldl9wcml2KSkKPiAtCQlkZXZfcHJpdi0+ZGlzcGxheS5nZXRfY2RjbGsgPSBpOTE1X2dldF9j
ZGNsazsKPiAtCWVsc2UgaWYgKElTX0k5NDVHTShkZXZfcHJpdikgfHwgSVNfSTg0NUcoZGV2X3By
aXYpKQo+IC0JCWRldl9wcml2LT5kaXNwbGF5LmdldF9jZGNsayA9IGk5eHhfbWlzY19nZXRfY2Rj
bGs7Cj4gKwllbHNlIGlmIChJU19JOTQ1R00oZGV2X3ByaXYpKQo+ICsJCWRldl9wcml2LT5kaXNw
bGF5LmdldF9jZGNsayA9IGZpeGVkXzIwMG1oel9nZXRfY2RjbGs7Cj4gKwllbHNlIGlmIChJU19J
OTQ1RyhkZXZfcHJpdikpCj4gKwkJZGV2X3ByaXYtPmRpc3BsYXkuZ2V0X2NkY2xrID0gZml4ZWRf
NDAwbWh6X2dldF9jZGNsazsKPiDCoAllbHNlIGlmIChJU19JOTE1R00oZGV2X3ByaXYpKQo+IMKg
CQlkZXZfcHJpdi0+ZGlzcGxheS5nZXRfY2RjbGsgPSBpOTE1Z21fZ2V0X2NkY2xrOwo+ICsJZWxz
ZSBpZiAoSVNfSTkxNUcoZGV2X3ByaXYpKQo+ICsJCWRldl9wcml2LT5kaXNwbGF5LmdldF9jZGNs
ayA9IGZpeGVkXzMzM21oel9nZXRfY2RjbGs7Cj4gwqAJZWxzZSBpZiAoSVNfSTg2NUcoZGV2X3By
aXYpKQo+IC0JCWRldl9wcml2LT5kaXNwbGF5LmdldF9jZGNsayA9IGk4NjVfZ2V0X2NkY2xrOwo+
ICsJCWRldl9wcml2LT5kaXNwbGF5LmdldF9jZGNsayA9IGZpeGVkXzI2Nm1oel9nZXRfY2RjbGs7
Cj4gwqAJZWxzZSBpZiAoSVNfSTg1WChkZXZfcHJpdikpCj4gwqAJCWRldl9wcml2LT5kaXNwbGF5
LmdldF9jZGNsayA9IGk4NXhfZ2V0X2NkY2xrOwo+ICsJZWxzZcKgwqBpZiAoSVNfSTg0NUcoZGV2
X3ByaXYpKQo+ICsJCWRldl9wcml2LT5kaXNwbGF5LmdldF9jZGNsayA9IGZpeGVkXzIwMG1oel9n
ZXRfY2RjbGs7Cj4gwqAJZWxzZSB7IC8qIDgzMCAqLwo+IMKgCQlXQVJOKCFJU19JODMwKGRldl9w
cml2KSwgIlVua25vd24gcGxhdGZvcm0uIEFzc3VtaW5nIDEzMyBNSHoKPiBDRENMS1xuIik7Cj4g
LQkJZGV2X3ByaXYtPmRpc3BsYXkuZ2V0X2NkY2xrID0gaTgzMF9nZXRfY2RjbGs7Cj4gKwkJZGV2
X3ByaXYtPmRpc3BsYXkuZ2V0X2NkY2xrID0gZml4ZWRfMTMzbWh6X2dldF9jZGNsazsKPiDCoAl9
Cj4gwqAKPiDCoAlpZiAoSVNfR0VONShkZXZfcHJpdikpIHsKCkkgdGhpbmsgdGhpcyBpcyBhIHdv
cnRod2hpbGUgcGF0Y2ggZXZlbiBpZiB3ZSBhcmUgZG9pbmcgdGhlIGltcHJvdmVtZW50cwpkaXNj
dXNzZWQgaW4gdGhlIHYxIHRocmVhZCwgc28KClJldmlld2VkLWJ5OiBBbmRlciBDb25zZWx2YW4g
ZGUgT2xpdmVpcmEgPGNvbnNlbHZhbjJAZ21haWwuY29tPgoKX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1n
ZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21h
aWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==