From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ander Conselvan De Oliveira Subject: Re: [PATCH v2 07/14] drm/i915: Start moving the cdclk stuff into a distinct state structure Date: Fri, 23 Dec 2016 15:07:25 +0200 Message-ID: <1482498445.2633.49.camel@gmail.com> References: <20161219172840.31842-1-ville.syrjala@linux.intel.com> <20161219172840.31842-8-ville.syrjala@linux.intel.com> <1482416080.4759.61.camel@gmail.com> <20161222143348.GO31595@intel.com> <1482484162.2633.20.camel@gmail.com> <20161223122752.GR31595@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-pf0-x241.google.com (mail-pf0-x241.google.com [IPv6:2607:f8b0:400e:c00::241]) by gabe.freedesktop.org (Postfix) with ESMTPS id E179D6E005 for ; Fri, 23 Dec 2016 13:07:36 +0000 (UTC) Received: by mail-pf0-x241.google.com with SMTP id c4so13977072pfb.3 for ; Fri, 23 Dec 2016 05:07:36 -0800 (PST) In-Reply-To: <20161223122752.GR31595@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ville =?ISO-8859-1?Q?Syrj=E4l=E4?= Cc: intel-gfx@lists.freedesktop.org, Rodrigo Vivi List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCAyMDE2LTEyLTIzIGF0IDE0OjI3ICswMjAwLCBWaWxsZSBTeXJqw6Rsw6Qgd3JvdGU6 Cj4gT24gRnJpLCBEZWMgMjMsIDIwMTYgYXQgMTE6MDk6MjJBTSArMDIwMCwgQW5kZXIgQ29uc2Vs dmFuIERlIE9saXZlaXJhIHdyb3RlOgo+ID4gCj4gPiBPbiBUaHUsIDIwMTYtMTItMjIgYXQgMTY6 MzMgKzAyMDAsIFZpbGxlIFN5cmrDpGzDpCB3cm90ZToKPiA+ID4gCj4gPiA+IE9uIFRodSwgRGVj IDIyLCAyMDE2IGF0IDA0OjE0OjQwUE0gKzAyMDAsIEFuZGVyIENvbnNlbHZhbiBEZSBPbGl2ZWly YQo+ID4gPiB3cm90ZToKPiA+ID4gPiAKPiA+ID4gPiAKPiA+ID4gPiBPbiBNb24sIDIwMTYtMTIt MTkgYXQgMTk6MjggKzAyMDAsIHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tIHdyb3RlOgo+ ID4gPiA+ID4gCj4gPiA+ID4gPiAKPiA+ID4gPiA+IEZyb206IFZpbGxlIFN5cmrDpGzDpCA8dmls bGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4gPiA+ID4gPiAKPiA+ID4gPiA+IEludHJvZHVj ZSBpbnRlbF9jZGNsayBzdGF0ZSB3aGljaCBmb3Igbm93IHdpbGwgdHJhY2sgdGhlIGNkY2xrCj4g PiA+ID4gPiBmcmVxdWVuY3ksIHRoZSB2Y28gZnJlcXVlbmN5IGFuZCB0aGUgcmVmZXJlbmNlIGZy ZXF1ZW5jeSAobm90IHN1cmUgd2UKPiA+ID4gPiA+IHdhbnQgdGhlIGxhc3Qgb25lLCBidXQgSSBw dXQgaXQgdGhlcmUgYW55d2F5KS4gV2UnbGwgYWxzbyBtYWtlIHRoZQo+ID4gPiA+ID4gLmdldF9j ZGNsaygpIGZ1bmN0aW9uIGZpbGwgb3V0IHRoaXMgc3RhdGUgc3RydWN0dXJlIHJhdGhlciB0aGFu Cj4gPiA+ID4gPiBqdXN0IHJldHVybmluZyB0aGUgY3VycmVudCBjZGNsayBmcmVxdWVuY3kuCj4g PiA+ID4gPiAKPiA+ID4gPiA+IE9uZSBpbW1lZGlhdGUgYmVuZWZpdCBpcyB0aGF0IGNhbGxpbmcg LmdldF9jZGNsaygpIHdpbGwgbm8gbG9uZ2VyCj4gPiA+ID4gPiBjbG9iYmVyIHN0YXRlIHN0b3Jl ZCB1bmRlciBkZXZfcHJpdiB1bmxlc3MgZXhbcGxpY2l0bHkgdG9sZCB0byBkbwo+ID4gPiA+IFR5 cG86IGV4W3BsaWNpdHkKPiA+ID4gPiAKPiA+ID4gPiA+IAo+ID4gPiA+ID4gCj4gPiA+ID4gPiBz by4gUHJldmlvdXNseSBpdCBjbG9iYmVyZWQgdGhlIHZjbyBhbmQgcmVmZXJlbmNlIGNsb2NrcyBz dG9yZWQKPiA+ID4gPiA+IHRoZXJlIG9uIHNvbWUgcGxhdGZvcm1zLgo+ID4gPiA+ID4gCj4gPiA+ ID4gPiBXZSdsbCBleHBhbmQgdGhlIHVzZSBvZiB0aGlzIHN0cnVjdHVyZSB0byBhY3R1YWxseSBw cmVjb21wdXRpbmcgdGhlCj4gPiA+ID4gPiBzdGF0ZSBhbmQgd2hhdG5vdCBsYXRlci4KPiA+ID4g PiA+IAo+ID4gPiA+ID4gdjI6IENvbnN0aWZ5IGludGVsX2NkY2xrX3N0YXRlX2NvbXBhcmUoKQo+ ID4gPiA+ID4gCj4gPiA+ID4gPiBTaWduZWQtb2ZmLWJ5OiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxl LnN5cmphbGFAbGludXguaW50ZWwuY29tPgo+ID4gPiA+IEEgY291cGxlIG1vcmUgY29tbWVudHMg YmVsb2V3LCBidXQgZWl0aGVyIHdheSwKPiA+ID4gPiAKPiA+ID4gPiBSZXZpZXdlZC1ieTogQW5k ZXIgQ29uc2VsdmFuIGRlIE9saXZlaXJhIDxjb25zZWx2YW4yQGdtYWlsLmNvbT4KPiA+ID4gPiAK PiA+ID4gPiA+IAo+ID4gPiA+ID4gCj4gPiA+ID4gPiAtLS0KPiA+ID4gPiA+IMKgZHJpdmVycy9n cHUvZHJtL2k5MTUvaTkxNV9kZWJ1Z2ZzLmPCoMKgwqDCoMKgfMKgwqDCoDIgKy0KPiA+ID4gPiA+ IMKgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaMKgwqDCoMKgwqDCoMKgwqDCoHzCoMKg MTQgKy0KPiA+ID4gPiA+IMKgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfYXVkaW8uY8KgwqDC oMKgwqDCoHzCoMKgwqAyICstCj4gPiA+ID4gPiDCoGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs X2NkY2xrLmPCoMKgwqDCoMKgwqB8IDM1OSArKysrKysrKysrKysrKysrKystLS0tLQo+ID4gPiA+ ID4gLS0tLS0tLS0tCj4gPiA+ID4gPiDCoGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3Bs YXkuY8KgwqDCoMKgfMKgwqAxOCArLQo+ID4gPiA+ID4gwqBkcml2ZXJzL2dwdS9kcm0vaTkxNS9p bnRlbF9kcC5jwqDCoMKgwqDCoMKgwqDCoMKgfMKgwqDCoDIgKy0KPiA+ID4gPiA+IMKgZHJpdmVy cy9ncHUvZHJtL2k5MTUvaW50ZWxfZHJ2LmjCoMKgwqDCoMKgwqDCoMKgfMKgwqDCoDMgKwo+ID4g PiA+ID4gwqBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9mYmMuY8KgwqDCoMKgwqDCoMKgwqB8 wqDCoMKgMiArLQo+ID4gPiA+ID4gwqBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wYW5lbC5j wqDCoMKgwqDCoMKgfMKgwqDCoDQgKy0KPiA+ID4gPiA+IMKgZHJpdmVycy9ncHUvZHJtL2k5MTUv aW50ZWxfcnVudGltZV9wbS5jIHzCoMKgwqA1ICstCj4gPiA+ID4gPiDCoDEwIGZpbGVzIGNoYW5n ZWQsIDI0MCBpbnNlcnRpb25zKCspLCAxNzEgZGVsZXRpb25zKC0pCj4gPiA+ID4gPiAKPiA+IFsu Li5dCj4gPiAKPiA+IEBAIC02MjksMTIgKzY2OCwxMyBAQCBzdGF0aWMgaW50IHNrbF9jYWxjX2Nk Y2xrKGludCBtYXhfcGl4Y2xrLCBpbnQgdmNvKQo+ID4gPiAKPiA+ID4gPiAKPiA+ID4gPiA+IAo+ ID4gPiA+ID4gwqB9Cj4gPiA+ID4gPiDCoAo+ID4gPiA+ID4gLXN0YXRpYyB2b2lkIHNrbF9kcGxs MF91cGRhdGUoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ID4gPiA+ID4gK3N0 YXRpYyB2b2lkIHNrbF9kcGxsMF91cGRhdGUoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9w cml2LAo+ID4gPiA+ID4gKwkJCcKgwqDCoMKgwqBzdHJ1Y3QgaW50ZWxfY2RjbGtfc3RhdGUgKmNk Y2xrX3N0YXRlKQo+ID4gPiA+ID4gwqB7Cj4gPiA+ID4gPiDCoAl1MzIgdmFsOwo+ID4gPiA+ID4g wqAKPiA+ID4gPiA+IC0JZGV2X3ByaXYtPmNkY2xrX3BsbC5yZWYgPSAyNDAwMDsKPiA+ID4gPiA+ IC0JZGV2X3ByaXYtPmNkY2xrX3BsbC52Y28gPSAwOwo+ID4gPiA+ID4gKwljZGNsa19zdGF0ZS0+ cmVmID0gMjQwMDA7Cj4gPiA+ID4gPiArCWNkY2xrX3N0YXRlLT52Y28gPSAwOwo+ID4gPiA+ID4g wqAKPiA+ID4gPiA+IMKgCXZhbCA9IEk5MTVfUkVBRChMQ1BMTDFfQ1RMKTsKPiA+ID4gPiA+IMKg CWlmICgodmFsICYgTENQTExfUExMX0VOQUJMRSkgPT0gMCkKPiA+ID4gPiA+IEBAIC02NTYsMTEg KzY5NiwxMSBAQCBzdGF0aWMgdm9pZCBza2xfZHBsbDBfdXBkYXRlKHN0cnVjdAo+ID4gPiA+ID4g ZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gPiA+ID4gPiDCoAljYXNlIERQTExfQ1RSTDFf TElOS19SQVRFKERQTExfQ1RSTDFfTElOS19SQVRFXzEzNTAsCj4gPiA+ID4gPiBTS0xfRFBMTDAp Ogo+ID4gPiA+ID4gwqAJY2FzZSBEUExMX0NUUkwxX0xJTktfUkFURShEUExMX0NUUkwxX0xJTktf UkFURV8xNjIwLAo+ID4gPiA+ID4gU0tMX0RQTEwwKToKPiA+ID4gPiA+IMKgCWNhc2UgRFBMTF9D VFJMMV9MSU5LX1JBVEUoRFBMTF9DVFJMMV9MSU5LX1JBVEVfMjcwMCwKPiA+ID4gPiA+IFNLTF9E UExMMCk6Cj4gPiA+ID4gPiAtCQlkZXZfcHJpdi0+Y2RjbGtfcGxsLnZjbyA9IDgxMDAwMDA7Cj4g PiA+ID4gPiArCQljZGNsa19zdGF0ZS0+dmNvID0gODEwMDAwMDsKPiA+ID4gPiA+IMKgCQlicmVh azsKPiA+ID4gPiA+IMKgCWNhc2UgRFBMTF9DVFJMMV9MSU5LX1JBVEUoRFBMTF9DVFJMMV9MSU5L X1JBVEVfMTA4MCwKPiA+ID4gPiA+IFNLTF9EUExMMCk6Cj4gPiA+ID4gPiDCoAljYXNlIERQTExf Q1RSTDFfTElOS19SQVRFKERQTExfQ1RSTDFfTElOS19SQVRFXzIxNjAsCj4gPiA+ID4gPiBTS0xf RFBMTDApOgo+ID4gPiA+ID4gLQkJZGV2X3ByaXYtPmNkY2xrX3BsbC52Y28gPSA4NjQwMDAwOwo+ ID4gPiA+ID4gKwkJY2RjbGtfc3RhdGUtPnZjbyA9IDg2NDAwMDA7Cj4gPiA+ID4gPiDCoAkJYnJl YWs7Cj4gPiA+ID4gPiDCoAlkZWZhdWx0Ogo+ID4gPiA+ID4gwqAJCU1JU1NJTkdfQ0FTRSh2YWwg Jgo+ID4gPiA+ID4gRFBMTF9DVFJMMV9MSU5LX1JBVEVfTUFTSyhTS0xfRFBMTDApKTsKPiA+ID4g PiBUaGlzIGZ1bmN0aW9uIGlzIGEgYml0IGZ1bm55IG5vdywgc2luY2UgaXQgc2V0cyB1cCB0aGUg Y2RjbGsgc3RhdGUgYmFzZWQKPiA+ID4gPiBvbgo+ID4gPiA+IGN1cnJlbnQgcGxsMCBwcm9ncmFt bWluZywgaW5zdGVhZCBvZiBsb29raW5nIGF0IGFuIGF0b21pYyBzdGF0ZS4KPiA+ID4gV2Ugc2hv dWxkIHByb2JhYmx5IHJlbmFtZSBpdCB0byBzb21laHRpbmcgbW9yZSBkZXNjcmlwdGl2ZS4KPiA+ ID4gc2tsX2dldF9kcGxsMCgpCj4gPiA+IG1heWJlLiBPciBtYXliZSBza2xfZHBsbDBfZ2V0X2Nv bmZpZyB0byBtYXRjaCB0aGUgLmdldF9jb25maWcoKQo+ID4gPiBub21lbmNsYXR1cmUgdXNlZCBm b3IgZWcuIGVuY29kZXJzLgo+ID4gSG1tLCBJIHRoaW5rIHRoZSBwcm9ibGVtIGlzIHRoYXQgdGhp cyBoYXZlIGEgbWl4IG9mIGdldF9od19zdGF0ZSgpIGFuZAo+ID4gZ2V0X2NvbmZpZygpLiBXZSBh Y3R1YWxseSBoYXZlIHNrbF9kZGlfZHBsbDBfZ2V0X2h3X3N0YXRlKCksIGJ1dCBpdCB3b3VsZG4n dAo+ID4gYmUKPiA+IHRyaXZpYWwgdG8gbWFrZSB0aGF0IGNvZGUgcmV1c2FibGUgZm9yIHRoZSBj ZGNsayBzdHVmZi4KPiA+IAo+ID4gTWF5YmUgaXQgc2hvdWxkIGJlIHR3byBzZXBhcmF0ZSBmdW5j dGlvbnMsIG9uZSB0aGF0IGdldHMgdGhlIGhhcmR3YXJlIHN0YXRlCj4gPiBhbmQKPiA+IGFub3Ro ZXIgZm9yIGNob29zaW5nIHRoZSB2Y28uCj4gVGhpcyBmdW5jdGlvbiBvbmx5IGV4aXN0cyB0byBy ZWFkIHRoZSBodyBzdGF0ZS4KClRoZW4gZ2V0X2h3X3N0YXRlKCkgd291bGRuJ3QgYmUgYSBiYWQg bmFtZS4gVGhlIG9ubHkgZGlmZmVyZW5jZSBiZXR3ZWVuIHRoaXMgYW5kCnRoZSBwbGwgZ2V0X2h3 X3N0YXRlKCkgaG9vayBpcyB0aGF0IHRoZSBsYXR0ZXIgZG9lc24ndCBzZXQgYSB2Y28gdmFsdWUs IHNpbmNlCnRoYXQgaXMgbm90IGRpcmVjdGx5IHByb2dyYW1tZWQuCgo+IAo+ID4gCj4gPiBUaGVu Cj4gPiAKPiA+IMKgIHZjbyA9IHNrbF9jZGNsa192Y28oc2tsX2RwbGwwX2dldF9od19zdGF0ZSgp KTsKPiA+IAo+ID4gZGlyZWN0bHkgaW4gc2tsX2dldF9jZGNsaygpID8gSSdtIG5vdCByZWFsbHkg c3VyZSwgbWF5YmUganVzdCBsZWF2ZSB0aGUgd2F5Cj4gPiBpdAo+ID4gaXMgZm9yIG5vdy4KPiA+ IAo+ID4gPiAKPiA+ID4gwqBUaG91Z2ggaWYgd2UgZ28gdGhlcmUgdGhlbgo+ID4gPiAuZ2V0X2Nk Y2xrKCkgbWlnaHQgbmVlZCB0byBiZSByZW5hbWVkIHRvIC5jZGNsa19nZXRfY29uZmlnIG9yIHNv bWV0aGluZy4KPiA+IC5jZGNsa19nZXRfaHdfc3RhdGUoKSA/Cj4gLmdldF9od19zdGF0ZSgpIGlz IHRoZSB0aGluZyB3aGljaCB0ZWxscyB1cyBpZiBzb21ldGhpbmcgaXMgZW5hYmxlZCwKPiAuZ2V0 X2NvbmZpZygpIGlzIHRoZSB0aGluZyB0aGF0IGFjdHVhbGx5IHJlYWRzIG91dCB0aGUgZnVsbCBz dGF0ZS4gT3IgYXQKPiBsZWFzdCB0aGF0J3MgaG93IGl0IHVzZWQgdG8gYmUuCgpGb3IgZW5jb2Rl cnMsIGdldF9od19zdGF0ZSgpIG1heSBhbHNvIHJlYWQgd2hhdCBwaXBlIGl0IGlzIGluLiBGb3Ig Y3J0Y3MsCmdldF9waXBlX2NvbmZpZygpIGRvZXMgYm90aC4gUExMcyBnZXRfaHdfc3RhdGUoKSBy ZWFkIHRoZSB3aG9sZSBjb25maWcgdG9vLiBJCmd1ZXNzIHRoZXJlJ3Mgcm9vbSBmb3IgbWFraW5n IHRoZXNlIG1vcmUgY29uc2lzdGVudC4gSSdkIGdvIGZvciBpc19lbmFibGVkKCkgZm9yCnNvbWV0 aGluZyB0aGF0IGlzIG9ubHkgc3VwcG9zZWQgdG8gc2F5IGlmIHNvbWV0aGluZyBpcyBlbmFibGVk LiA6KQoKQW5kZXIKCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Au b3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwt Z2Z4Cg==