[PATCH igt 2/6] kms_frontbuffer_tracking: fix sink CRC assertion

Paulo Zanoni
2016-12-22T20:42:16Z

If we already detected an error, don't try to assert the size of what
we didn't read.

In machines where the sink CRC is unreliable, this was failing tests
where the sink CRC is not mandatory (FBC tests). With this change we
won't fail anymore, we'll just print error messages saying that the
sink CRC is unreliable.

Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
---
tests/kms_frontbuffer_tracking.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

This is important. I thought I had merged this in the upstream repo a long time
ago...

diff --git a/tests/kms_frontbuffer_tracking.c b/tests/kms_frontbuffer_tracking.c
index fd3ad53..81532dc 100644
--- a/tests/kms_frontbuffer_tracking.c
+++ b/tests/kms_frontbuffer_tracking.c
@@ -943,8 +943,9 @@ static void get_sink_crc(sink_crc_t *crc, bool mandatory)
igt_skip("Sink CRC is unreliable on this machine. Try running this test again individually\n");
else
igt_info("Sink CRC is unreliable on this machine. Try running this test again individually\n");
+ } else {
+ igt_assert(rc == SINK_CRC_SIZE);
}
- igt_assert(rc == SINK_CRC_SIZE);
}

static bool sink_crc_equal(sink_crc_t *a, sink_crc_t *b)