From: Ander Conselvan De Oliveira <conselvan2@gmail.com>
To: "Maiti, Nabendu Bikash" <nabendu.bikash.maiti@intel.com>,
Chris Wilson <chris@chris-wilson.co.uk>,
intel-gfx@lists.freedesktop.org,
Daniel Vetter <daniel.vetter@intel.com>,
Jani Nikula <jani.nikula@linux.intel.com>
Subject: Re: [PATCH] drm/i915: Initialize num_scalers for skl and glk too
Date: Tue, 03 Jan 2017 12:28:27 +0200 [thread overview]
Message-ID: <1483439307.5671.8.camel@gmail.com> (raw)
In-Reply-To: <48ec54eb-c524-5705-810d-8ee8725029e7@intel.com>
On Mon, 2017-01-02 at 21:19 +0530, Maiti, Nabendu Bikash wrote:
> I am wondering why the number of sprite initialization is not done in
> runtime init for skylake/glk similarly.
It is done in the "else if (INTEL_GEN(dev_priv) >= 5)" branch. The comment
explains why the topmost plane is not enabled.
Ander
>
> On 1/2/2017 8:27 PM, Chris Wilson wrote:
> >
> > On Mon, Jan 02, 2017 at 03:54:41PM +0200, Ander Conselvan de Oliveira wrote:
> > >
> > > After commit 1c74eeaf16b8 ("drm/i915: Move number of scalers
> > > initialization to
> > > runtime init"), scalers are not initialized properly for skl and glk
> > > since num_scalers is left as 0 for those platforms.
> > Next question is why this user visible change is not causing test
> > failures in BAT?
> > -Chris
> >
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-01-03 10:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-02 13:54 [PATCH] drm/i915: Initialize num_scalers for skl and glk too Ander Conselvan de Oliveira
2017-01-02 14:57 ` Chris Wilson
2017-01-02 15:49 ` Maiti, Nabendu Bikash
2017-01-03 10:28 ` Ander Conselvan De Oliveira [this message]
2017-01-03 10:26 ` Ander Conselvan De Oliveira
2017-01-03 13:49 ` Ander Conselvan De Oliveira
2017-01-03 13:58 ` Chris Wilson
2017-01-03 14:08 ` Saarinen, Jani
2017-01-02 15:23 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-01-03 13:35 ` [PATCH] " Ville Syrjälä
2017-01-03 13:45 ` Conselvan De Oliveira, Ander
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1483439307.5671.8.camel@gmail.com \
--to=conselvan2@gmail.com \
--cc=chris@chris-wilson.co.uk \
--cc=daniel.vetter@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=nabendu.bikash.maiti@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).