Re: [PATCH] drm/i915: Initialize num_scalers for skl and glk too

From: Ander Conselvan De Oliveira <conselvan2@gmail.com>
To: Chris Wilson <chris@chris-wilson.co.uk>,
	Tomi Sarvela <tomi.p.sarvela@intel.com>,
	Petri Latvala <petri.latvala@intel.com>
Cc: Daniel Vetter <daniel.vetter@intel.com>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Initialize num_scalers for skl and glk too
Date: Tue, 03 Jan 2017 15:49:15 +0200	[thread overview]
Message-ID: <1483451355.5671.13.camel@gmail.com> (raw)
In-Reply-To: <1483439189.5671.6.camel@gmail.com>

On Tue, 2017-01-03 at 12:26 +0200, Ander Conselvan De Oliveira wrote:
> On Mon, 2017-01-02 at 14:57 +0000, Chris Wilson wrote:
> > 
> > On Mon, Jan 02, 2017 at 03:54:41PM +0200, Ander Conselvan de Oliveira wrote:
> > > 
> > > 
> > > After commit 1c74eeaf16b8 ("drm/i915: Move number of scalers
> > > initialization
> > > to
> > > runtime init"), scalers are not initialized properly for skl and glk
> > > since num_scalers is left as 0 for those platforms.
> > Next question is why this user visible change is not causing test
> > failures in BAT?
> There isn't a single test in BAT that tries to setup a plane with scaling. The
> kms_panel_fitting and kms_plane_scaling tests would have caught the issue, but
> they are not part of BAT. kms_plane and kms_universal_plane are also not part
> of
> BAT, and they also don't test scaling.

Is it feasible to add one of those tests to BAT? Would it help with the time
constraints if we run it only on gen9+? There's already a test for gen9 specific
things in kms_universal_plane, maybe we could use that?

Ander
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx