From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 2/2] drm/i915: Reset the gpu on takeover
Date: Mon, 23 Jan 2017 11:39:45 +0200 [thread overview]
Message-ID: <1485164385.2790.9.camel@linux.intel.com> (raw)
In-Reply-To: <20170121145045.27351-2-chris@chris-wilson.co.uk>
On la, 2017-01-21 at 14:50 +0000, Chris Wilson wrote:
> The GPU may be in an unknown state following resume and module load. The
> previous occupant may have left contexts loaded, or other dangerous
> state, which can cause an immediate GPU hang for us. The only save
> course of action is to reset the GPU prior to using it - similarly to
> how we reset the GPU prior to unload (before a second user may be
> affected by our leftover state).
>
> We need to reset the GPU very early in our load/resume sequence so that
> any stale HW pointers are revoked prior to any resource allocations we
> make (that may conflict).
>
> A reset should only be a couple of milliseconds on a slow device, a cost
> we should easily be able to absorb into our initialisation times.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Can't really suggest better names for the functions, so;
Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-01-23 9:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-21 14:50 [PATCH 1/2] drm/i915: Split intel_engine allocation and initialisation Chris Wilson
2017-01-21 14:50 ` [PATCH 2/2] drm/i915: Reset the gpu on takeover Chris Wilson
2017-01-23 9:39 ` Joonas Lahtinen [this message]
2017-01-21 15:24 ` ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Split intel_engine allocation and initialisation Patchwork
2017-01-23 9:26 ` [PATCH v2] " Chris Wilson
2017-01-23 9:41 ` [PATCH 1/2] " Joonas Lahtinen
2017-01-23 9:57 ` Chris Wilson
2017-01-23 12:08 ` Joonas Lahtinen
2017-01-23 10:54 ` ✓ Fi.CI.BAT: success for series starting with [v2] drm/i915: Split intel_engine allocation and initialisation (rev2) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1485164385.2790.9.camel@linux.intel.com \
--to=joonas.lahtinen@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).