From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 4/4] drm/i915: Emit dma-fence (and execlists submit) first from signaler
Date: Mon, 23 Jan 2017 13:37:22 +0200 [thread overview]
Message-ID: <1485171442.2790.18.camel@linux.intel.com> (raw)
In-Reply-To: <20170121092815.1431-4-chris@chris-wilson.co.uk>
On la, 2017-01-21 at 09:28 +0000, Chris Wilson wrote:
> When introduced, I thought that reducing client latency from the
> signaler was the priority. Since its inception the signaler has become
> responsible for keeping the execlists full, via the dma-fence. As this
> is very important to minimise overall execution time, signal the
> dma-fence first and then signal any waiting clients.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Do we have a clear testcase where this can be observed?
Gladly it's well isolated to one patch, so should make bisecting easier
during testing;
Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-01-23 11:37 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-21 9:28 [PATCH 1/4] drm/i915: Only disable execlist preemption for the duration of the request Chris Wilson
2017-01-21 9:28 ` [PATCH 2/4] drm/i915: Skip the execlists CSB scan and rewrite if the ring is untouched Chris Wilson
2017-01-23 11:33 ` Joonas Lahtinen
2017-01-23 11:47 ` Chris Wilson
2017-01-21 9:28 ` [PATCH 3/4] drm/i915: Dequeue execlists on a new request if any port is available Chris Wilson
2017-01-23 10:56 ` Tvrtko Ursulin
2017-01-23 11:21 ` Chris Wilson
2017-01-21 9:28 ` [PATCH 4/4] drm/i915: Emit dma-fence (and execlists submit) first from signaler Chris Wilson
2017-01-23 10:58 ` Tvrtko Ursulin
2017-01-23 11:37 ` Joonas Lahtinen [this message]
2017-01-21 10:54 ` ✗ Fi.CI.BAT: warning for series starting with [1/4] drm/i915: Only disable execlist preemption for the duration of the request Patchwork
2017-01-21 11:02 ` Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1485171442.2790.18.camel@linux.intel.com \
--to=joonas.lahtinen@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox