Re: [PATCH v2 6/8] drm/i915/tracepoints: Rename i915_gem_request_notify

Chris Wilson
2017-02-20T16:07:26Z

On Mon, Feb 20, 2017 at 03:58:12PM +0000, Tvrtko Ursulin wrote:
>
> On 30/01/2017 19:44, Chris Wilson wrote:
> >On Mon, Jan 30, 2017 at 06:07:29PM +0000, Tvrtko Ursulin wrote:
> >>From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> >>
> >>i915_gem_ring_notify is more appropriate since we do not have
> >>the request information at this point, but it is simply a
> >>signal from the engine that some request has been completed.
> >>
> >>v2:
> >> * Always trace and log if there were any waiters.
> >Agreed, I'd sketched that change, well to always emit the tracepoint when
> >the interrupt fired. Whether it was in vain is icing on the cake - I've
> >some sketches of keeping the user-interrupt alive until the following rq
> >to short-circuit some ping-ponging or irq enable state.
>
> Shall we progress this series or leave it for some future convenient time?

iirc, it marries well with the patch (on list now) to keep the interrupt
alive for an extra tick. Now's as good as time as any to push the
improvements to rq tracing.
-Chris

--
Chris Wilson, Intel Open Source Technology Centre