Re: [PATCH v2 6/8] drm/i915/tracepoints: Rename i915_gem_request_notify

Chris Wilson
2017-01-30T19:44:32Z

On Mon, Jan 30, 2017 at 06:07:29PM +0000, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>
> i915_gem_ring_notify is more appropriate since we do not have
> the request information at this point, but it is simply a
> signal from the engine that some request has been completed.
>
> v2:
> * Always trace and log if there were any waiters.
Agreed, I'd sketched that change, well to always emit the tracepoint when
the interrupt fired. Whether it was in vain is icing on the cake - I've
some sketches of keeping the user-interrupt alive until the following rq
to short-circuit some ping-ponging or irq enable state.
-Chris

--
Chris Wilson, Intel Open Source Technology Centre