From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Check fence status after serialising with the spinlock
Date: Mon, 30 Jan 2017 14:27:13 +0200 [thread overview]
Message-ID: <1485779233.2893.2.camel@linux.intel.com> (raw)
In-Reply-To: <20170127130607.31970-1-chris@chris-wilson.co.uk>
On pe, 2017-01-27 at 13:06 +0000, Chris Wilson wrote:
> A very rare problem we encounter is that as retire the request we find
we -^
> that it appears to not have been yet executed. Other than malevolent hw,
> one possible explanation is that the update of the fence status on one
> cpu (an atomic_dec_and_test) is not yet visible to the retiree on
> another cpu. However, since retirement is serialised with execution via
> a fence-local spinlock, we can use these to ensure that we have
But it uses timeline spinlock?
> sufficient barriers between the execution and the assert in retirement.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2017-01-30 12:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-27 13:06 [PATCH] drm/i915: Check fence status after serialising with the spinlock Chris Wilson
2017-01-30 11:24 ` ✗ Fi.CI.BAT: warning for " Patchwork
2017-01-30 12:27 ` Joonas Lahtinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1485779233.2893.2.camel@linux.intel.com \
--to=joonas.lahtinen@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).