From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Cc: Jani Nikula <jani.nikula@intel.com>,
"Zanoni, Paulo R" <paulo.r.zanoni@intel.com>,
Rodrigo Vivi <rodrigo.vivi@intel.com>
Subject: Re: [PATCH v2 1/3] drm/i915: Make intel_detect_preproduction_hw easier to extend
Date: Mon, 30 Jan 2017 14:35:29 +0200 [thread overview]
Message-ID: <1485779729.2893.7.camel@linux.intel.com> (raw)
In-Reply-To: <20170130104458.2653-1-chris@chris-wilson.co.uk>
On ma, 2017-01-30 at 10:44 +0000, Chris Wilson wrote:
> As we add new generations, we should keep detecting new pre-production
> system development platforms that were temporarily enabled to facilitate
> initial development and now superseded by production systems. To make
> it easier to add more platforms, split the if into a series of logical
> operations.
>
> v2: s/sdv/pre/ - not all system development vehicles are for
> preproduction usage.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: "Zanoni, Paulo R" <paulo.r.zanoni@intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Cc: Jani Nikula <jani.nikula@intel.com>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
<SNIP>
> static void intel_detect_preproduction_hw(struct drm_i915_private *dev_priv)
> {
> - if (IS_HSW_EARLY_SDV(dev_priv) ||
> - IS_SKL_REVID(dev_priv, 0, SKL_REVID_F0))
> + bool pre = false;
> +
> + pre |= IS_HSW_EARLY_SDV(dev_priv);
> + pre |= IS_SKL_REVID(dev_priv, 0, SKL_REVID_F0);
Did you compare the asm with "pre = pre || ..."?
Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-01-30 12:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-30 10:44 [PATCH v2 1/3] drm/i915: Make intel_detect_preproduction_hw easier to extend Chris Wilson
2017-01-30 10:44 ` [PATCH v2 2/3] drm/i915: Mark the kernel as tainted if we fail the preproduction check Chris Wilson
2017-01-30 12:31 ` Joonas Lahtinen
2017-01-30 13:25 ` Chris Wilson
2017-01-30 10:44 ` [PATCH v2 3/3] drm/i915: Add early BXT sdv to the list of preproduction machines Chris Wilson
2017-01-30 12:36 ` Joonas Lahtinen
2017-01-30 12:35 ` Joonas Lahtinen [this message]
2017-01-30 13:11 ` [PATCH v2 1/3] drm/i915: Make intel_detect_preproduction_hw easier to extend Jani Nikula
2017-01-30 13:18 ` Chris Wilson
2017-01-30 17:54 ` ✓ Fi.CI.BAT: success for series starting with [v2,1/3] " Patchwork
2017-01-31 16:10 ` Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1485779729.2893.7.camel@linux.intel.com \
--to=joonas.lahtinen@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=paulo.r.zanoni@intel.com \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).