[PATCH v2 1/3] drm/i915: Make intel_detect_preproduction_hw easier to extend

[PATCH v2 1/3] drm/i915: Make intel_detect_preproduction_hw easier to extend

[Chris Wilson]

As we add new generations, we should keep detecting new pre-production
system development platforms that were temporarily enabled to facilitate
initial development and now superseded by production systems. To make
it easier to add more platforms, split the if into a series of logical
operations.

v2: s/sdv/pre/ - not all system development vehicles are for
preproduction usage.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: "Zanoni, Paulo R" <paulo.r.zanoni@intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: Jani Nikula <jani.nikula@intel.com>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 drivers/gpu/drm/i915/i915_drv.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
index 008fc1e62a69..b55ad5199967 100644
--- a/drivers/gpu/drm/i915/i915_drv.c
+++ b/drivers/gpu/drm/i915/i915_drv.c
@@ -782,8 +782,12 @@ static void i915_workqueues_cleanup(struct drm_i915_private *dev_priv)
  */
 static void intel_detect_preproduction_hw(struct drm_i915_private *dev_priv)
 {
-	if (IS_HSW_EARLY_SDV(dev_priv) ||
-	    IS_SKL_REVID(dev_priv, 0, SKL_REVID_F0))
+	bool pre = false;
+
+	pre |= IS_HSW_EARLY_SDV(dev_priv);
+	pre |= IS_SKL_REVID(dev_priv, 0, SKL_REVID_F0);
+
+	if (pre)
 		DRM_ERROR("This is a pre-production stepping. "
 			  "It may not be fully functional.\n");
 }
-- 
2.11.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[PATCH v2 2/3] drm/i915: Mark the kernel as tainted if we fail the preproduction check

[Chris Wilson]

Preproduction sdv are not supported beyond the release of production
hardware, and continued use is ill-advised. Mark the kernel as tainted
to reinforce the error.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: "Zanoni, Paulo R" <paulo.r.zanoni@intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: Jani Nikula <jani.nikula@intel.com>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Acked-by: Jani Nikula <jani.nikula@intel.com>
---
 drivers/gpu/drm/i915/i915_drv.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
index b55ad5199967..5ae5b190241c 100644
--- a/drivers/gpu/drm/i915/i915_drv.c
+++ b/drivers/gpu/drm/i915/i915_drv.c
@@ -787,9 +787,11 @@ static void intel_detect_preproduction_hw(struct drm_i915_private *dev_priv)
 	pre |= IS_HSW_EARLY_SDV(dev_priv);
 	pre |= IS_SKL_REVID(dev_priv, 0, SKL_REVID_F0);
 
-	if (pre)
+	if (pre) {
 		DRM_ERROR("This is a pre-production stepping. "
 			  "It may not be fully functional.\n");
+		add_taint(TAINT_MACHINE_CHECK, LOCKDEP_STILL_OK);
+	}
 }
 
 /**
-- 
2.11.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[PATCH v2 3/3] drm/i915: Add early BXT sdv to the list of preproduction machines

[Chris Wilson]

Extend intel_detect_preproduction_hw() to include BXT A and B steppings.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: "Zanoni, Paulo R" <paulo.r.zanoni@intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: Jani Nikula <jani.nikula@intel.com>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 drivers/gpu/drm/i915/i915_drv.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
index 5ae5b190241c..ac10e2f98f72 100644
--- a/drivers/gpu/drm/i915/i915_drv.c
+++ b/drivers/gpu/drm/i915/i915_drv.c
@@ -786,6 +786,7 @@ static void intel_detect_preproduction_hw(struct drm_i915_private *dev_priv)
 
 	pre |= IS_HSW_EARLY_SDV(dev_priv);
 	pre |= IS_SKL_REVID(dev_priv, 0, SKL_REVID_F0);
+	pre |= IS_BXT_REVID(dev_priv, 0, BXT_REVID_B_LAST);
 
 	if (pre) {
 		DRM_ERROR("This is a pre-production stepping. "
-- 
2.11.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH v2 2/3] drm/i915: Mark the kernel as tainted if we fail the preproduction check

[Joonas Lahtinen]

On ma, 2017-01-30 at 10:44 +0000, Chris Wilson wrote:
> Preproduction sdv are not supported beyond the release of production
> hardware, and continued use is ill-advised. Mark the kernel as tainted
> to reinforce the error.
> 
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: "Zanoni, Paulo R" <paulo.r.zanoni@intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Cc: Jani Nikula <jani.nikula@intel.com>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Acked-by: Jani Nikula <jani.nikula@intel.com>

Correct use of taint flags. I think CPU_OUT_OF_SPEC could be more
correct flag, though?

Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>

Regards, Joonas
-- 
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH v2 1/3] drm/i915: Make intel_detect_preproduction_hw easier to extend

[Joonas Lahtinen]

On ma, 2017-01-30 at 10:44 +0000, Chris Wilson wrote:
> As we add new generations, we should keep detecting new pre-production
> system development platforms that were temporarily enabled to facilitate
> initial development and now superseded by production systems. To make
> it easier to add more platforms, split the if into a series of logical
> operations.
> 
> v2: s/sdv/pre/ - not all system development vehicles are for
> preproduction usage.
> 
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: "Zanoni, Paulo R" <paulo.r.zanoni@intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Cc: Jani Nikula <jani.nikula@intel.com>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>

<SNIP>

>  static void intel_detect_preproduction_hw(struct drm_i915_private *dev_priv)
>  {
> -	if (IS_HSW_EARLY_SDV(dev_priv) ||
> -	    IS_SKL_REVID(dev_priv, 0, SKL_REVID_F0))
> +	bool pre = false;
> +
> +	pre |= IS_HSW_EARLY_SDV(dev_priv);
> +	pre |= IS_SKL_REVID(dev_priv, 0, SKL_REVID_F0);

Did you compare the asm with "pre = pre || ..."?

Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>

Regards, Joonas
-- 
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH v2 3/3] drm/i915: Add early BXT sdv to the list of preproduction machines

[Joonas Lahtinen]

On ma, 2017-01-30 at 10:44 +0000, Chris Wilson wrote:
> Extend intel_detect_preproduction_hw() to include BXT A and B steppings.
> 
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: "Zanoni, Paulo R" <paulo.r.zanoni@intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Cc: Jani Nikula <jani.nikula@intel.com>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>

Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>

Regards, Joonas
-- 
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH v2 1/3] drm/i915: Make intel_detect_preproduction_hw easier to extend

[Jani Nikula]

On Mon, 30 Jan 2017, Joonas Lahtinen <joonas.lahtinen@linux.intel.com> wrote:
> On ma, 2017-01-30 at 10:44 +0000, Chris Wilson wrote:
>> As we add new generations, we should keep detecting new pre-production
>> system development platforms that were temporarily enabled to facilitate
>> initial development and now superseded by production systems. To make
>> it easier to add more platforms, split the if into a series of logical
>> operations.
>> 
>> v2: s/sdv/pre/ - not all system development vehicles are for
>> preproduction usage.
>> 
>> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
>> Cc: "Zanoni, Paulo R" <paulo.r.zanoni@intel.com>
>> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
>> Cc: Jani Nikula <jani.nikula@intel.com>
>> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> <SNIP>
>
>>  static void intel_detect_preproduction_hw(struct drm_i915_private *dev_priv)
>>  {
>> -	if (IS_HSW_EARLY_SDV(dev_priv) ||
>> -	    IS_SKL_REVID(dev_priv, 0, SKL_REVID_F0))
>> +	bool pre = false;
>> +
>> +	pre |= IS_HSW_EARLY_SDV(dev_priv);
>> +	pre |= IS_SKL_REVID(dev_priv, 0, SKL_REVID_F0);
>
> Did you compare the asm with "pre = pre || ..."?

Yeah, this definitely needs to be optimized. :p

Acked-by: Jani Nikula <jani.nikula@intel.com>

on the series.

>
> Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
>
> Regards, Joonas

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH v2 1/3] drm/i915: Make intel_detect_preproduction_hw easier to extend

[Chris Wilson]

On Mon, Jan 30, 2017 at 03:11:07PM +0200, Jani Nikula wrote:
> On Mon, 30 Jan 2017, Joonas Lahtinen <joonas.lahtinen@linux.intel.com> wrote:
> > On ma, 2017-01-30 at 10:44 +0000, Chris Wilson wrote:
> >> As we add new generations, we should keep detecting new pre-production
> >> system development platforms that were temporarily enabled to facilitate
> >> initial development and now superseded by production systems. To make
> >> it easier to add more platforms, split the if into a series of logical
> >> operations.
> >> 
> >> v2: s/sdv/pre/ - not all system development vehicles are for
> >> preproduction usage.
> >> 
> >> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> >> Cc: "Zanoni, Paulo R" <paulo.r.zanoni@intel.com>
> >> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> >> Cc: Jani Nikula <jani.nikula@intel.com>
> >> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > <SNIP>
> >
> >>  static void intel_detect_preproduction_hw(struct drm_i915_private *dev_priv)
> >>  {
> >> -	if (IS_HSW_EARLY_SDV(dev_priv) ||
> >> -	    IS_SKL_REVID(dev_priv, 0, SKL_REVID_F0))
> >> +	bool pre = false;
> >> +
> >> +	pre |= IS_HSW_EARLY_SDV(dev_priv);
> >> +	pre |= IS_SKL_REVID(dev_priv, 0, SKL_REVID_F0);
> >
> > Did you compare the asm with "pre = pre || ..."?
> 
> Yeah, this definitely needs to be optimized. :p

Thank goodness it makes no difference!
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH v2 2/3] drm/i915: Mark the kernel as tainted if we fail the preproduction check

[Chris Wilson]

On Mon, Jan 30, 2017 at 02:31:57PM +0200, Joonas Lahtinen wrote:
> On ma, 2017-01-30 at 10:44 +0000, Chris Wilson wrote:
> > Preproduction sdv are not supported beyond the release of production
> > hardware, and continued use is ill-advised. Mark the kernel as tainted
> > to reinforce the error.
> > 
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > Cc: "Zanoni, Paulo R" <paulo.r.zanoni@intel.com>
> > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> > Cc: Jani Nikula <jani.nikula@intel.com>
> > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > Acked-by: Jani Nikula <jani.nikula@intel.com>
> 
> Correct use of taint flags. I think CPU_OUT_OF_SPEC could be more
> correct flag, though?

No idea. I figure that our usage will be spotted one day and we will be
told which one to use, maybe even a new taint.

On x86 CPU_OUT_OF_SPEC is used if the user forces pae, sounds reasonable
but I wanted not to imply that this was a CPU issue itself, but relates
to out-of-spec GPU. MCE was broader and can be triggered by other
components failing.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

✓ Fi.CI.BAT: success for series starting with [v2,1/3] drm/i915: Make intel_detect_preproduction_hw easier to extend

[Patchwork]

== Series Details ==

Series: series starting with [v2,1/3] drm/i915: Make intel_detect_preproduction_hw easier to extend
URL   : https://patchwork.freedesktop.org/series/18758/
State : success

== Summary ==

Series 18758v1 Series without cover letter
https://patchwork.freedesktop.org/api/1.0/series/18758/revisions/1/mbox/


fi-bdw-5557u     total:246  pass:232  dwarn:0   dfail:0   fail:0   skip:14 
fi-bsw-n3050     total:246  pass:207  dwarn:0   dfail:0   fail:0   skip:39 
fi-bxt-j4205     total:246  pass:224  dwarn:0   dfail:0   fail:0   skip:22 
fi-bxt-t5700     total:78   pass:65   dwarn:0   dfail:0   fail:0   skip:12 
fi-byt-j1900     total:246  pass:219  dwarn:0   dfail:0   fail:0   skip:27 
fi-byt-n2820     total:246  pass:215  dwarn:0   dfail:0   fail:0   skip:31 
fi-hsw-4770      total:246  pass:227  dwarn:0   dfail:0   fail:0   skip:19 
fi-hsw-4770r     total:246  pass:227  dwarn:0   dfail:0   fail:0   skip:19 
fi-ivb-3520m     total:246  pass:225  dwarn:0   dfail:0   fail:0   skip:21 
fi-ivb-3770      total:246  pass:225  dwarn:0   dfail:0   fail:0   skip:21 
fi-skl-6260u     total:246  pass:233  dwarn:0   dfail:0   fail:0   skip:13 
fi-skl-6700hq    total:246  pass:226  dwarn:0   dfail:0   fail:0   skip:20 
fi-skl-6700k     total:246  pass:221  dwarn:4   dfail:0   fail:0   skip:21 
fi-skl-6770hq    total:246  pass:233  dwarn:0   dfail:0   fail:0   skip:13 
fi-snb-2520m     total:246  pass:215  dwarn:0   dfail:0   fail:0   skip:31 
fi-snb-2600      total:246  pass:214  dwarn:0   dfail:0   fail:0   skip:32 

e1cc28133f0474a85da1fc4017686c701b564312 drm-tip: 2017y-01m-30d-15h-50m-59s UTC integration manifest
9d64070 drm/i915: Add early BXT sdv to the list of preproduction machines
a8e683a drm/i915: Mark the kernel as tainted if we fail the preproduction check
e84a3d0 drm/i915: Make intel_detect_preproduction_hw easier to extend

== Logs ==

For more details see: https://intel-gfx-ci.01.org/CI/Patchwork_3641/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: ✓ Fi.CI.BAT: success for series starting with [v2,1/3] drm/i915: Make intel_detect_preproduction_hw easier to extend

[Chris Wilson]

On Mon, Jan 30, 2017 at 05:54:14PM -0000, Patchwork wrote:
> == Series Details ==
> 
> Series: series starting with [v2,1/3] drm/i915: Make intel_detect_preproduction_hw easier to extend
> URL   : https://patchwork.freedesktop.org/series/18758/
> State : success
> 
> == Summary ==
> 
> Series 18758v1 Series without cover letter
> https://patchwork.freedesktop.org/api/1.0/series/18758/revisions/1/mbox/
> 
> 
> fi-bdw-5557u     total:246  pass:232  dwarn:0   dfail:0   fail:0   skip:14 
> fi-bsw-n3050     total:246  pass:207  dwarn:0   dfail:0   fail:0   skip:39 
> fi-bxt-j4205     total:246  pass:224  dwarn:0   dfail:0   fail:0   skip:22 
> fi-bxt-t5700     total:78   pass:65   dwarn:0   dfail:0   fail:0   skip:12 
> fi-byt-j1900     total:246  pass:219  dwarn:0   dfail:0   fail:0   skip:27 
> fi-byt-n2820     total:246  pass:215  dwarn:0   dfail:0   fail:0   skip:31 
> fi-hsw-4770      total:246  pass:227  dwarn:0   dfail:0   fail:0   skip:19 
> fi-hsw-4770r     total:246  pass:227  dwarn:0   dfail:0   fail:0   skip:19 
> fi-ivb-3520m     total:246  pass:225  dwarn:0   dfail:0   fail:0   skip:21 
> fi-ivb-3770      total:246  pass:225  dwarn:0   dfail:0   fail:0   skip:21 
> fi-skl-6260u     total:246  pass:233  dwarn:0   dfail:0   fail:0   skip:13 
> fi-skl-6700hq    total:246  pass:226  dwarn:0   dfail:0   fail:0   skip:20 
> fi-skl-6700k     total:246  pass:221  dwarn:4   dfail:0   fail:0   skip:21 
> fi-skl-6770hq    total:246  pass:233  dwarn:0   dfail:0   fail:0   skip:13 
> fi-snb-2520m     total:246  pass:215  dwarn:0   dfail:0   fail:0   skip:31 
> fi-snb-2600      total:246  pass:214  dwarn:0   dfail:0   fail:0   skip:32 

Applied in spite of some late background noise about bxt-a0 support, a
bit late now.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx