From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/2] drm/i915: Generate i915_params {} using a macro
Date: Thu, 02 Feb 2017 09:37:37 +0200 [thread overview]
Message-ID: <1486021057.2880.4.camel@linux.intel.com> (raw)
In-Reply-To: <20170201165006.10300-1-chris@chris-wilson.co.uk>
On ke, 2017-02-01 at 16:50 +0000, Chris Wilson wrote:
> I want to print the struct from the error state and so would like to use
> the existing struct definition as the template ala DEV_INFO*
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
<SNIP>
> +#define p(T, member) T member
Choice of macro name not so great. Maybe MEMBER or so.
With more reasonable name;
Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Needs some Acked-by's.
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2017-02-02 7:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-01 16:50 [PATCH 1/2] drm/i915: Generate i915_params {} using a macro Chris Wilson
2017-02-01 16:50 ` [PATCH 2/2] drm/i915: Capture module parameters for the GPU error state Chris Wilson
2017-02-01 16:52 ` Chris Wilson
2017-02-02 7:35 ` Joonas Lahtinen
2017-02-02 13:14 ` Mika Kuoppala
2017-02-01 17:24 ` ✗ Fi.CI.BAT: warning for series starting with [1/2] drm/i915: Generate i915_params {} using a macro Patchwork
2017-02-02 7:37 ` Joonas Lahtinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1486021057.2880.4.camel@linux.intel.com \
--to=joonas.lahtinen@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).