From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: Daniel Vetter <daniel@ffwll.ch>, Jani Nikula <jani.nikula@intel.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
Intel graphics driver community testing & development
<intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH i-g-t v2] tests: Clean up shell scripts
Date: Tue, 07 Feb 2017 12:06:32 +0200 [thread overview]
Message-ID: <1486461992.3121.60.camel@linux.intel.com> (raw)
In-Reply-To: <20170206164050.kmsyrydqucrbqs23@phenom.ffwll.local>
On ma, 2017-02-06 at 17:40 +0100, Daniel Vetter wrote:
> On Mon, Feb 06, 2017 at 03:25:27PM +0200, Jani Nikula wrote:
> >
> > On Mon, 06 Feb 2017, Joonas Lahtinen <joonas.lahtinen@linux.intel.com> wrote:
> > >
> > > Convert all scripts to use /bin/sh shebang and fix all shellcheck
> > > reported problems.
> >
> > Pro-tip, this is the place reserved in commit messages for describing
> > *why* you think the change is needed or for the better. ;)
>
> And this reply here seems to be the place where I'm asking why we don't
> switch to C if we go through all this effort. I don't really see what sh
> over bash buys us (and you can pretty much expect me to re-add bashism the
> next time around I touch these ...).
Oh, totally forgot due to writing the huge RFC e-mail about it. One
could amend the commit message with "to able to run on non-bash
shells.", if it wasn't yet merged.
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-02-07 10:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-06 10:25 [PATCH i-g-t v2] tests: Clean up shell scripts Joonas Lahtinen
2017-02-06 13:25 ` Jani Nikula
2017-02-06 16:40 ` Daniel Vetter
2017-02-07 10:06 ` Joonas Lahtinen [this message]
2017-02-07 13:32 ` Jani Nikula
2017-02-07 14:42 ` Joonas Lahtinen
2017-02-07 14:59 ` Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1486461992.3121.60.camel@linux.intel.com \
--to=joonas.lahtinen@linux.intel.com \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).