* [PATCH] drm/i915: Assert that we never create a vma for the aliasing_ppgtt
@ 2017-02-09 11:19 Chris Wilson
2017-02-09 11:45 ` Joonas Lahtinen
2017-02-09 12:52 ` ✓ Fi.CI.BAT: success for " Patchwork
0 siblings, 2 replies; 4+ messages in thread
From: Chris Wilson @ 2017-02-09 11:19 UTC (permalink / raw)
To: intel-gfx
The aliasing_ppgtt is just a container for the HW context that mirrors
the global gtt. It should never be used directly, so assert if we make
the mistake of trying to allocate a VMA for it.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
---
drivers/gpu/drm/i915/i915_vma.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/i915/i915_vma.c b/drivers/gpu/drm/i915/i915_vma.c
index 341c3f82ec1f..0dc994b76924 100644
--- a/drivers/gpu/drm/i915/i915_vma.c
+++ b/drivers/gpu/drm/i915/i915_vma.c
@@ -78,6 +78,9 @@ vma_create(struct drm_i915_gem_object *obj,
struct rb_node *rb, **p;
int i;
+ /* The aliasing_ppgtt should never be used directly! */
+ GEM_BUG_ON(vm == &vm->i915->mm.aliasing_ppgtt->base);
+
vma = kmem_cache_zalloc(vm->i915->vmas, GFP_KERNEL);
if (vma == NULL)
return ERR_PTR(-ENOMEM);
--
2.11.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/i915: Assert that we never create a vma for the aliasing_ppgtt
2017-02-09 11:19 [PATCH] drm/i915: Assert that we never create a vma for the aliasing_ppgtt Chris Wilson
@ 2017-02-09 11:45 ` Joonas Lahtinen
2017-02-09 12:52 ` ✓ Fi.CI.BAT: success for " Patchwork
1 sibling, 0 replies; 4+ messages in thread
From: Joonas Lahtinen @ 2017-02-09 11:45 UTC (permalink / raw)
To: Chris Wilson, intel-gfx
On to, 2017-02-09 at 11:19 +0000, Chris Wilson wrote:
> The aliasing_ppgtt is just a container for the HW context that mirrors
> the global gtt. It should never be used directly, so assert if we make
> the mistake of trying to allocate a VMA for it.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
* ✓ Fi.CI.BAT: success for drm/i915: Assert that we never create a vma for the aliasing_ppgtt
2017-02-09 11:19 [PATCH] drm/i915: Assert that we never create a vma for the aliasing_ppgtt Chris Wilson
2017-02-09 11:45 ` Joonas Lahtinen
@ 2017-02-09 12:52 ` Patchwork
2017-02-09 13:13 ` Chris Wilson
1 sibling, 1 reply; 4+ messages in thread
From: Patchwork @ 2017-02-09 12:52 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Assert that we never create a vma for the aliasing_ppgtt
URL : https://patchwork.freedesktop.org/series/19370/
State : success
== Summary ==
Series 19370v1 drm/i915: Assert that we never create a vma for the aliasing_ppgtt
https://patchwork.freedesktop.org/api/1.0/series/19370/revisions/1/mbox/
fi-bdw-5557u total:252 pass:238 dwarn:0 dfail:0 fail:0 skip:14
fi-bsw-n3050 total:252 pass:213 dwarn:0 dfail:0 fail:0 skip:39
fi-bxt-j4205 total:252 pass:230 dwarn:0 dfail:0 fail:0 skip:22
fi-bxt-t5700 total:83 pass:70 dwarn:0 dfail:0 fail:0 skip:12
fi-byt-j1900 total:252 pass:225 dwarn:0 dfail:0 fail:0 skip:27
fi-byt-n2820 total:252 pass:221 dwarn:0 dfail:0 fail:0 skip:31
fi-hsw-4770 total:252 pass:233 dwarn:0 dfail:0 fail:0 skip:19
fi-hsw-4770r total:252 pass:233 dwarn:0 dfail:0 fail:0 skip:19
fi-ilk-650 total:252 pass:199 dwarn:0 dfail:0 fail:0 skip:53
fi-ivb-3520m total:252 pass:231 dwarn:0 dfail:0 fail:0 skip:21
fi-ivb-3770 total:252 pass:231 dwarn:0 dfail:0 fail:0 skip:21
fi-kbl-7500u total:252 pass:229 dwarn:0 dfail:0 fail:2 skip:21
fi-skl-6260u total:252 pass:239 dwarn:0 dfail:0 fail:0 skip:13
fi-skl-6700hq total:252 pass:232 dwarn:0 dfail:0 fail:0 skip:20
fi-skl-6700k total:252 pass:227 dwarn:4 dfail:0 fail:0 skip:21
fi-skl-6770hq total:252 pass:239 dwarn:0 dfail:0 fail:0 skip:13
fi-snb-2520m total:252 pass:221 dwarn:0 dfail:0 fail:0 skip:31
fi-snb-2600 total:252 pass:220 dwarn:0 dfail:0 fail:0 skip:32
f16ae7c1a991f75b262b26986513c810d82454a6 drm-tip: 2017y-02m-09d-10h-06m-44s UTC integration manifest
64e3183 drm/i915: Assert that we never create a vma for the aliasing_ppgtt
== Logs ==
For more details see: https://intel-gfx-ci.01.org/CI/Patchwork_3753/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: ✓ Fi.CI.BAT: success for drm/i915: Assert that we never create a vma for the aliasing_ppgtt
2017-02-09 12:52 ` ✓ Fi.CI.BAT: success for " Patchwork
@ 2017-02-09 13:13 ` Chris Wilson
0 siblings, 0 replies; 4+ messages in thread
From: Chris Wilson @ 2017-02-09 13:13 UTC (permalink / raw)
To: intel-gfx
On Thu, Feb 09, 2017 at 12:52:14PM -0000, Patchwork wrote:
> == Series Details ==
>
> Series: drm/i915: Assert that we never create a vma for the aliasing_ppgtt
> URL : https://patchwork.freedesktop.org/series/19370/
> State : success
>
> == Summary ==
>
> Series 19370v1 drm/i915: Assert that we never create a vma for the aliasing_ppgtt
> https://patchwork.freedesktop.org/api/1.0/series/19370/revisions/1/mbox/
>
>
> fi-bdw-5557u total:252 pass:238 dwarn:0 dfail:0 fail:0 skip:14
> fi-bsw-n3050 total:252 pass:213 dwarn:0 dfail:0 fail:0 skip:39
> fi-bxt-j4205 total:252 pass:230 dwarn:0 dfail:0 fail:0 skip:22
> fi-bxt-t5700 total:83 pass:70 dwarn:0 dfail:0 fail:0 skip:12
> fi-byt-j1900 total:252 pass:225 dwarn:0 dfail:0 fail:0 skip:27
> fi-byt-n2820 total:252 pass:221 dwarn:0 dfail:0 fail:0 skip:31
> fi-hsw-4770 total:252 pass:233 dwarn:0 dfail:0 fail:0 skip:19
> fi-hsw-4770r total:252 pass:233 dwarn:0 dfail:0 fail:0 skip:19
> fi-ilk-650 total:252 pass:199 dwarn:0 dfail:0 fail:0 skip:53
> fi-ivb-3520m total:252 pass:231 dwarn:0 dfail:0 fail:0 skip:21
> fi-ivb-3770 total:252 pass:231 dwarn:0 dfail:0 fail:0 skip:21
> fi-kbl-7500u total:252 pass:229 dwarn:0 dfail:0 fail:2 skip:21
> fi-skl-6260u total:252 pass:239 dwarn:0 dfail:0 fail:0 skip:13
> fi-skl-6700hq total:252 pass:232 dwarn:0 dfail:0 fail:0 skip:20
> fi-skl-6700k total:252 pass:227 dwarn:4 dfail:0 fail:0 skip:21
> fi-skl-6770hq total:252 pass:239 dwarn:0 dfail:0 fail:0 skip:13
> fi-snb-2520m total:252 pass:221 dwarn:0 dfail:0 fail:0 skip:31
> fi-snb-2600 total:252 pass:220 dwarn:0 dfail:0 fail:0 skip:32
Pushed, thanks for the review
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-02-09 13:13 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-02-09 11:19 [PATCH] drm/i915: Assert that we never create a vma for the aliasing_ppgtt Chris Wilson
2017-02-09 11:45 ` Joonas Lahtinen
2017-02-09 12:52 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-02-09 13:13 ` Chris Wilson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox