From: "Pandiyan, Dhinakaran" <dhinakaran.pandiyan@intel.com>
To: "chris@chris-wilson.co.uk" <chris@chris-wilson.co.uk>
Cc: "daniel.vetter@ffwll.ch" <daniel.vetter@ffwll.ch>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"bskeggs@redhat.com" <bskeggs@redhat.com>,
"alexander.deucher@amd.com" <alexander.deucher@amd.com>,
"harry.wentland@amd.com" <harry.wentland@amd.com>,
"Lankhorst, Maarten" <maarten.lankhorst@intel.com>
Subject: Re: [PATCH v3 4/8] drm: Add driver-private objects to atomic state
Date: Thu, 9 Feb 2017 18:57:45 +0000 [thread overview]
Message-ID: <1486667765.32142.9.camel@dk-H97M-D3H> (raw)
In-Reply-To: <20170209080836.GF11545@nuc-i3427.alporthouse.com>
On Thu, 2017-02-09 at 08:08 +0000, Chris Wilson wrote:
> On Wed, Feb 08, 2017 at 10:38:07PM -0800, Dhinakaran Pandiyan wrote:
> > +#define for_each_private_obj(__state, obj_funcs, obj, obj_state, __i, __funcs) \
> > + for ((__i) = 0; \
> > + (__i) < (__state)->num_private_objs && \
> > + ((obj) = (__state)->private_objs[__i].obj, \
> > + (__funcs) = (__state)->private_objs[__i].funcs, \
> > + (obj_state) = (__state)->private_objs[__i].obj_state, 1); \
>
> Align to ( and put the trailing 1 on its own line so it stands out.
Sure, will do that. Looks like I have to change other macros in that
file too.
-DK
>
> (__i) < (__state)->num_private_objs && \
> ((obj) = (__state)->private_objs[__i].obj, \
> (__funcs) = (__state)->private_objs[__i].funcs, \
> (obj_state) = (__state)->private_objs[__i].obj_state, \
> 1); \
> (__i)++) \
> > + for_each_if (__funcs == obj_funcs)
> > +
> > +/**
> > * drm_atomic_crtc_needs_modeset - compute combined modeset need
> > * @state: &drm_crtc_state for the CRTC
> > *
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-02-09 18:57 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-09 6:38 [PATCH v3 0/8] Adding driver-private objects to atomic state Dhinakaran Pandiyan
2017-02-09 6:38 ` [PATCH v3 1/8] drm/dp: Kill total_pbn and total_slots in struct drm_dp_mst_topology_mgr Dhinakaran Pandiyan
2017-02-09 6:38 ` [PATCH v3 2/8] drm/dp: Kill unused MST vcpi slot availability tracking Dhinakaran Pandiyan
2017-02-09 6:38 ` [PATCH v3 3/8] drm/dp: Split drm_dp_mst_allocate_vcpi Dhinakaran Pandiyan
2017-02-09 6:38 ` [PATCH v3 4/8] drm: Add driver-private objects to atomic state Dhinakaran Pandiyan
2017-02-09 8:08 ` Chris Wilson
2017-02-09 18:57 ` Pandiyan, Dhinakaran [this message]
2017-02-15 11:23 ` Archit Taneja
2017-02-16 0:13 ` Pandiyan, Dhinakaran
2017-02-17 10:07 ` Archit Taneja
2017-02-22 0:01 ` Pandiyan, Dhinakaran
2017-02-22 4:29 ` Archit Taneja
2017-02-22 21:10 ` Pandiyan, Dhinakaran
2017-02-26 19:57 ` Daniel Vetter
2017-02-27 18:51 ` Pandiyan, Dhinakaran
2017-03-02 22:31 ` Pandiyan, Dhinakaran
2017-02-09 6:38 ` [PATCH v3 5/8] drm/dp: Introduce MST topology state to track available link bandwidth Dhinakaran Pandiyan
2017-02-09 6:38 ` [PATCH v3 6/8] drm/dp: Add DP MST helpers to atomically find and release vcpi slots Dhinakaran Pandiyan
2017-02-09 6:38 ` [PATCH v3 7/8] drm: Connector helper function to release resources Dhinakaran Pandiyan
2017-02-09 9:01 ` Lankhorst, Maarten
2017-02-09 18:55 ` Pandiyan, Dhinakaran
2017-02-13 9:05 ` Lankhorst, Maarten
2017-02-13 21:26 ` Pandiyan, Dhinakaran
2017-02-13 22:48 ` Pandiyan, Dhinakaran
2017-02-20 9:40 ` Lankhorst, Maarten
2017-02-14 19:51 ` Daniel Vetter
2017-02-14 22:29 ` Pandiyan, Dhinakaran
2017-02-16 9:09 ` Lankhorst, Maarten
2017-02-24 0:52 ` Pandiyan, Dhinakaran
2017-02-26 20:00 ` [Intel-gfx] " Daniel Vetter
2017-02-27 7:42 ` Lankhorst, Maarten
2017-02-09 6:38 ` [PATCH v3 8/8] drm/dp: Track MST link bandwidth Dhinakaran Pandiyan
2017-02-09 8:03 ` ✓ Fi.CI.BAT: success for Adding driver-private objects to atomic state Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1486667765.32142.9.camel@dk-H97M-D3H \
--to=dhinakaran.pandiyan@intel.com \
--cc=alexander.deucher@amd.com \
--cc=bskeggs@redhat.com \
--cc=chris@chris-wilson.co.uk \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=harry.wentland@amd.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=maarten.lankhorst@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox