From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joonas Lahtinen Subject: Re: [RFC/CI] drm/i915: Sanitize GuC client initialization Date: Tue, 14 Feb 2017 15:21:47 +0200 Message-ID: <1487078507.3057.34.camel@linux.intel.com> References: <1486733410-14366-1-git-send-email-joonas.lahtinen@linux.intel.com> <50898d22-3fa8-d612-5cd1-1253bcfe86a1@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id 908CE6E6EC for ; Tue, 14 Feb 2017 13:21:50 +0000 (UTC) In-Reply-To: <50898d22-3fa8-d612-5cd1-1253bcfe86a1@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniele Ceraolo Spurio , Intel graphics driver community testing & development List-Id: intel-gfx@lists.freedesktop.org T24gcGUsIDIwMTctMDItMTAgYXQgMTE6NTUgLTA4MDAsIERhbmllbGUgQ2VyYW9sbyBTcHVyaW8g d3JvdGU6Cj4gCj4gT24gMTAvMDIvMTcgMDU6MzAsIEpvb25hcyBMYWh0aW5lbiB3cm90ZToKCjxT TklQPgoKPiA+ICtzdGF0aWMgYm9vbCBfX3Rlc3RfZG9vcmJlbGwoc3RydWN0IGk5MTVfZ3VjX2Ns aWVudCAqY2xpZW50KQo+ID4gK3sKPiA+ICsJcmV0dXJuIHRlc3RfYml0KGNsaWVudC0+ZG9vcmJl bGxfaWQsIGNsaWVudC0+Z3VjLT5kb29yYmVsbF9iaXRtYXApOwo+ID4gK30KPiAKPiBiaWtlc2hl ZDogdGhpcyBoZWxwZXIgaXMgb25seSB1c2VkIGluIG9uZSBwbGFjZSBpbnNpZGUgYSB2ZXJ5IHNt YWxswqAKPiBmdW5jdGlvbiwgc28gSSdkIHByZWZlciB0byBkcm9wIGl0LgoKR29vZCBjYXRjaCwg dGhlIG5lZWQgZGlzYXBwZWFyZWQgZHVyaW5nIHJlZmFjdG9yaW5nLgoKPiAKPiA+IAo+ID4gKwo+ ID4gK3N0YXRpYyB2b2lkIF9fcmVsZWFzZV9kb29yYmVsbChzdHJ1Y3QgaTkxNV9ndWNfY2xpZW50 ICpjbGllbnQpCj4gCj4gYmlrZXNoZWQ6IGluIG90aGVyIHBsYWNlcyB3ZSB1c2UgInVucmVzZXJ2 ZSIgaW5zdGVhZCBvZiAicmVsZWFzZSIgZm9ywqAKPiB0aGUgc3ltbWV0cmljYWwgZnVuY3Rpb24g b2YgInJlc2VydmUiLiBUaGF0IHdvdWxkIGJlIGNsZWFyZXIgaGVyZSBhc8KgCj4gd2VsbCBJTUhP LgoKVGhhdCdzIHRydWUsIGZpeGVkLgoKPiAKPiA+IAo+ID4gK3sKPiA+ICsJR0VNX0JVR19PTihj bGllbnQtPmRvb3JiZWxsX2lkID09IEdVQ19ET09SQkVMTF9JTlZBTElEKTsKPiA+ICsKPiA+ICsJ X19jbGVhcl9iaXQoY2xpZW50LT5kb29yYmVsbF9pZCwgY2xpZW50LT5ndWMtPmRvb3JiZWxsX2Jp dG1hcCk7Cj4gCj4gSSB3b3VsZCBzZXQgY2xpZW50LT5kb29yYmVsbF9pZCA9IEdVQ19ET09SQkVM TF9JTlZBTElEIGhlcmUuCgpZZWFoLCBpdCdzIGJldHRlciBmb3Igc3ltbWV0cnksIGZpeGVkIHRo YXQuCgo+ID4gK3N0YXRpYyBpbnQgX19yZXNlcnZlX2Rvb3JiZWxsKHN0cnVjdCBpOTE1X2d1Y19j bGllbnQgKmNsaWVudCkKPiA+ICt7Cj4gPiArCXVuc2lnbmVkIGxvbmcgb2Zmc2V0Owo+ID4gKwl1 bnNpZ25lZCBsb25nIGVuZDsKPiA+ICsJdTE2IGlkOwo+ID4gKwo+ID4gKwlHRU1fQlVHX09OKGNs aWVudC0+ZG9vcmJlbGxfaWQgIT0gR1VDX0RPT1JCRUxMX0lOVkFMSUQpOwo+ID4gKwo+ID4gKwkv Kgo+ID4gKwnCoCogVGhlIGJpdG1hcCB0cmFja3Mgd2hpY2ggZG9vcmJlbGwgcmVnaXN0ZXJzIGFy ZSBjdXJyZW50bHkgaW4gdXNlLgo+ID4gKwnCoCogSXQgaXMgc3BsaXQgaW50byB0d28gaGFsdmVz OyB0aGUgZmlyc3QgaGFsZiBpcyB1c2VkIGZvciBub3JtYWwKPiA+ICsJwqAqIHByaW9yaXR5IGNv bnRleHRzLCB0aGUgc2Vjb25kIGhhbGYgZm9yIGhpZ2gtcHJpb3JpdHkgb25lcy4KPiA+ICsJwqAq IE5vdGUgdGhhdCBsb2dpY2FsbHkgaGlnaGVyIHByaW9yaXRpZXMgYXJlIG51bWVyaWNhbGx5IGxl c3MgdGhhbgo+ID4gKwnCoCogbm9ybWFsIG9uZXMsIHNvIHRoZSB0ZXN0IGJlbG93IG1lYW5zICJp cyBpdCBoaWdoLXByaW9yaXR5PyIKPiA+ICsJwqAqLwo+ID4gKwo+ID4gKwlvZmZzZXQgPSAwOwo+ ID4gKwlpZiAoaXNfaGlnaF9wcmlvcml0eShjbGllbnQpKQo+ID4gKwkJb2Zmc2V0ID0gR1VDX05V TV9ET09SQkVMTFMvMjsKPiA+ICsKPiA+ICsJZW5kID0gR1VDX05VTV9ET09SQkVMTFMgLSBvZmZz ZXQ7Cj4gCj4gU2hvdWxkIHRoaXMgYmUKPiAKPiAJZW5kID0gb2Zmc2V0ICsgR1VDX05VTV9ET09S QkVMTFMvMjsKPiAKPiA/Cj4gCj4gT3RoZXJ3aXNlIGlmIG9mZnNldD0wIHlvdSdsbCBoYXZlIGVu ZD1HVUNfTlVNX0RPT1JCRUxMUwoKV2hvb3BzLCBmaXhlZCA6KQoKPiA+IEBAIC05NSwxMDQgKzE0 NCwxMTQgQEAgc3RhdGljIGludCBndWNfcmVsZWFzZV9kb29yYmVsbChzdHJ1Y3QgaW50ZWxfZ3Vj ICpndWMsCj4gPiDCoCAqIGNsaWVudCBvYmplY3Qgd2hpY2ggY29udGFpbnMgdGhlIHBhZ2UgYmVp bmcgdXNlZCBmb3IgdGhlIGRvb3JiZWxsCj4gPiDCoCAqLwo+ID4gCj4gPiAtc3RhdGljIGludCBn dWNfdXBkYXRlX2Rvb3JiZWxsX2lkKHN0cnVjdCBpbnRlbF9ndWMgKmd1YywKPiA+IC0JCQkJwqDC oHN0cnVjdCBpOTE1X2d1Y19jbGllbnQgKmNsaWVudCwKPiA+IC0JCQkJwqDCoHUxNiBuZXdfaWQp Cj4gPiArc3RhdGljIGludCBfX3VwZGF0ZV9kb29yYmVsbChzdHJ1Y3QgaTkxNV9ndWNfY2xpZW50 ICpjbGllbnQsIHUxNiBuZXdfaWQpCj4gCj4gSSdkIHByZWZlciB0aGlzIHRvIGJlIGNhbGxlZCBf X3VwZGF0ZV9kb29yYmVsbF9pZCBvcsKgCj4gX191cGRhdGVfZG9vcmJlbGxfZGVzYywgdG8gbWFr ZSBpdCBjbGVhciB0aGF0IGl0IGlzIGp1c3QgY2hhbmdpbmcgdGhlIGlkwqAKPiBpbiB0aGUgZGVz Y3JpcHRvciBhbmQgbm90IGRvaW5nIGFueSByZS1hbGxvY2F0aW9uIG9mIHRoZSBkb29yYmVsbC4K Cl9fdXBkYXRlX2Rvb3JiZWxsX2Rlc2MgaXQgaXMgKEknZCBsaWtlIHRvIHNwbGl0IGRvb3JiZWxs IHZzLiBjbGllbnQgdG8KdGhlaXIgb3duIHN0cnVjdHMsIGJ1dCBsZXRzIGxlYXZlIHRoYXQgZm9y IGxhdGVyKS4KClRoaXMgb25seSBnZXRzIGNhbGxlZCBkdXJpbmcKCj4gPiAtc3RhdGljIHZvaWQg Z3VjX2luaXRfZG9vcmJlbGxfaHcoc3RydWN0IGludGVsX2d1YyAqZ3VjKQo+ID4gK3N0YXRpYyBp bnQgZ3VjX2luaXRfZG9vcmJlbGxfaHcoc3RydWN0IGludGVsX2d1YyAqZ3VjKQo+ID4gwqB7Cj4g PiDCoAlzdHJ1Y3QgaTkxNV9ndWNfY2xpZW50ICpjbGllbnQgPSBndWMtPmV4ZWNidWZfY2xpZW50 Owo+ID4gLQl1aW50MTZfdCBkYl9pZDsKPiA+IC0JaW50IGksIGVycjsKPiA+ICsJaW50IGVycjsK PiA+ICsJaW50IGk7Cj4gPiAKPiA+IC0JZ3VjX2Rpc2FibGVfZG9vcmJlbGwoZ3VjLCBjbGllbnQp Owo+ID4gKwlpZiAoaGFzX2Rvb3JiZWxsKGNsaWVudCkpCj4gPiArCQlkZXN0cm95X2Rvb3JiZWxs KGNsaWVudCk7Cj4gPiAKPiA+IC0JZm9yIChpID0gMDsgaSA8IEdVQ19NQVhfRE9PUkJFTExTOyAr K2kpIHsKPiA+IC0JCS8qIFNraXAgaWYgZG9vcmJlbGwgaXMgT0sgKi8KPiA+IC0JCWlmIChndWNf ZG9vcmJlbGxfY2hlY2soZ3VjLCBpKSkKPiA+ICsJZm9yIChpID0gMDsgaSA8IEdVQ19OVU1fRE9P UkJFTExTOyArK2kpIHsKPiA+ICsJCWlmIChkb29yYmVsbF9vayhndWMsIGkpKQo+ID4gwqAJCQlj b250aW51ZTsKPiA+IAo+ID4gLQkJZXJyID0gZ3VjX3VwZGF0ZV9kb29yYmVsbF9pZChndWMsIGNs aWVudCwgaSk7Cj4gPiAtCQlpZiAoZXJyKQo+ID4gLQkJCURSTV9ERUJVR19EUklWRVIoIkRvb3Ji ZWxsICVkIHVwZGF0ZSBmYWlsZWQsIGVyciAlZFxuIiwKPiA+IC0JCQkJCWksIGVycik7Cj4gPiAr CQllcnIgPSBfX3Jlc2V0X2Rvb3JiZWxsKGNsaWVudCwgaSk7Cj4gCj4gTm90IHN1cmUgYWJvdXQg dGhlIGxvZ2ljIGhlcmUuIElmIHRoZSBkb29yYmVsbCBpcyBhY3RpdmUgd2hlbiBpdMKgCj4gc2hv dWxkbid0IGhhdmUgYmVlbiwgX19yZXNldF9kb29yYmVsbCB3aWxsIHRyeSB0byBhY3F1aXJlIHRo ZSBkb29yYmVsbMKgCj4gYmVmb3JlIHJlbGVhc2luZyBpdCwgd2hpY2ggd2lsbCBmYWlsIGlmIHRo ZSBkb29yYmVsbCBpcyBhY3RpdmUgKHRodXPCoAo+IGFsc28gc2tpcHBpbmcgdGhlIHJlbGVhc2Vf ZG9vcmJlbGwgc3RlcCkuIElmIHRoZSBkb29yYmVsbCBpcyBub3QgYWN0aXZlwqAKPiB3aGVuIGl0 IHNob3VsZCBoYXZlIGJlZW4sIF9fcmVzZXRfZG9vcmJlbGwgd2lsbCBzdGlsbCBsZWF2ZSBpdMKg Cj4gZGVhY3RpdmF0ZWQuIElmIHdlIGNhcmUgYWJvdXQgYm90aCBjYXNlcyBtYXliZSB3ZSBzaG91 bGQgc3BlY2lhbGl6ZSB0aGXCoAo+IGhhbmRsaW5nIGZvciB0aGUgMiBwb3NzaWJsZSBzY2VuYXJp b3MsIHdoaWxlIGlmIHdlIGNhcmUgb25seSBhYm91dCB0aGXCoAo+IGZpcnN0IG9uZSB3ZSBzaG91 bGQgcmVsZWFzZSB0aGUgZG9vcmJlbGwgZmlyc3QgKG5vdCBzdXJlIGlmIHdlIHN0aWxswqAKPiB3 YW50IHRvIGRvIGEgc2V0dXAgJiB0ZWFyLWRvd24gY3ljbGUgYWZ0ZXJ3YXJkcykuCj4gCj4gVGhl IG9yaWdpbmFsIGxvZ2ljIGxvb2tzIGFsc28gaW5jb3JyZWN0IGJlY2F1c2UgZ3VjX3VwZGF0ZV9k b29yYmVsbF9pZMKgCj4gd2lsbCBhbHdheXMgZW5hYmxlIHRoZSBkb29yYmVsbCBhdCB0aGUgZW5k LgoKSSB3YXMgYXNzdW1pbmcgd2Ugd2FudCB0byBkZWFjdGl2YXRlIGFsbCBkb29yYmVsbHMgZnJv bSB0aGUgaGFyZHdhcmUgaWYKdGhleSBhcmUgYWN0aXZlIChiZWNhdXNlIHRoZXkgd291bGQgYmUg c3RhbGUgZW50cmllcykuIElmIHRoZXJlIGFyZSBubwpvdGhlciB1c2VycyB0aGFuIHRoZSBLTUQs IHRoZW4gdGhhdCdkIGJlIHRoZSBhcHByb3ByaWF0ZSBhY3Rpb24sIGFuZApyZW5hbWUgZG9vcmJl bGxfb2sgY2hlY2sgaW50byBkb29yYmVsbF9hY3RpdmUsIGFuZCBqdXN0IG51a2UgZXZlcnl0aGlu ZwphY3RpdmUgb25jZSBsb2FkaW5nPwoKPiA+ICsJCVdBUk4oZXJyLCAiRG9vcmJlbGwgJWQgcmVz ZXQgZmFpbGVkLCBlcnIgJWRcbiIsIGksIGVycik7Cj4gPiDCoAl9Cj4gPiAKPiA+IC0JZGJfaWQg PSBzZWxlY3RfZG9vcmJlbGxfcmVnaXN0ZXIoZ3VjLCBjbGllbnQtPnByaW9yaXR5KTsKPiA+IC0J V0FSTl9PTihkYl9pZCA9PSBHVUNfSU5WQUxJRF9ET09SQkVMTF9JRCk7Cj4gPiAtCj4gPiAtCWVy ciA9IGd1Y191cGRhdGVfZG9vcmJlbGxfaWQoZ3VjLCBjbGllbnQsIGRiX2lkKTsKPiA+ICsJZXJy ID0gX19yZXNlcnZlX2Rvb3JiZWxsKGNsaWVudCk7Cj4gCj4gCj4gU2hvdWxkbid0IHRoaXMgYmUg Y3JlYXRlX2Rvb3JiZWxsKCkgaW5zdGVhZCBvZiByZXNlcnZlPwoKVGhhdCB3b3VsZCBlbmQgdXAg Y2FsbGluZyB0aGUgX191cGRhdGVfZG9vcmJlbGwsIHdoaWNoIHdlIGNhbid0IGFzIHRoZQpkZXNj IGlzIGZvciBzb21lIHN0cmFuZ2UgcmVhc29uIG5vdCBtYXBwZWQgeWV0LiBJIHRoaW5rIHlvdSBz ZW50IGEKcGF0Y2ggdG8gbW92ZSBpbnRlbF9ndWNfYWxsb2NhdGVfdm1hIGludG8gdGhlIGluaXQs IHNvIGxldCBtZSBnaXZlIGl0IGEKbG9vay4KCldoaWNoIGJyaW5ncyB1cyB0byB0aGUgcG9pbnQg dGhhdCBJIGZvcmdvdCB0byBjYWxsIF9fdXBkYXRlX2Rvb3JiZWxsCmNvbXBsZXRlbHkhCgpSZWdh cmRzLCBKb29uYXMKLS3CoApKb29uYXMgTGFodGluZW4KT3BlbiBTb3VyY2UgVGVjaG5vbG9neSBD ZW50ZXIKSW50ZWwgQ29ycG9yYXRpb24KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJl ZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGlu Zm8vaW50ZWwtZ2Z4Cg==