From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joonas Lahtinen Subject: Re: [RFC/CI] drm/i915: Sanitize GuC client initialization Date: Tue, 14 Feb 2017 15:51:33 +0200 Message-ID: <1487080293.3057.46.camel@linux.intel.com> References: <1486733410-14366-1-git-send-email-joonas.lahtinen@linux.intel.com> <20170210151148.GA56152@mwajdecz-MOBL1.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6D1696E715 for ; Tue, 14 Feb 2017 13:51:38 +0000 (UTC) In-Reply-To: <20170210151148.GA56152@mwajdecz-MOBL1.ger.corp.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Michal Wajdeczko Cc: Intel graphics driver community testing & development List-Id: intel-gfx@lists.freedesktop.org T24gcGUsIDIwMTctMDItMTAgYXQgMTY6MTEgKzAxMDAsIE1pY2hhbCBXYWpkZWN6a28gd3JvdGU6 Cj4gT24gRnJpLCBGZWIgMTAsIDIwMTcgYXQgMDM6MzA6MTBQTSArMDIwMCwgSm9vbmFzIExhaHRp bmVuIHdyb3RlOgo+ID4gCj4gPiBTdGFydGVkIGFkZGluZyBwcm9wZXIgdGVhcmRvd24gdG8gZ3Vj X2NsaWVudF9hbGxvYywgZW5kZWQgdXAgcmVtb3ZpbmcKPiA+IHF1aXRlIGEgZmV3IGRlYWQgZW5k cyB3aGVyZSBlcnJvcnMgY29tbXVuaWNhdGluZyB3aXRoIHRoZSBHdUMgd2VyZQo+ID4gc2lsZW50 bHkgaWdub3JlZC4gVGhlcmUgYWxzbyBzZWVtZWQgdG8gYmUgcXVpdGUgYSBmZXcgZXJyb25vdXMK PiA+IHRlYXJkb3duIGFjdGlvbnMgcGVyZm9ybWVkIGluIGNhc2Ugb2YgYW4gZXJyb3IgKG9yZGVy aW5nIHdyb25nKS4KPiA+IAo+ID4gU2lnbmVkLW9mZi1ieTogSm9vbmFzIExhaHRpbmVuIDxqb29u YXMubGFodGluZW5AbGludXguaW50ZWwuY29tPgo+ID4gQ2M6IE1pY2hhbCBXYWpkZWN6a28gPG1p Y2hhbC53YWpkZWN6a29AaW50ZWwuY29tPgo+ID4gQ2M6IEFya2FkaXVzeiBIaWxlciA8YXJrYWRp dXN6LmhpbGVyQGludGVsLmNvbT4KPiA+IENjOiBPc2NhciBNYXRlbyA8b3NjYXIubWF0ZW9AaW50 ZWwuY29tPgo+ID4gQ2M6IFR2cnRrbyBVcnN1bGluIDx0dnJ0a28udXJzdWxpbkBpbnRlbC5jb20+ Cj4gPiBDYzogQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+Cgo8U05JUD4K Cj4gZXhwbGljaXQgaW5saW5lID8gb3IgeW91IHdhbnQgdG8gbGV0IGdjYyBkZWNpZGUgPwoKR0ND IHNob3VsZCBkbyBpdCwgdGhlc2UgYXJlIG5vdCBob3QgcGF0aCBmdW5jdGlvbnMuCgrCoAo+ID4g LXN0YXRpYyBpbnQgZ3VjX2FsbG9jYXRlX2Rvb3JiZWxsKHN0cnVjdCBpbnRlbF9ndWMgKmd1YywK PiA+IC0JCQkJwqBzdHJ1Y3QgaTkxNV9ndWNfY2xpZW50ICpjbGllbnQpCj4gPiArc3RhdGljIGlu dCBfX2NyZWF0ZV9kb29yYmVsbF9odyhzdHJ1Y3QgaTkxNV9ndWNfY2xpZW50ICpjbGllbnQpCj4g Cj4gSSB3b3VsZCByYXRoZXIgcHJlZmVyIHRvIG9ubHkgY2hhbmdlIHNpZ25hdHVyZSBvZiB0aGlz IGZ1bmN0aW9uIGludG8KPiAKPiAJc3RhdGljIGludCBndWNfYWxsb2NhdGVfZG9vcmJlbGwoc3Ry dWN0IGludGVsX2d1YyAqZ3VjLCB1MzIgaW5kZXgpCj4gCj4gYXMgYSBjbGVhbiB3cmFwIGFyb3Vu ZCBHVUNfQUNUSU9OX0FMTE9DQVRFX0RPT1JCRUxMLiBUaGlzIHdheSB3ZSBhbHNvIHByZXNlcnZl Cj4gY29uc2lzdGVuY3kgYmV0d2VlbiBmdW5jdGlvbiBuYW1lIGFuZCB0aGUgZ3VjIGFjdGlvbiBu YW1lIHVzZWQgaW5zaWRlLgo+IAo+IEJhc2VkIG9uIHRoZSBhYm92ZSB3ZSBjYW4gc3RpbGwgYWRk wqAKPiAKPiAJc3RhdGljIGludCBfX2NyZWF0ZV9kb29yYmVsbF9odyhzdHJ1Y3QgaTkxNV9ndWNf Y2xpZW50ICpjbGllbnQpCj4gCXsKPiA+IAkJcmV0dXJuIGd1Y19hbGxvY2F0ZV9kb29yYmVsbChj bGllbnQtPmd1YywgY2xpZW50LT5jdHhfaW5kZXgpOwo+IAl9Cj4gCj4gTm90ZSB0aGF0IGxvY2F0 aW9uIG9mIHRoZSBjdHhfaW5kZXggbWVtYmVyIG1heSBjaGFuZ2UgaW4gdGhlIGZ1dHVyZSwgYW5k IHRoaXMKPiBhcHByb2FjaCB3aWxsIG1pbmltaXplIGltcGFjdCBvZiB0aGVzZSBmdXR1cmUgY2hh bmdlcy4KClRoYXQncyB2aWFibGUsIEkgbWFkZSBpdDsKCl9fZ3VjX2FsbG9jYXRlX2Rvb3JiZWxs KGd1YywgY2xpZW50LT5jdHhfaW5kZXgpCgpTbyBpdCBjYW4gYmVtb3ZlZCBvdXQgb2YgdGhlIHN1 Ym1pc3Npb24gY29kZSBpbiBmdXR1cmUuCgo+ID4gK3N0YXRpYyBib29sIGhhc19kb29yYmVsbChz dHJ1Y3QgaTkxNV9ndWNfY2xpZW50ICpjbGllbnQpCj4gPiArewo+ID4gKwlpZiAoY2xpZW50LT5k b29yYmVsbF9pZCA9PSBHVUNfRE9PUkJFTExfSU5WQUxJRCkKPiA+ICsJCXJldHVybiBmYWxzZTsK PiA+ICsKPiA+ICsJcmV0dXJuIF9fdGVzdF9kb29yYmVsbChjbGllbnQpOwo+ID4gK30KPiAKPiBD YW4gd2Uga2VlcCByZWxhdGVkIGlubGluZSBoZWxwZXJzIHRvZ2V0aGVyID8KCk1vdmVkLgrCoAo+ ID4gLXN0YXRpYyB2b2lkIGd1Y19kaXNhYmxlX2Rvb3JiZWxsKHN0cnVjdCBpbnRlbF9ndWMgKmd1 YywKPiA+IC0JCQkJwqBzdHJ1Y3QgaTkxNV9ndWNfY2xpZW50ICpjbGllbnQpCj4gPiArLyoKPiA+ ICtzdGF0aWMgaW50IGNyZWF0ZV9kb29yYmVsbChzdHJ1Y3QgaTkxNV9ndWNfY2xpZW50ICpjbGll bnQpCj4gPiDCoHsKPiA+IC0JKHZvaWQpZ3VjX3VwZGF0ZV9kb29yYmVsbF9pZChndWMsIGNsaWVu dCwgR1VDX0lOVkFMSURfRE9PUkJFTExfSUQpOwo+ID4gKwlpbnQgZXJyOwo+ID4gwqAKPiA+IC0J LyogWFhYOiB3YWl0IGZvciBhbnkgaW50ZXJydXB0cyAqLwo+ID4gLQkvKiBYWFg6IHdhaXQgZm9y IHdvcmtxdWV1ZSB0byBkcmFpbiAqLwo+ID4gKwlHRU1fQlVHX09OKGhhc19kb29yYmVsbChjbGll bnQpKTsKPiA+ICsKPiA+ICsJZXJyID0gX19yZXNlcnZlX2Rvb3JiZWxsKGNsaWVudCk7Cj4gPiAr CWlmIChlcnIpCj4gPiArCQlyZXR1cm4gZXJyOwo+ID4gKwo+ID4gKwlyZXR1cm4gX19jcmVhdGVf ZG9vcmJlbGwoY2xpZW50KTsKPiA+IMKgfQo+ID4gKyovCj4gCj4gV3JvbmcgY29tbWl0ID8KCk51 a2VkLgoKPiA+IC1zdGF0aWMgdm9pZAo+ID4gLWd1Y19jbGllbnRfZnJlZShzdHJ1Y3QgZHJtX2k5 MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4gPiAtCQlzdHJ1Y3QgaTkxNV9ndWNfY2xpZW50ICpjbGll bnQpCj4gPiArc3RhdGljIHZvaWQgZ3VjX2NsaWVudF9mcmVlKHN0cnVjdCBpOTE1X2d1Y19jbGll bnQgKmNsaWVudCkKPiA+IMKgewo+ID4gLQlzdHJ1Y3QgaW50ZWxfZ3VjICpndWMgPSAmZGV2X3By aXYtPmd1YzsKPiAKPiBXZSB1c2UgZ3VjIGZldyB0aW1lcywgc28gbWF5YmUgd2UgY2FuIGxlYXZl IGl0IGFzCj4gCj4gCWd1YyA9IGNsaWVudC0+Z3VjOwoKV2FudGVkIHRvIG1ha2UgaXQgZXhwbGlj aXQgdGhhdCB0aGVyZSBhcmUgYmVoaW5kIHRoZSBzY2VuZXMgY29udHJhY3RzCihhbGxvY2F0ZWQg ZG9vcmJlbGxzKSBiZXR3ZWVuIHRoZSBjbGllbnQgYW5kIGd1Yy4KCj4gPiArCVdBUk5fT04oZGVz dHJveV9kb29yYmVsbChjbGllbnQpKTsKPiA+ICsJZ3VjX2N0eF9kZXNjX2ZpbmkoY2xpZW50LT5n dWMsIGNsaWVudCk7Cj4gPiArCWk5MTVfZ2VtX29iamVjdF91bnBpbl9tYXAoY2xpZW50LT52bWEt Pm9iaik7Cj4gPiDCoAlpOTE1X3ZtYV91bnBpbl9hbmRfcmVsZWFzZSgmY2xpZW50LT52bWEpOwo+ ID4gLQo+ID4gLQlpZiAoY2xpZW50LT5jdHhfaW5kZXggIT0gR1VDX0lOVkFMSURfQ1RYX0lEKSB7 Cj4gPiAtCQlndWNfY3R4X2Rlc2NfZmluaShndWMsIGNsaWVudCk7Cj4gPiAtCQlpZGFfc2ltcGxl X3JlbW92ZSgmZ3VjLT5jdHhfaWRzLCBjbGllbnQtPmN0eF9pbmRleCk7Cj4gPiAtCX0KPiA+IC0K PiA+ICsJaWRhX3NpbXBsZV9yZW1vdmUoJmNsaWVudC0+Z3VjLT5jdHhfaWRzLCBjbGllbnQtPmN0 eF9pbmRleCk7Cj4gCj4gV2hhdCBhYm91dCBhZGRpbmcgc21hbGwgaGVscGVyIGZ1bmN0aW9uIGFu ZCB1c2UgaXQgaGVyZSBpbnN0ZWFkIG9mCj4gZGlyZWN0bHkgdG91Y2hpbmcgZ3VjIGludGVybmFs IG1lbWJlcjoKPiAKPiAJZ3VjX3JlbGVhc2VfY2xpZW50X2luZGV4KGd1YywgY2xpZW50LT5jdHhf aW5kZXgpOwoKSSdsbCBhZGQgYSBmb2xsb3ctdXAgdGFzayBmb3IgdGhhdC4KwqAKPiA+IMKgLyog Q2hlY2sgdGhhdCBhIGRvb3JiZWxsIHJlZ2lzdGVyIGlzIGluIHRoZSBleHBlY3RlZCBzdGF0ZSAq Lwo+ID4gLXN0YXRpYyBib29sIGd1Y19kb29yYmVsbF9jaGVjayhzdHJ1Y3QgaW50ZWxfZ3VjICpn dWMsIHVpbnQxNl90IGRiX2lkKQo+ID4gK3N0YXRpYyBib29sIGRvb3JiZWxsX29rKHN0cnVjdCBp bnRlbF9ndWMgKmd1YywgdTggZGJfaWQpCj4gPiDCoHsKPiA+IMKgCXN0cnVjdCBkcm1faTkxNV9w cml2YXRlICpkZXZfcHJpdiA9IGd1Y190b19pOTE1KGd1Yyk7Cj4gPiAtCWk5MTVfcmVnX3QgZHJi cmVnID0gR0VOOF9EUkJSRUdMKGRiX2lkKTsKPiA+IC0JdWludDMyX3QgdmFsdWUgPSBJOTE1X1JF QUQoZHJicmVnKTsKPiA+IC0JYm9vbCBlbmFibGVkID0gKHZhbHVlICYgR1VDX0RPT1JCRUxMX0VO QUJMRUQpICE9IDA7Cj4gPiAtCWJvb2wgZXhwZWN0ZWQgPSB0ZXN0X2JpdChkYl9pZCwgZ3VjLT5k b29yYmVsbF9iaXRtYXApOwo+ID4gwqAKPiA+IC0JaWYgKGVuYWJsZWQgPT0gZXhwZWN0ZWQpCj4g PiArCXUzMiBkcmJyZWdsID0gSTkxNV9SRUFEKEdFTjhfRFJCUkVHTChkYl9pZCkpOwo+ID4gKwo+ ID4gKwlib29sIHZhbGlkID0gZHJicmVnbCAmIEdFTjhfRFJCX1ZBTElEOwo+ID4gKwo+ID4gKwlp ZiAodGVzdF9iaXQoZGJfaWQsIGd1Yy0+ZG9vcmJlbGxfYml0bWFwKSA9PSB2YWxpZCkKPiA+IMKg CQlyZXR1cm4gdHJ1ZTsKPiA+IMKgCj4gPiAtCURSTV9ERUJVR19EUklWRVIoIkRvb3JiZWxsICVk IChyZWcgMHgleCkgMHgleCwgc2hvdWxkIGJlICVzXG4iLAo+ID4gLQkJCcKgZGJfaWQsIGRyYnJl Zy5yZWcsIHZhbHVlLAo+ID4gLQkJCcKgZXhwZWN0ZWQgPyAiYWN0aXZlIiA6ICJpbmFjdGl2ZSIp Owo+ID4gKwlEUk1fREVCVUdfRFJJVkVSKCJEb29yYmVsbCAlZCBoYXMgdW5leHBlY3RlZCBzdGF0 ZSAoMHgleCk6IHZhbGlkPSVzXG4iLAo+ID4gKwkJCcKgZGJfaWQsIGRyYnJlZ2wsIHllc25vKHZh bGlkKSk7Cj4gPiDCoAo+ID4gwqAJcmV0dXJuIGZhbHNlOwo+ID4gwqB9Cj4gPiDCoAo+ID4gK3N0 YXRpYyBpbnQgX19yZXNldF9kb29yYmVsbChzdHJ1Y3QgaTkxNV9ndWNfY2xpZW50KiBjbGllbnQs IHUxNiBkYl9pZCkKPiAKPiBIbW0sIGluIHByZXZpb3VzIGZ1bmN0aW9uIGRiX2lkIHdhcyBkZWNs YXJlZCBhcyB1OC4KClllYWgsIHdvdWxkIGJlIGtpbmRhIG1lYW4gdG8gY2hlY2sgdGhlIHN0YXR1 cyBvZiBHVUNfRE9PUkJFTExfSU5WQUxJRC4KQnV0IGFzIGl0IGp1c3QgaGFwcGVucyB0byB0aGUg Y3VycmVudCBzaXR1YXRpb24sIEkgY2hhbmdlZCB0aGUKZG9vcmJlbGxfb2sgc2lnbmF0dXJlIGFu ZCBhZGRlZCBHRU1fQlVHX09OIGNoZWNrIGZvciBmdXR1cmUgcHJvb2ZpbmcuCgo+ID4gQEAgLTk3 OCw3ICsxMDM4LDcgQEAgdm9pZCBpOTE1X2d1Y19zdWJtaXNzaW9uX2Zpbmkoc3RydWN0IGRybV9p OTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ID4gwqAJaWYgKCFjbGllbnQpCj4gPsKgCQlyZXR1cm47 Cj4gCj4gU2hvdWxkbid0IHdlIGZpeCBpdCBub3cgaW4gdGhpcyBwYXRjaCBhcyB3ZWxsPwo+IAoK SSdkIHdhaXQgZm9yIERhbmllbGUncyBwYXRjaGVzIHRvIGZvciBwZXJzaXRlbnQgZGVzYyBtYXBw aW5nCihhbGxvY2F0aW9uIGlzIGN1cnJlbnRseSBwaGFzZWQgcmF0aGVyIHN0cmFuZ2VseSksIGFu ZCBkaWRuJ3Qgd2FudCB0bwpkdXBsaWNhdGUgd29yay4KClJlZ2FyZHMsIEpvb25hcwotLSAKSm9v bmFzIExhaHRpbmVuCk9wZW4gU291cmNlIFRlY2hub2xvZ3kgQ2VudGVyCkludGVsIENvcnBvcmF0 aW9uCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVs LWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczov L2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=