From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Intel graphics driver community testing & development
<intel-gfx@lists.freedesktop.org>
Subject: Re: [RFC/CI] drm/i915: Sanitize GuC client initialization
Date: Tue, 14 Feb 2017 15:54:59 +0200 [thread overview]
Message-ID: <1487080499.3057.48.camel@linux.intel.com> (raw)
In-Reply-To: <20170210143639.GE7903@nuc-i3427.alporthouse.com>
On pe, 2017-02-10 at 14:36 +0000, Chris Wilson wrote:
> On Fri, Feb 10, 2017 at 03:30:10PM +0200, Joonas Lahtinen wrote:
> >
> > +static unsigned long __reserve_cacheline(struct intel_guc* guc)
> > {
> > - const uint32_t cacheline_size = cache_line_size();
> > - uint32_t offset;
> > + unsigned long offset;
> >
> > /* Doorbell uses a single cache line within a page */
> > offset = offset_in_page(guc->db_cacheline);
>
> But unsigned long? I was trying to work out why we might need unsigned
> long doorbell_offset, for when the doorbell object is of known size.
>
> That's the only thing that stuck out like a sore thumb.
Fixing that type took me for a too long journey, so I aborted mission.
Added a follow-up task.
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-02-14 13:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-10 13:30 [RFC/CI] drm/i915: Sanitize GuC client initialization Joonas Lahtinen
2017-02-10 13:52 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-02-10 14:36 ` [RFC/CI] " Chris Wilson
2017-02-14 13:54 ` Joonas Lahtinen [this message]
2017-02-10 15:11 ` Michal Wajdeczko
2017-02-10 20:03 ` Daniele Ceraolo Spurio
2017-02-14 13:24 ` Joonas Lahtinen
2017-02-14 13:51 ` Joonas Lahtinen
2017-02-10 19:55 ` Daniele Ceraolo Spurio
2017-02-14 13:21 ` Joonas Lahtinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1487080499.3057.48.camel@linux.intel.com \
--to=joonas.lahtinen@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox