* [PATCH] drm/i915: Remove unrequired POSTING_READ from gen6_set_rps()
@ 2017-02-17 8:31 Chris Wilson
2017-02-17 9:22 ` ✗ Fi.CI.BAT: warning for " Patchwork
2017-02-17 10:15 ` [PATCH] " Szwichtenberg, Radoslaw
0 siblings, 2 replies; 3+ messages in thread
From: Chris Wilson @ 2017-02-17 8:31 UTC (permalink / raw)
To: intel-gfx
The uncached mmio is sufficient to queue the mmio writes without raising
forcewake. The forced flush along with acquiring forcewake from the
posting read is not required for adjusting the RPS frequency.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
drivers/gpu/drm/i915/intel_pm.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
index bde7ef3c643e..4e9488bd9c3c 100644
--- a/drivers/gpu/drm/i915/intel_pm.c
+++ b/drivers/gpu/drm/i915/intel_pm.c
@@ -4944,8 +4944,6 @@ static int gen6_set_rps(struct drm_i915_private *dev_priv, u8 val)
I915_WRITE(GEN6_RP_INTERRUPT_LIMITS, intel_rps_limits(dev_priv, val));
I915_WRITE(GEN6_PMINTRMSK, gen6_rps_pm_mask(dev_priv, val));
- POSTING_READ(GEN6_RPNSWREQ);
-
dev_priv->rps.cur_freq = val;
trace_intel_gpu_freq_change(intel_gpu_freq(dev_priv, val));
--
2.11.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 3+ messages in thread
* ✗ Fi.CI.BAT: warning for drm/i915: Remove unrequired POSTING_READ from gen6_set_rps()
2017-02-17 8:31 [PATCH] drm/i915: Remove unrequired POSTING_READ from gen6_set_rps() Chris Wilson
@ 2017-02-17 9:22 ` Patchwork
2017-02-17 10:15 ` [PATCH] " Szwichtenberg, Radoslaw
1 sibling, 0 replies; 3+ messages in thread
From: Patchwork @ 2017-02-17 9:22 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Remove unrequired POSTING_READ from gen6_set_rps()
URL : https://patchwork.freedesktop.org/series/19822/
State : warning
== Summary ==
Series 19822v1 drm/i915: Remove unrequired POSTING_READ from gen6_set_rps()
https://patchwork.freedesktop.org/api/1.0/series/19822/revisions/1/mbox/
Test kms_force_connector_basic:
Subgroup prune-stale-modes:
pass -> SKIP (fi-snb-2600)
fi-bdw-5557u total:252 pass:241 dwarn:0 dfail:0 fail:0 skip:11
fi-bsw-n3050 total:252 pass:213 dwarn:0 dfail:0 fail:0 skip:39
fi-bxt-j4205 total:252 pass:233 dwarn:0 dfail:0 fail:0 skip:19
fi-bxt-t5700 total:83 pass:70 dwarn:0 dfail:0 fail:0 skip:12
fi-byt-j1900 total:252 pass:225 dwarn:0 dfail:0 fail:0 skip:27
fi-byt-n2820 total:252 pass:221 dwarn:0 dfail:0 fail:0 skip:31
fi-hsw-4770 total:252 pass:236 dwarn:0 dfail:0 fail:0 skip:16
fi-hsw-4770r total:252 pass:236 dwarn:0 dfail:0 fail:0 skip:16
fi-ilk-650 total:252 pass:202 dwarn:0 dfail:0 fail:0 skip:50
fi-ivb-3520m total:252 pass:234 dwarn:0 dfail:0 fail:0 skip:18
fi-ivb-3770 total:252 pass:234 dwarn:0 dfail:0 fail:0 skip:18
fi-kbl-7500u total:252 pass:234 dwarn:0 dfail:0 fail:0 skip:18
fi-skl-6260u total:252 pass:242 dwarn:0 dfail:0 fail:0 skip:10
fi-skl-6700hq total:252 pass:235 dwarn:0 dfail:0 fail:0 skip:17
fi-skl-6700k total:252 pass:230 dwarn:4 dfail:0 fail:0 skip:18
fi-skl-6770hq total:252 pass:242 dwarn:0 dfail:0 fail:0 skip:10
fi-snb-2520m total:252 pass:224 dwarn:0 dfail:0 fail:0 skip:28
fi-snb-2600 total:252 pass:222 dwarn:0 dfail:0 fail:0 skip:30
c2033e7aa383d062000e024c5fac5f46560327cd drm-tip: 2017y-02m-16d-20h-42m-04s UTC integration manifest
198a9ee drm/i915: Remove unrequired POSTING_READ from gen6_set_rps()
== Logs ==
For more details see: https://intel-gfx-ci.01.org/CI/Patchwork_3871/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] drm/i915: Remove unrequired POSTING_READ from gen6_set_rps()
2017-02-17 8:31 [PATCH] drm/i915: Remove unrequired POSTING_READ from gen6_set_rps() Chris Wilson
2017-02-17 9:22 ` ✗ Fi.CI.BAT: warning for " Patchwork
@ 2017-02-17 10:15 ` Szwichtenberg, Radoslaw
1 sibling, 0 replies; 3+ messages in thread
From: Szwichtenberg, Radoslaw @ 2017-02-17 10:15 UTC (permalink / raw)
To: intel-gfx@lists.freedesktop.org, chris@chris-wilson.co.uk
On Fri, 2017-02-17 at 08:31 +0000, Chris Wilson wrote:
> The uncached mmio is sufficient to queue the mmio writes without raising
> forcewake. The forced flush along with acquiring forcewake from the
> posting read is not required for adjusting the RPS frequency.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Radoslaw Szwichtenberg <radoslaw.szwichtenberg@intel.com>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-02-17 10:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-02-17 8:31 [PATCH] drm/i915: Remove unrequired POSTING_READ from gen6_set_rps() Chris Wilson
2017-02-17 9:22 ` ✗ Fi.CI.BAT: warning for " Patchwork
2017-02-17 10:15 ` [PATCH] " Szwichtenberg, Radoslaw
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox