From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joonas Lahtinen Subject: Re: [PATCH] drm/i915/guc: Add onion teardown to the GuC setup Date: Mon, 20 Feb 2017 12:52:22 +0200 Message-ID: <1487587942.3454.32.camel@linux.intel.com> References: <1487082004.3057.54.camel@linux.intel.com> <1487254698-26534-1-git-send-email-oscar.mateo@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id E1B086E390 for ; Mon, 20 Feb 2017 10:52:25 +0000 (UTC) In-Reply-To: <1487254698-26534-1-git-send-email-oscar.mateo@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Oscar Mateo , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gdG8sIDIwMTctMDItMTYgYXQgMDY6MTggLTA4MDAsIE9zY2FyIE1hdGVvIHdyb3RlOgo+IFN0 YXJ0aW5nIHdpdGggaW50ZWxfZ3VjX2xvYWRlciwgZG93biB0byBpbnRlbF9ndWNfc3VibWlzc2lv bgo+IGFuZCBmaW5hbGx5IHRvIGludGVsX2d1Y19sb2cuCj4gCj4gU2lnbmVkLW9mZi1ieTogT3Nj YXIgTWF0ZW8gPG9zY2FyLm1hdGVvQGludGVsLmNvbT4KCjxTTklQPgoKPiAtc3RhdGljIHZvaWQg Z3VjX2NsaWVudF9mcmVlKHN0cnVjdCBpOTE1X2d1Y19jbGllbnQgKmNsaWVudCkKPiArc3RhdGlj IHZvaWQgZ3VjX2NsaWVudF9mcmVlKHN0cnVjdCBpOTE1X2d1Y19jbGllbnQgKipwX2NsaWVudCkK PiDCoHsKPiArCXN0cnVjdCBpOTE1X2d1Y19jbGllbnQgKmNsaWVudDsKPiArCj4gKwljbGllbnQg PSBmZXRjaF9hbmRfemVybyhwX2NsaWVudCk7Cj4gKwlpZiAoIWNsaWVudCkKPiArCQlyZXR1cm47 Cj4gKwoKTWlnaHQgYmUgdXNlZnVsIHRvIHdyYXAgdGhlIHJlbWluZGVyIG9mIHRoaXMgZnVuY3Rp b24gaW50bwpfX2d1Y19jbGllbnRfZnJlZSwgd2hpY2ggY2FuIGJlIGNhbGxlZCBkaXJlY3RseS4g QnV0IHRoYXQgY2FuIGJlIGFkZGVkCmxhdGVyLCB3aGVuIGNvZGUgZGVzY3JpYmVkIGJ5IERhbmll bGUgYXBwZWFycy4KCj4gQEAgLTgzNSwxNCArODQxLDExIEBAIHN0YXRpYyB2b2lkIGd1Y19hZGRv bl9jcmVhdGUoc3RydWN0IGludGVsX2d1YyAqZ3VjKQo+IMKgCQkJc2l6ZW9mKHN0cnVjdCBndWNf bW1pb19yZWdfc3RhdGUpICsKPiDCoAkJCUdVQ19TM19TQVZFX1NQQUNFX1BBR0VTICogUEFHRV9T SVpFOwo+IMKgCj4gLQl2bWEgPSBndWMtPmFkc192bWE7Cj4gLQlpZiAoIXZtYSkgewo+IC0JCXZt YSA9IGludGVsX2d1Y19hbGxvY2F0ZV92bWEoZ3VjLCBQQUdFX0FMSUdOKHNpemUpKTsKPiAtCQlp ZiAoSVNfRVJSKHZtYSkpCj4gLQkJCXJldHVybjsKPiArCXZtYSA9IGludGVsX2d1Y19hbGxvY2F0 ZV92bWEoZ3VjLCBQQUdFX0FMSUdOKHNpemUpKTsKPiArCWlmIChJU19FUlIodm1hKSkKPiArCQly ZXR1cm4gUFRSX0VSUih2bWEpOwo+IMKgCj4gLQkJZ3VjLT5hZHNfdm1hID0gdm1hOwo+IC0JfQo+ ICsJZ3VjLT5hZHNfdm1hID0gdm1hOwoKT25seSBub3cgcmVhbGl6ZWQgdGhlIGNvbm5lY3Rpb24s IG1heSBJIHN1Z2dlc3Qgcy9hZHNfdm1hL2FkZG9uX3ZtYS8gYXMKYSBmb2xsb3ctdXAgcGF0Y2gg OlAKCj4gQEAgLTkzNSwxNCArOTU0LDMzIEBAIGludCBpOTE1X2d1Y19zdWJtaXNzaW9uX2luaXQo c3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+IMKgCQkJCQnCoMKgwqDCoMKgwqDC oGRldl9wcml2LT5rZXJuZWxfY29udGV4dCk7Cj4gwqAJaWYgKElTX0VSUihndWMtPmV4ZWNidWZf Y2xpZW50KSkgewo+IMKgCQlEUk1fRVJST1IoIkZhaWxlZCB0byBjcmVhdGUgR3VDIGNsaWVudCBm b3IgZXhlY2J1ZiFcbiIpOwo+IC0JCWdvdG8gZXJyOwo+ICsJCXJldCA9IFBUUl9FUlIoZ3VjLT5l eGVjYnVmX2NsaWVudCk7Cj4gKwkJZ290byBlcnJfYWRzOwo+IMKgCX0KPiDCoAo+IMKgCXJldHVy biAwOwoKXG4gaGVyZSB0byBtYWtlIENocmlzIGhhcHB5LgoKPiArZXJyX2FkczoKPiArCWd1Y19h ZGRvbl9kZXN0cm95KGd1Yyk7Cj4gK2Vycl9sb2c6Cj4gKwlpbnRlbF9ndWNfbG9nX2Rlc3Ryb3ko Z3VjKTsKPiArZXJyX3ZhZGRyOgo+ICsJaTkxNV9nZW1fb2JqZWN0X3VucGluX21hcChndWMtPmN0 eF9wb29sLT5vYmopOwo+ICtlcnJfdm1hOgo+ICsJaTkxNV92bWFfdW5waW5fYW5kX3JlbGVhc2Uo Jmd1Yy0+Y3R4X3Bvb2wpOwo+IMKgCj4gLWVycjoKPiAtCWk5MTVfZ3VjX3N1Ym1pc3Npb25fZmlu aShkZXZfcHJpdik7Cj4gLQlyZXR1cm4gLUVOT01FTTsKPiArCXJldHVybiByZXQ7Cj4gK30KCjxT TklQPgoKPiAtc3RhdGljIGludCBndWNfbG9nX2NyZWF0ZV9yZWxheV9jaGFubmVsKHN0cnVjdCBp bnRlbF9ndWMgKmd1YykKPiArc3RhdGljIGludCBndWNfbG9nX3JlbGF5X2NoYW5uZWxfY3JlYXRl KHN0cnVjdCBpbnRlbF9ndWMgKmd1YykKCklmIGd1Y19sb2dfcmVsYXlfY2hhbm5lbCBpcyBnb2lu ZyB0byBiZSBhIHRoaW5nLCB0aGVuIHRoaXMgaXMgdGhlIHJpZ2h0CnRoaW5nIHRvIGRvLgoKPiBA QCAtMTcyLDEyICsxNjYsMjEgQEAgc3RhdGljIGludCBndWNfbG9nX2NyZWF0ZV9yZWxheV9jaGFu bmVsKHN0cnVjdCBpbnRlbF9ndWMgKmd1YykKPiDCoAlyZXR1cm4gMDsKPiDCoH0KPiDCoAo+IC1z dGF0aWMgaW50IGd1Y19sb2dfY3JlYXRlX3JlbGF5X2ZpbGUoc3RydWN0IGludGVsX2d1YyAqZ3Vj KQo+ICtzdGF0aWMgdm9pZCBndWNfbG9nX3JlbGF5X2NoYW5uZWxfZGVzdHJveShzdHJ1Y3QgaW50 ZWxfZ3VjICpndWMpCj4gK3sKPiArCXJlbGF5X2Nsb3NlKGd1Yy0+bG9nLnJlbGF5X2NoYW4pOwo+ ICsJZ3VjLT5sb2cucmVsYXlfY2hhbiA9IE5VTEw7CgpJZiB0aGUgcmVsYXkgY2hhbm5lbCBpcyBh IGR5bmFtaWMgdGhpbmcgd2hpY2ggZ2V0cyByZWNyZWF0ZWQgYW5kCmRlc3Ryb3llZCBpbiBydW50 aW1lLCB0aGVuIHRoaXMgaXMgT0tpc2gsIGJ1dCBpZiBpdCdzIG9ubHkgY3JlYXRlZCBhdApkcml2 ZXIgaW5pdCBhbmQgZGVzdHJveWVkIGF0IHNodXRkb3duLCB0aGVuIGRvbid0IGJvdGhlciBhc3Np Z25pbmcKTlVMTC4KCj4gK3N0YXRpYyBpbnQgZ3VjX2xvZ19yZWxheV9maWxlX2NyZWF0ZShzdHJ1 Y3QgaW50ZWxfZ3VjICpndWMpCj4gwqB7Cj4gwqAJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRl dl9wcml2ID0gZ3VjX3RvX2k5MTUoZ3VjKTsKPiDCoAlzdHJ1Y3QgZGVudHJ5ICpsb2dfZGlyOwo+ IMKgCWludCByZXQ7Cj4gwqAKPiArCWlmIChpOTE1Lmd1Y19sb2dfbGV2ZWwgPCAwKQo+ICsJCXJl dHVybiAwOyAvKiBub3RoaW5nIHRvIGRvICovCgpUaGUgY29tbWVudCBpcyBub3QgbmVjZXNzYXJ5 LCB0aGUgY2hlY2sgaXMgcmF0aGVyIHNlbGYtZXhwbGFpbmluZy4KwqAKPiBAQCAtMTk4LDcgKzIw MSwxMCBAQCBzdGF0aWMgaW50IGd1Y19sb2dfY3JlYXRlX3JlbGF5X2ZpbGUoc3RydWN0IGludGVs X2d1YyAqZ3VjKQo+ID4gwqAJfQo+IMKgCj4gwqAJcmV0ID0gcmVsYXlfbGF0ZV9zZXR1cF9maWxl cyhndWMtPmxvZy5yZWxheV9jaGFuLCAiZ3VjX2xvZyIsIGxvZ19kaXIpOwo+IC0JaWYgKHJldCkg ewo+ICsJaWYgKHJldCA9PSAtRUVYSVNUKSB7Cj4gKwkJLyogSWdub3JlICJmaWxlIGFscmVhZHkg ZXhpc3RzIiAqLwoKQ29tbWVudCBhZ2FpbiBpcyByZWR1bmRhbnQuIEp1c3Q7CgppZiAocmV0IDwg MCAmJiByZXQgIT0gLUVFWElTVFMpCgo+ICsJfQo+ICsJZWxzZSBpZiAocmV0IDwgMCkgewo+IMKg CQlEUk1fRVJST1IoIkNvdWxkbid0IGFzc29jaWF0ZSByZWxheSBjaGFuIHdpdGggZmlsZSAlZFxu IiwgcmV0KTsKPiDCoAkJcmV0dXJuIHJldDsKPiDCoAl9Cgo8U05JUD4KCj4gLXN0YXRpYyBpbnQg Z3VjX2xvZ19jcmVhdGVfZXh0cmFzKHN0cnVjdCBpbnRlbF9ndWMgKmd1YykKPiArc3RhdGljIGlu dCBndWNfbG9nX2V4dHJhc19jcmVhdGUoc3RydWN0IGludGVsX2d1YyAqZ3VjKQoKVGhlIG5hbWlu ZyBjb252ZW50aW9uIHdlIGhhdmUgaXMgcmF0aGVyIGRpZmZpY3VsdCwgaGVyZQpndWNfbG9nX2Ny ZWF0ZV9leHRyYXMgd291bGQgYmUgdGhlIHJpZ2h0IG5hbWUsIGFzICJndWNfbG9nIiBpcyB0aGUK c3RydWN0dXJlLCBhbmQgImNyZWF0ZSBleHRyYXMiIGlzIG91ciB2ZXJiLiBJZiB3ZSBoYWQgImd1 Y19sb2dfZXh0cmFzIiwKdGhlbiAiZ3VjX2xvZ19leHRyYXMiIHdvdWxkIGJlIHRoZSBzdHJ1Y3R1 cmUgYW5kICJjcmVhdGUiIHRoZSB2ZXJiLiBCdXQKaWYgeW91IGludGVuZCB0byBicmVhayBvdXQg Z3VjX2xvZ19leHRyYXMsIHRoZW4gaXQncyBnb29kLgoKQWx0aG91Z2gsIHRoZSBwdXJwb3NlIG9m IHRoaXMgZnVuY3Rpb24gc291bmRzIG1vcmUgbGlrZSBpbml0X2V4dHJhcy4KCj4gwqB7Cj4gwqAJ c3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gZ3VjX3RvX2k5MTUoZ3VjKTsKPiDC oAl2b2lkICp2YWRkcjsKPiAtCWludCByZXQ7Cj4gKwlpbnQgcmV0ID0gMDsKPiDCoAo+IMKgCWxv Y2tkZXBfYXNzZXJ0X2hlbGQoJmRldl9wcml2LT5kcm0uc3RydWN0X211dGV4KTsKPiDCoAo+IC0J LyogTm90aGluZyB0byBkbyAqLwo+IMKgCWlmIChpOTE1Lmd1Y19sb2dfbGV2ZWwgPCAwKQo+IC0J CXJldHVybiAwOwo+ICsJCXJldHVybiAwOyAvKiBub3RoaW5nIHRvIGRvICovCgpEb24ndCBiZSBz aHkgdG8gbnVrZSBzdWNoIGNvbW1lbnRzLgoKPiDCoAo+IC0JaWYgKCFndWMtPmxvZy5idWZfYWRk cikgewo+IC0JCS8qIENyZWF0ZSBhIFdDIChVbmNhY2hlZCBmb3IgcmVhZCkgdm1hbGxvYyBtYXBw aW5nIG9mIGxvZwo+IC0JCcKgKiBidWZmZXIgcGFnZXMsIHNvIHRoYXQgd2UgY2FuIGRpcmVjdGx5 IGdldCB0aGUgZGF0YQo+IC0JCcKgKiAodXAtdG8tZGF0ZSkgZnJvbSBtZW1vcnkuCj4gLQkJwqAq Lwo+IC0JCXZhZGRyID0gaTkxNV9nZW1fb2JqZWN0X3Bpbl9tYXAoZ3VjLT5sb2cudm1hLT5vYmos IEk5MTVfTUFQX1dDKTsKPiAtCQlpZiAoSVNfRVJSKHZhZGRyKSkgewo+IC0JCQlyZXQgPSBQVFJf RVJSKHZhZGRyKTsKPiAtCQkJRFJNX0VSUk9SKCJDb3VsZG4ndCBtYXAgbG9nIGJ1ZmZlciBwYWdl cyAlZFxuIiwgcmV0KTsKPiAtCQkJcmV0dXJuIHJldDsKPiAtCQl9Cj4gKwlpZiAoZ3VjLT5sb2cu YnVmX2FkZHIpCj4gKwkJcmV0dXJuIDA7IC8qIGFscmVhZHkgYWxsb2NhdGVkICovCgpUaGlzIGNo ZWNrIGNhbiBiZSBob2lzdGVkIHRvIGNhbGxpbmcgZnVuY3Rpb24gYW5kIGlmIHlvdSBmZWVsIGxp a2Ugc28sCmFkZCAiZ3VjX2hhc19sb2dfZXh0cmFzIiBoZWxwZXIuIChDb21tZW50IGlzIHJlZHVu ZGFudCBhZ2FpbikuCgpHZW5lcmFsbHkgc3BlYWtpbmcsIHRoZSBjYWxscyBzaG91bGQgbm90IGJl IGlkZW1wb3RlbnQsIHNvIGluc3RlYWQgb2YKY2hlY2tpbmcsIGFkZCBHRU1fQlVHX09OKGd1Yy0+ bG9nLmJ1Zl9hZGRyKTsgVGhlIG1vcmUgImlmInMgd2UgaGF2ZSwKdGhlIGhhcmRlciBpdCdzIHRv IGdldCBnb29kIHRlc3RpbmcgY292ZXJhZ2UuCgo8U05JUD4KCj4gKwlndWMtPmxvZy5mbHVzaF93 cSA9IGFsbG9jX29yZGVyZWRfd29ya3F1ZXVlKCJpOTE1LWd1Y19sb2ciLAo+ICsJCQkJCQnCoMKg wqDCoFdRX0hJR0hQUkkgfCBXUV9GUkVFWkFCTEUpOwo+ICsJaWYgKGd1Yy0+bG9nLmZsdXNoX3dx ID09IE5VTEwpIHsKCldoaWxlIGFyb3VuZCwgbWFrZSBpdCBpZiAoIWd1Yy0+bG9nLmZsdXNoX3dx KQoKPiArCQlEUk1fRVJST1IoIkNvdWxkbid0IGFsbG9jYXRlIHRoZSB3cSBmb3IgR3VDIGxvZ2dp bmdcbiIpOwo+ICsJCXJldCA9IC1FTk9NRU07Cj4gKwkJZ290byBlcnJfcmVsYXljaGFuOwo+IMKg CX0KPiDCoAo+IMKgCXJldHVybiAwOwoKXG4gaGVyZSBhbmQgb3RoZXIgc3BvdHMuCgo+ICtlcnJf cmVsYXljaGFuOgo+ICsJZ3VjX2xvZ19yZWxheV9jaGFubmVsX2Rlc3Ryb3koZ3VjKTsKPiArZXJy X3ZhZGRyOgo+ID4gKwlpOTE1X2dlbV9vYmplY3RfdW5waW5fbWFwKGd1Yy0+bG9nLnZtYS0+b2Jq KTsKPiArCj4gPiArCXJldHVybiByZXQ7Cj4gwqB9Cgo8U05JUD4KCj4gQEAgLTYwOSwxNyArNjE1 LDI0IEBAIGludCBpOTE1X2d1Y19sb2dfY29udHJvbChzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAq ZGV2X3ByaXYsIHU2NCBjb250cm9sX3ZhbCkKPiDCoAkJcmV0dXJuIHJldDsKPiDCoAl9Cj4gwqAK PiAtCWk5MTUuZ3VjX2xvZ19sZXZlbCA9IGxvZ19wYXJhbS52ZXJib3NpdHk7Cj4gKwlpZiAobG9n X3BhcmFtLmxvZ2dpbmdfZW5hYmxlZCkKCkV4dHJhIG5ld2xpbmUgaGVyZSB0byBiZSByZW1vdmVk LgoKQSBtdWNoIHdhbnRlZCBpbXByb3ZlbWVudC4gSSBtaWdodCBtb3ZlIHRoZSBmdW5jdGlvbiBy ZW5hbWVzIHRvCmZvbGxvdy11cCBwYXRjaGVzIHdoZW4gbmV3IHN0cnVjdHMgZ2V0IGludHJvZHVj ZWQuIEknZCBhbHNvIGxpa2Ugc29tZQpjbGFyaXR5IGJldHdlZW4gImV4dHJhcyIsICJhZGRvbiIg YW5kICJhZHMiIGluIGZvbGxvdy11cCA6KQoKV2l0aCBhYm92ZSBjaGFuZ2VzLCB0aGlzIHBhdGNo IGlzIGxvb2tpbmcgZ29vZCB0byBtZS4KClJlZ2FyZHMsIEpvb25hcwotLSAKSm9vbmFzIExhaHRp bmVuCk9wZW4gU291cmNlIFRlY2hub2xvZ3kgQ2VudGVyCkludGVsIENvcnBvcmF0aW9uCl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWls aW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZy ZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=