From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joonas Lahtinen Subject: Re: [PATCH v6] drm/i915/guc: Simplify intel_guc_init_hw() Date: Mon, 13 Mar 2017 11:38:15 +0200 Message-ID: <1489397895.3001.6.camel@linux.intel.com> References: <20170307152500.6760-8-arkadiusz.hiler@intel.com> <20170310114606.17793-1-arkadiusz.hiler@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id B2EDB6E096 for ; Mon, 13 Mar 2017 09:38:18 +0000 (UTC) In-Reply-To: <20170310114606.17793-1-arkadiusz.hiler@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Arkadiusz Hiler , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gcGUsIDIwMTctMDMtMTAgYXQgMTI6NDYgKzAxMDAsIEFya2FkaXVzeiBIaWxlciB3cm90ZToK PiBDdXJyZW50IHZlcnNpb24gb2YgaW50ZWxfZ3VjX2luaXRfaHcoKSBkb2VzIGEgbG90Ogo+IMKg LSBjYXJlcyBhYm91dCBzdWJtaXNzaW9uCj4gwqAtIGxvYWRzIGh1Ywo+IMKgLSBpbXBsZW1lbnQg V0EKPiAKPiBUaGlzIGNoYW5nZSBvZmZsb2FkcyBzb21lIG9mIHRoZSBsb2dpYyB0byBpbnRlbF91 Y19pbml0X2h3KCksIHdoaWNoIG5vdwo+IGNhcmVzIGFib3V0IHRoZSBhYm92ZS4KPiAKPiB2Mjog cmVuYW1lIGd1Y19od19yZXNldCBhbmQgZml4IHR5cG8gaW4gZGVmaW5lIG5hbWUgKE0uIFdhamRl Y3prbykKPiB2MzogcmVuYW1lIG9uY2UgYWdhaW4KPiB2NDogcmVtb3ZlIHNwdXJpb3VzIGNvbW1l bnRzIGFuZCBhZGQgc29tZSBzdHlsZSAoSi4gTGFodGluZW4pCj4gdjU6IGZsb3cgY2hhbmdlcywg Z290IHJpZCBvZiBkZWFkIGNoZWNrcyAoTS4gV2FqZGVjemtvKQo+IHY2OiByZWJhc2UKPiAKPiBD YzogQW51c2hhIFNyaXZhdHNhIDxhbnVzaGEuc3JpdmF0c2FAaW50ZWwuY29tPgo+IENjOiBNaWNo YWwgV2luaWFyc2tpIDxtaWNoYWwud2luaWFyc2tpQGludGVsLmNvbT4KPiBDYzogTWljaGFsIFdh amRlY3prbyA8bWljaGFsLndhamRlY3prb0BpbnRlbC5jb20+Cj4gQ2M6IERhbmllbGUgQ2VyYW9s byBTcHVyaW8gPGRhbmllbGUuY2VyYW9sb3NwdXJpb0BpbnRlbC5jb20+Cj4gQ2M6IEpvb25hcyBM YWh0aW5lbiA8am9vbmFzLmxhaHRpbmVuQGxpbnV4LmludGVsLmNvbT4KPiBTaWduZWQtb2ZmLWJ5 OiBBcmthZGl1c3ogSGlsZXIgPGFya2FkaXVzei5oaWxlckBpbnRlbC5jb20+Cgo8U05JUD4KCj4g K2ludCBpbnRlbF91Y19pbml0X2h3KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikK PiArewo+ICsJaW50IHJldCwgYXR0ZW1wdHM7Cj4gKwljb25zdCBpbnQgZ3VjX3dhX2hhc2hfY2hl Y2tfbm90X3NldF9hdHRlbXB0cyA9IDM7CgpJIHdvdWxkbid0IGJvdGhlciB3aXRoIHRoaXMgY29u c3QsIHRoZSBXYSBjb21tZW50IG1ha2VzIGl0IHByZXR0eSBjbGVhcgphbHJlYWR5LgoKRXh0cmEg bmV3bGluZSBoZXJlLCB0b28uCgo8U05JUD4KCj4gK2ZhaWw6Cj4gKwkvKgo+ICsJwqAqIFdlJ3Zl IGZhaWxlZCB0byBsb2FkIHRoZSBmaXJtd2FyZSA6KAo+ICsJwqAqCj4gKwnCoCogRGVjaWRlIHdo ZXRoZXIgdG8gZGlzYWJsZSBHdUMgc3VibWlzc2lvbiBhbmQgZmFsbCBiYWNrIHRvCj4gKwnCoCog ZXhlY2xpc3QgbW9kZSwgYW5kIHdoZXRoZXIgdG8gaGlkZSB0aGUgZXJyb3IgYnkgcmV0dXJuaW5n Cj4gKwnCoCogemVybyBvciB0byByZXR1cm4gLUVJTywgd2hpY2ggdGhlIGNhbGxlciB3aWxsIHRy ZWF0IGFzIGEKPiArCcKgKiBub25mYXRhbCBlcnJvciAoaS5lLiBpdCBkb2Vzbid0IHByZXZlbnQg ZHJpdmVyIGxvYWQsIGJ1dAo+ICsJwqAqIG1hcmtzIHRoZSBHUFUgYXMgd2VkZ2VkIHVudGlsIHJl c2V0KS4KPiArCcKgKi8KPiArCURSTV9FUlJPUigiR3VDIGluaXQgZmFpbGVkXG4iKTsKPiArCWlm IChpOTE1LmVuYWJsZV9ndWNfbG9hZGluZyA+IDEgfHwgaTkxNS5lbmFibGVfZ3VjX3N1Ym1pc3Np b24gPiAxKQo+ICsJCXJldCA9IC1FSU87Cj4gKwllbHNlCj4gKwkJcmV0ID0gMDsKPiArCj4gKwlp ZiAoaTkxNS5lbmFibGVfZ3VjX3N1Ym1pc3Npb24pIHsKPiArCQlpOTE1LmVuYWJsZV9ndWNfc3Vi bWlzc2lvbiA9IDA7Cj4gKwkJRFJNX05PVEUoIkZhbGxpbmcgYmFjayBmcm9tIEd1QyBzdWJtaXNz aW9uIHRvIGV4ZWNsaXN0IG1vZGVcbiIpOwo+ICsJfQo+ICsKCkknZCBkcm9wIHRoZSBhYm92ZSBj b2RlIHRvIHRoZSBib3R0b20uCgo+ICsJaTkxNV9nZ3R0X2Rpc2FibGVfZ3VjKGRldl9wcml2KTsK PiArCWludGVsX2d1Y19yZWxlYXNlX2ludGVycnVwdHMoZGV2X3ByaXYpOwo+ICsJaTkxNV9ndWNf c3VibWlzc2lvbl9kaXNhYmxlKGRldl9wcml2KTsKPiArCWk5MTVfZ3VjX3N1Ym1pc3Npb25fZmlu aShkZXZfcHJpdik7CgpBbmQgbWFrZSB0aGlzIHRlYXJkb3duIG9uaW9ueSB3aXRoIHNvbWUgbW9y ZSBsYWJlbHMuCgpXaXRoIHRob3NlIGNoYW5nZXMsIGxvb2tzIGdvb2QgdG8gbWUuCgpSZWdhcmRz LCBKb29uYXMKLS0gCkpvb25hcyBMYWh0aW5lbgpPcGVuIFNvdXJjZSBUZWNobm9sb2d5IENlbnRl cgpJbnRlbCBDb3Jwb3JhdGlvbgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVz a3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9p bnRlbC1nZngK